From 2b5db8eae41b0f3266e49e1075042fde3708031e Mon Sep 17 00:00:00 2001 From: Max Bires Date: Sun, 30 Jan 2022 20:30:00 -0800 Subject: [PATCH] Remove 'ops' field from BCC public keys. The application of ops is currently inconsistent within the spec, and wrong where it is specified. It is mapped to an integer when it should be mapped to an array that contains the integer value. Given that all key usage is strictly defined within the spec itself, there is no value currently in including the ops field. Because of this, the choice is being made to simply remove the field. Test: documentation change only Change-Id: Ia3a9895c7840e3cda9c2775080b7dcb18544d417 --- .../aidl/android/hardware/security/keymint/ProtectedData.aidl | 2 -- 1 file changed, 2 deletions(-) diff --git a/security/keymint/aidl/android/hardware/security/keymint/ProtectedData.aidl b/security/keymint/aidl/android/hardware/security/keymint/ProtectedData.aidl index 24cdbc1fa7..a14fc88804 100644 --- a/security/keymint/aidl/android/hardware/security/keymint/ProtectedData.aidl +++ b/security/keymint/aidl/android/hardware/security/keymint/ProtectedData.aidl @@ -169,7 +169,6 @@ parcelable ProtectedData { * PubKeyEd25519 = { // COSE_Key * 1 : 1, // Key type : octet key pair * 3 : AlgorithmEdDSA, // Algorithm : EdDSA - * 4 : 2, // Ops: Verify * -1 : 6, // Curve : Ed25519 * -2 : bstr // X coordinate, little-endian * } @@ -184,7 +183,6 @@ parcelable ProtectedData { * PubKeyECDSA256 = { // COSE_Key * 1 : 2, // Key type : EC2 * 3 : AlgorithmES256, // Algorithm : ECDSA w/ SHA-256 - * 4 : 2, // Ops: Verify * -1 : 1, // Curve: P256 * -2 : bstr, // X coordinate * -3 : bstr // Y coordinate