diff --git a/camera/provider/2.4/vts/functional/VtsHalCameraProviderV2_4TargetTest.cpp b/camera/provider/2.4/vts/functional/VtsHalCameraProviderV2_4TargetTest.cpp index 7bb300ed2e..deb420d1e2 100644 --- a/camera/provider/2.4/vts/functional/VtsHalCameraProviderV2_4TargetTest.cpp +++ b/camera/provider/2.4/vts/functional/VtsHalCameraProviderV2_4TargetTest.cpp @@ -7155,17 +7155,24 @@ void CameraHidlTest::castDevice(const sp& device, sp* device3_5 /*out*/, sp* device3_7 /*out*/) { ASSERT_NE(nullptr, device3_5); - if (deviceVersion == CAMERA_DEVICE_API_VERSION_3_5) { - auto castResult = device::V3_5::ICameraDevice::castFrom(device); - ASSERT_TRUE(castResult.isOk()); - *device3_5 = castResult; - } - ASSERT_NE(nullptr, device3_7); - if (deviceVersion == CAMERA_DEVICE_API_VERSION_3_7) { - auto castResult = device::V3_7::ICameraDevice::castFrom(device); - ASSERT_TRUE(castResult.isOk()); - *device3_7 = castResult; + + switch (deviceVersion) { + case CAMERA_DEVICE_API_VERSION_3_7: { + auto castResult = device::V3_7::ICameraDevice::castFrom(device); + ASSERT_TRUE(castResult.isOk()); + *device3_7 = castResult; + } + [[fallthrough]]; + case CAMERA_DEVICE_API_VERSION_3_5: { + auto castResult = device::V3_5::ICameraDevice::castFrom(device); + ASSERT_TRUE(castResult.isOk()); + *device3_5 = castResult; + break; + } + default: + // no-op + return; } }