From b00e11ff6fd36e88919bcb70719105ca6a0afafa Mon Sep 17 00:00:00 2001 From: Marin Shalamanov Date: Wed, 6 Oct 2021 16:19:03 +0200 Subject: [PATCH] Update the Composer HAL docs for setContentType setContentType can be called even if it's not supported. On some devices this surves as a signal to disable on-device post processing in order to reduce latency. Bug: 202007307 Test: n/a Change-Id: I9888d48979cd2442b54054730c78cf7b4ed6aab4 --- current.txt | 1 + graphics/composer/2.4/IComposerClient.hal | 5 ++--- .../android/hardware/graphics/composer3/IComposerClient.aidl | 5 ++--- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/current.txt b/current.txt index 21ee123576..dfc61ebe6f 100644 --- a/current.txt +++ b/current.txt @@ -903,6 +903,7 @@ c8a57364f6ad20842be14f4db284df5304f7521ca8eac6bcc1fa6c5b466fb8a6 android.hardwar # ABI preserving changes to HALs during Android T 62ace52d9c3ff1f60f94118557a2aaf0b953513e59dcd34d5f94ae28d4c7e780 android.hardware.fastboot@1.0::IFastboot +b4a59462aa7d1346ee3eaa06a8e13682462746cf1be62ed2a2bd46bf404d01b7 android.hardware.graphics.composer@2.4::IComposerClient ca62a2a95d173ed323309e5e00f653ad3cceec82a6e5e4976a249cb5aafe2515 android.hardware.neuralnetworks@1.2::types fa76bced6b1b71c40fc706c508a9011284c57f57831cd0cf5f45653ed4ea463e android.hardware.neuralnetworks@1.3::types diff --git a/graphics/composer/2.4/IComposerClient.hal b/graphics/composer/2.4/IComposerClient.hal index 1a59bbde80..e27fd6e898 100644 --- a/graphics/composer/2.4/IComposerClient.hal +++ b/graphics/composer/2.4/IComposerClient.hal @@ -307,9 +307,8 @@ interface IComposerClient extends @2.3::IComposerClient { * If the display is internally connected (not through HDMI), and such modes are available, * this method should trigger them. * - * This function should only be called if the display reports support for the corresponding - * content type (ContentType::{GRAPHICS, PHOTO, CINEMA, GAME}) from getSupportedContentTypes. - * ContentType::NONE is supported by default and can always be set. + * This function can be called for a content type even if no support for it is + * reported from getSupportedContentTypes. * * @return error is NONE upon success. Otherwise, * BAD_DISPLAY when an invalid display handle was passed in. diff --git a/graphics/composer/aidl/android/hardware/graphics/composer3/IComposerClient.aidl b/graphics/composer/aidl/android/hardware/graphics/composer3/IComposerClient.aidl index 9bde220fa4..87a3a50a12 100644 --- a/graphics/composer/aidl/android/hardware/graphics/composer3/IComposerClient.aidl +++ b/graphics/composer/aidl/android/hardware/graphics/composer3/IComposerClient.aidl @@ -690,9 +690,8 @@ interface IComposerClient { * If the display is internally connected (not through HDMI), and such modes are available, * this method should trigger them. * - * This function should only be called if the display reports support for the corresponding - * content type (ContentType::{GRAPHICS, PHOTO, CINEMA, GAME}) from getSupportedContentTypes. - * ContentType::NONE is supported by default and can always be set. + * This function can be called for a content type even if no support for it is + * reported from getSupportedContentTypes. * * @exception EX_BAD_DISPLAY when an invalid display handle was passed in. * @exception EX_UNSUPPORTED when the given content type is not supported by the composer