From b1829af24e0d00560eab288f91064b290ff2b944 Mon Sep 17 00:00:00 2001 From: shla Date: Thu, 18 Nov 2021 10:18:52 -0800 Subject: [PATCH] send command to test cec message VtsHalTvCec uses command with broadcast mode to test cec sendMessage function, however according to the cec spec about the command's description which says "A request to a device to return its Physical Address", so this command is not right for broadcast, some cec drivers deny to broadcast this command, which will obviously lead the VTS case fail. So I suggest to use command to do the job. I have verified the case can pass on Synaptics platform with this patch. bug-id: b/206924358 Change-Id: I040c72180cf90cfbceb6363a50a621acf888c654 --- tv/cec/1.0/vts/functional/VtsHalTvCecV1_0TargetTest.cpp | 2 +- tv/cec/1.1/vts/functional/VtsHalTvCecV1_1TargetTest.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tv/cec/1.0/vts/functional/VtsHalTvCecV1_0TargetTest.cpp b/tv/cec/1.0/vts/functional/VtsHalTvCecV1_0TargetTest.cpp index 7b426899b1..befd1455a4 100644 --- a/tv/cec/1.0/vts/functional/VtsHalTvCecV1_0TargetTest.cpp +++ b/tv/cec/1.0/vts/functional/VtsHalTvCecV1_0TargetTest.cpp @@ -130,7 +130,7 @@ TEST_P(HdmiCecTest, SendMessage) { message.initiator = CecLogicalAddress::PLAYBACK_1; message.destination = CecLogicalAddress::BROADCAST; message.body.resize(1); - message.body[0] = 131; + message.body[0] = 133; SendMessageResult ret = hdmiCec->sendMessage(message); EXPECT_EQ(ret, SendMessageResult::SUCCESS); } diff --git a/tv/cec/1.1/vts/functional/VtsHalTvCecV1_1TargetTest.cpp b/tv/cec/1.1/vts/functional/VtsHalTvCecV1_1TargetTest.cpp index c5b4b2fe58..acfa1eb5f1 100644 --- a/tv/cec/1.1/vts/functional/VtsHalTvCecV1_1TargetTest.cpp +++ b/tv/cec/1.1/vts/functional/VtsHalTvCecV1_1TargetTest.cpp @@ -145,7 +145,7 @@ TEST_P(HdmiCecTest, SendMessage) { message.initiator = CecLogicalAddress::PLAYBACK_1; message.destination = CecLogicalAddress::BROADCAST; message.body.resize(1); - message.body[0] = 131; + message.body[0] = 133; SendMessageResult ret = hdmiCec->sendMessage_1_1(message); EXPECT_EQ(ret, SendMessageResult::SUCCESS); }