Evolution-x/hardware_interfaces
1
0
Fork 0
mirror of https://github.com/Evolution-X/hardware_interfaces synced 2026-02-01 16:23:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

libhealthloop: Make the filterPowerSupplyEvents unit test easier to maintain

Browse Source 
Instead of hard-coding input lengths, let the compiler calculate the
input length.

Change-Id: I47d849b85dd983706bfada0293ccbdd04c8a597a
Signed-off-by: Bart Van Assche <bvanassche@google.com>
This commit is contained in:
Bart Van Assche
2024-09-03 16:53:59 -07:00
parent bee59e3b47
commit b8e15ebaa8
1 changed files with 16 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
health/utils/libhealthloop/filterPowerSupplyEventsTest.cpp
View File

@@ -192,16 +192,21 @@ TEST_P(filterPseTest, filterPse) {
bpf_object__close(obj);
}
static constexpr char input0[] = "a";
static constexpr char input1[] = "abc\0SUBSYSTEM=block\0";
static constexpr char input2[] = "\0SUBSYSTEM=block";
static constexpr char input3[] = "\0SUBSYSTEM=power_supply";
static constexpr char input4[] = "\0SUBSYSTEM=power_supply\0";
static constexpr char input5[] =
"012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789"
"012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789"
"012345678901234567890123456789012345678901234567890123456789\0SUBSYSTEM=block\0";
INSTANTIATE_TEST_SUITE_P(
filterPse, filterPseTest,
testing::Values(test_data{false, "a"},
test_data{true, std::string_view("abc\0SUBSYSTEM=block\0", 20)},
test_data{true, std::string_view("\0SUBSYSTEM=block", 16)},
test_data{true, std::string_view("\0SUBSYSTEM=power_supply", 23)},
test_data{false, std::string_view("\0SUBSYSTEM=power_supply\0", 24)},
test_data{
false,
"012345678901234567890123456789012345678901234567890123456789012345"
"678901234567890123456789012345678901234567890123456789012345678901"
"234567890123456789012345678901234567890123456789012345678901234567"
"890123456789012345678901234567890123456789\0SUBSYSTEM=block\0"}));
testing::Values(test_data{false, std::string_view(input0, sizeof(input0) - 1)},
test_data{true, std::string_view(input1, sizeof(input1) - 1)},
test_data{true, std::string_view(input2, sizeof(input2) - 1)},
test_data{true, std::string_view(input3, sizeof(input3) - 1)},
test_data{false, std::string_view(input4, sizeof(input4) - 1)},
test_data{false, std::string_view(input5, sizeof(input5) - 1)}));