From 0f0c5d17d2b5f37efdf068a390625ae45f3d5309 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Grzegorz=20Ko=C5=82odziejczyk?= Date: Wed, 25 Nov 2020 20:42:43 +0100 Subject: [PATCH] Use safe_union correctly As described in source.android.com/devices/architecture/hidl/safe_union value must be assigned through generated getter, rather than assigning it directly. Test: vts-tradefed run vts -m VtsHalBluetoothAudioV2_1TargetTest Sponsor: jpawlowski@ Bug: 150670922 Change-Id: Iefc7ee98163ec2b3387fc01c3d69c1dcd15e94bc --- bluetooth/audio/2.1/default/BluetoothAudioProvider.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bluetooth/audio/2.1/default/BluetoothAudioProvider.cpp b/bluetooth/audio/2.1/default/BluetoothAudioProvider.cpp index 092038b79a..73fe06c961 100644 --- a/bluetooth/audio/2.1/default/BluetoothAudioProvider.cpp +++ b/bluetooth/audio/2.1/default/BluetoothAudioProvider.cpp @@ -57,14 +57,14 @@ Return BluetoothAudioProvider::startSession( if (audioConfig.getDiscriminator() == V2_0::AudioConfiguration::hidl_discriminator::pcmConfig) { - audioConfig_2_1.pcmConfig() = { + audioConfig_2_1.pcmConfig({ .sampleRate = static_cast(audioConfig.pcmConfig().sampleRate), .channelMode = audioConfig.pcmConfig().channelMode, .bitsPerSample = audioConfig.pcmConfig().bitsPerSample, - .dataIntervalUs = 0}; + .dataIntervalUs = 0}); } else { - audioConfig_2_1.codecConfig() = audioConfig.codecConfig(); + audioConfig_2_1.codecConfig(audioConfig.codecConfig()); } return startSession_2_1(hostIf, audioConfig_2_1, _hidl_cb);