From bb4c2fdc0221ae49aaf77e9fd659381cc4073702 Mon Sep 17 00:00:00 2001 From: Sarah Chin Date: Fri, 12 Feb 2021 11:55:15 -0800 Subject: [PATCH] Allow getSystemSelectionChannels to return specifiers Bug: 179929817 Test: VTS Change-Id: I574e897c0fdb57cad1a3655c34d43f0d080de9ae --- radio/1.6/IRadio.hal | 2 +- radio/1.6/IRadioResponse.hal | 5 ++++- radio/1.6/vts/functional/radio_hidl_hal_utils_v1_6.h | 3 ++- radio/1.6/vts/functional/radio_response.cpp | 3 ++- 4 files changed, 9 insertions(+), 4 deletions(-) diff --git a/radio/1.6/IRadio.hal b/radio/1.6/IRadio.hal index b756ce1261..7c00e04c5c 100644 --- a/radio/1.6/IRadio.hal +++ b/radio/1.6/IRadio.hal @@ -462,7 +462,7 @@ interface IRadio extends @1.5::IRadio { * cell information isn't known then the appropriate unknown value will be returned. * This does not cause or change the rate of unsolicited cellInfoList(). * - * This is identitcal to getCellInfoList in V1.0, but it requests updated version of CellInfo. + * This is identical to getCellInfoList in V1.0, but it requests updated version of CellInfo. * * @param serial Serial number of request. * diff --git a/radio/1.6/IRadioResponse.hal b/radio/1.6/IRadioResponse.hal index 6ad5cf262a..56ce809dfe 100644 --- a/radio/1.6/IRadioResponse.hal +++ b/radio/1.6/IRadioResponse.hal @@ -19,6 +19,7 @@ package android.hardware.radio@1.6; import @1.0::SendSmsResult; import @1.4::RadioAccessFamily; import @1.5::IRadioResponse; +import @1.5::RadioAccessSpecifier; import @1.6::Call; import @1.6::CellInfo; import @1.6::RegStateResult; @@ -344,6 +345,7 @@ interface IRadioResponse extends @1.5::IRadioResponse { /** * @param info Response info struct containing response type, serial no. and error + * @param specifiers List of RadioAccessSpecifiers that are scanned. * * Valid errors returned: * RadioError:NONE @@ -351,7 +353,8 @@ interface IRadioResponse extends @1.5::IRadioResponse { * RadioError:INTERNAL_ERR * RadioError:INVALID_ARGUMENTS */ - oneway getSystemSelectionChannelsResponse(RadioResponseInfo info); + oneway getSystemSelectionChannelsResponse( + RadioResponseInfo info, vec specifiers); /** * This is identical to getCellInfoListResponse_1_5 but uses an updated version of CellInfo. diff --git a/radio/1.6/vts/functional/radio_hidl_hal_utils_v1_6.h b/radio/1.6/vts/functional/radio_hidl_hal_utils_v1_6.h index f32e31296d..f610f2af76 100644 --- a/radio/1.6/vts/functional/radio_hidl_hal_utils_v1_6.h +++ b/radio/1.6/vts/functional/radio_hidl_hal_utils_v1_6.h @@ -805,7 +805,8 @@ class RadioResponse_v1_6 : public ::android::hardware::radio::V1_6::IRadioRespon const ::android::hardware::radio::V1_6::RadioResponseInfo& info); Return getSystemSelectionChannelsResponse( - const ::android::hardware::radio::V1_6::RadioResponseInfo& info); + const ::android::hardware::radio::V1_6::RadioResponseInfo& info, + const hidl_vec<::android::hardware::radio::V1_5::RadioAccessSpecifier>& specifier); Return getSignalStrengthResponse_1_6( const ::android::hardware::radio::V1_6::RadioResponseInfo& info, diff --git a/radio/1.6/vts/functional/radio_response.cpp b/radio/1.6/vts/functional/radio_response.cpp index fad3f12e2b..027e9acd74 100644 --- a/radio/1.6/vts/functional/radio_response.cpp +++ b/radio/1.6/vts/functional/radio_response.cpp @@ -1190,7 +1190,8 @@ Return RadioResponse_v1_6::getCellInfoListResponse_1_6( } Return RadioResponse_v1_6::getSystemSelectionChannelsResponse( - const ::android::hardware::radio::V1_6::RadioResponseInfo& info) { + const ::android::hardware::radio::V1_6::RadioResponseInfo& info, + const hidl_vec<::android::hardware::radio::V1_5::RadioAccessSpecifier>& /*specifier*/) { rspInfo = info; parent_v1_6.notify(info.serial); return Void();