From bb5f29c9fb85d75656d3bd11bab625070ba83d71 Mon Sep 17 00:00:00 2001 From: Tomasz Wasilczyk Date: Mon, 10 Jul 2017 19:37:57 -0700 Subject: [PATCH] Use broadcastradio 1.1 default implementation by default. Also, remove a warning for 1.1 interface, as the hidl freeze mechanism is now in place. Bug: b/34348946 Test: VTS, instrumentalization Change-Id: I82025a7de8abd0758ba8b196bbbfc48b9322ac3b --- audio/2.0/default/Android.mk | 4 ---- audio/2.0/default/service.cpp | 16 ++-------------- broadcastradio/1.1/WARNING | 1 - 3 files changed, 2 insertions(+), 19 deletions(-) delete mode 100644 broadcastradio/1.1/WARNING diff --git a/audio/2.0/default/Android.mk b/audio/2.0/default/Android.mk index 621853cb0e..8dec48209c 100644 --- a/audio/2.0/default/Android.mk +++ b/audio/2.0/default/Android.mk @@ -84,8 +84,4 @@ else LOCAL_MULTILIB := $(AUDIOSERVER_MULTILIB) endif -ifeq ($(TARGET_USES_BCRADIO_FUTURE_FEATURES),true) -LOCAL_CFLAGS += -DTARGET_USES_BCRADIO_FUTURE_FEATURES -endif - include $(BUILD_EXECUTABLE) diff --git a/audio/2.0/default/service.cpp b/audio/2.0/default/service.cpp index 7f28d7df84..f71f1b4735 100644 --- a/audio/2.0/default/service.cpp +++ b/audio/2.0/default/service.cpp @@ -32,13 +32,7 @@ using android::hardware::audio::effect::V2_0::IEffectsFactory; using android::hardware::audio::V2_0::IDevicesFactory; using android::hardware::soundtrigger::V2_0::ISoundTriggerHw; using android::hardware::registerPassthroughServiceImplementation; -namespace broadcastradio = android::hardware::broadcastradio; - -#ifdef TARGET_USES_BCRADIO_FUTURE_FEATURES -static const bool useBroadcastRadioFutureFeatures = true; -#else -static const bool useBroadcastRadioFutureFeatures = false; -#endif +using android::hardware::broadcastradio::V1_1::IBroadcastRadioFactory; using android::OK; @@ -52,13 +46,7 @@ int main(int /* argc */, char* /* argv */ []) { // Soundtrigger and FM radio might be not present. status = registerPassthroughServiceImplementation(); ALOGE_IF(status != OK, "Error while registering soundtrigger service: %d", status); - if (useBroadcastRadioFutureFeatures) { - status = registerPassthroughServiceImplementation< - broadcastradio::V1_1::IBroadcastRadioFactory>(); - } else { - status = registerPassthroughServiceImplementation< - broadcastradio::V1_0::IBroadcastRadioFactory>(); - } + status = registerPassthroughServiceImplementation(); ALOGE_IF(status != OK, "Error while registering fm radio service: %d", status); joinRpcThreadpool(); return status; diff --git a/broadcastradio/1.1/WARNING b/broadcastradio/1.1/WARNING deleted file mode 100644 index e867cfa362..0000000000 --- a/broadcastradio/1.1/WARNING +++ /dev/null @@ -1 +0,0 @@ -This is experimental interface, do not use it yet.