From bb73ba4e68cd66f755ab681808021fecc5d06604 Mon Sep 17 00:00:00 2001 From: Jiyong Park Date: Wed, 23 Mar 2022 17:43:54 +0900 Subject: [PATCH] Add -Wno-missing-permission-annotation for soundtrigger3 Soundtrigger3 has been built with "-Werror -Weverything" (from Android.bp) and "-Weverything -Wno-missing-permission-annotation" (from the AIDL build system). The former is added only for the ToT version of an AIDL interface. So far, soundtrigger3 wasn't frozen and therefore the implicit version 1 was the ToT version. As a result, absence of @RequiresPermission in its interface didn't break the build due to the automatically added "-Wno-missing-permission-annotation" despite that it had "-Werror". However, this is causing build breakage as soundtrigger3 now has version 1 and 2 (ToT) and the version 1 is built *without* "-Wno-missing-permission-annotation". Fixing this by manually adding the diag flag so that it's applied to all versions. Bug: 225941299 Test: m Change-Id: I3a43fc77997ef900b0f173c88530f570e436bc77 --- soundtrigger/aidl/Android.bp | 1 + 1 file changed, 1 insertion(+) diff --git a/soundtrigger/aidl/Android.bp b/soundtrigger/aidl/Android.bp index ab104c878b..448895c26c 100644 --- a/soundtrigger/aidl/Android.bp +++ b/soundtrigger/aidl/Android.bp @@ -14,6 +14,7 @@ aidl_interface { flags: [ "-Werror", "-Weverything", + "-Wno-missing-permission-annotation", ], srcs: [ "android/hardware/soundtrigger3/ISoundTriggerHw.aidl",