From eccbbf8538ca5a04014fb9465574ea37e2edfe42 Mon Sep 17 00:00:00 2001 From: Pavel Maltsev Date: Wed, 24 Jan 2018 11:03:11 -0800 Subject: [PATCH] Remove unused property from Vehicle HAL Fix: b/72159812 Test: m -j ; verified device is booting up Change-Id: I99b59d58dd713d48c50be1a12d9ee2019861c080 --- automotive/vehicle/2.0/Android.bp | 1 - automotive/vehicle/2.0/types.hal | 54 ------------------------------- 2 files changed, 55 deletions(-) diff --git a/automotive/vehicle/2.0/Android.bp b/automotive/vehicle/2.0/Android.bp index a0d20f352e..bdc44efe42 100644 --- a/automotive/vehicle/2.0/Android.bp +++ b/automotive/vehicle/2.0/Android.bp @@ -48,7 +48,6 @@ hidl_interface { "VehicleHvacFanDirection", "VehicleHwKeyInputAction", "VehicleIgnitionState", - "VehicleInstrumentClusterType", "VehiclePropConfig", "VehiclePropValue", "VehicleProperty", diff --git a/automotive/vehicle/2.0/types.hal b/automotive/vehicle/2.0/types.hal index f673d1ad61..be98a5686a 100644 --- a/automotive/vehicle/2.0/types.hal +++ b/automotive/vehicle/2.0/types.hal @@ -987,41 +987,6 @@ enum VehicleProperty: int32_t { | VehiclePropertyType:INT32_VEC | VehicleArea:GLOBAL), - /** - * Property to define instrument cluster information. - * For VehicleInstrumentClusterType:EXTERNAL_DISPLAY: - * READ: - * int32Values[0] : The current screen mode index. Screen mode is defined - * as a configuration in car service and represents - * which area of screen is renderable. - * int32Values[1] : Android can render to instrument cluster (=1) or - * not(=0). When this is 0, instrument cluster may be - * rendering some information in the area allocated for - * android and android side rendering is invisible. - * WRITE from android: - * int32Values[0] : Preferred mode for android side. Depending on the app - * rendering to instrument cluster, preferred mode can - * change. Instrument cluster still needs to send - * event with new mode to trigger actual mode change. - * int32Values[1] : The current app context relevant for instrument - * cluster. Use the same flag with - * VehicleAudioContextFlag but this context represents - * active apps, not active audio. Instrument cluster - * side may change mode depending on the currently - * active contexts. - * When system boots up, Android side will write {0, 0, 0, 0} when it is - * ready to render to instrument cluster. Before this message, rendering - * from android must not be visible in the cluster. - * @change_mode VehiclePropertyChangeMode:ON_CHANGE - * @access VehiclePropertyAccess:READ_WRITE - * @configArray 0:VehicleInstrumentClusterType 1:hw type - */ - INSTRUMENT_CLUSTER_INFO = ( - 0x0A20 - | VehiclePropertyGroup:SYSTEM - | VehiclePropertyType:INT32_VEC - | VehicleArea:GLOBAL), - /** * Current date and time, encoded as Unix time. * This value denotes the number of seconds that have elapsed since @@ -2066,25 +2031,6 @@ enum VehicleDisplay : int32_t { INSTRUMENT_CLUSTER = 1, }; -/** - * Represents instrument cluster type available in system - */ -enum VehicleInstrumentClusterType : int32_t { - /** Android has no access to instument cluster */ - NONE = 0, - - /** - * Instrument cluster can communicate through vehicle hal with additional - * properties to exchange meta-data - */ - HAL_INTERFACE = 1, - - /** - * Instrument cluster is external display where android can render contents - */ - EXTERNAL_DISPLAY = 2, -}; - /** * Units used for int or float type with no attached enum types. */