From 8fec556d253f5b3b4bd9b38f3a10f08677425164 Mon Sep 17 00:00:00 2001
From: Jeff Pu <jeffpu@google.com>
Date: Thu, 20 Jul 2023 13:07:04 +0000
Subject: [PATCH] Authentication state stays on enrollment mismatch

Bug: 291778822
Test: atest FakeFingerprintEngineTest
Change-Id: I4566303af982855aa0ebc52652464fb116a23858
---
 biometrics/fingerprint/aidl/default/FakeFingerprintEngine.cpp   | 2 +-
 .../aidl/default/tests/FakeFingerprintEngineTest.cpp            | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/biometrics/fingerprint/aidl/default/FakeFingerprintEngine.cpp b/biometrics/fingerprint/aidl/default/FakeFingerprintEngine.cpp
index 975728764b..9f9ca96cd6 100644
--- a/biometrics/fingerprint/aidl/default/FakeFingerprintEngine.cpp
+++ b/biometrics/fingerprint/aidl/default/FakeFingerprintEngine.cpp
@@ -258,7 +258,7 @@ bool FakeFingerprintEngine::onAuthenticateFingerDown(ISessionCallback* cb,
         cb->onAuthenticationFailed();
         mLockoutTracker.addFailedAttempt();
         checkSensorLockout(cb);
-        return true;
+        return false;
     }
 }
 
diff --git a/biometrics/fingerprint/aidl/default/tests/FakeFingerprintEngineTest.cpp b/biometrics/fingerprint/aidl/default/tests/FakeFingerprintEngineTest.cpp
index e7e8a476eb..bc235a6c65 100644
--- a/biometrics/fingerprint/aidl/default/tests/FakeFingerprintEngineTest.cpp
+++ b/biometrics/fingerprint/aidl/default/tests/FakeFingerprintEngineTest.cpp
@@ -269,6 +269,7 @@ TEST_F(FakeFingerprintEngineTest, AuthenticateNotEnrolled) {
     mEngine.authenticateImpl(mCallback.get(), 0, mCancel.get_future());
     mEngine.fingerDownAction();
     ASSERT_TRUE(mCallback->mAuthenticateFailed);
+    ASSERT_EQ(mEngine.getWorkMode(), FakeFingerprintEngine::WorkMode::kAuthenticate);
 }
 
 TEST_F(FakeFingerprintEngineTest, AuthenticateLockout) {