diff --git a/radio/config/1.0/vts/functional/Android.bp b/radio/config/1.0/vts/functional/Android.bp index 9c96030996..859b24bde9 100644 --- a/radio/config/1.0/vts/functional/Android.bp +++ b/radio/config/1.0/vts/functional/Android.bp @@ -29,5 +29,5 @@ cc_test { "android.hardware.radio.config@1.0", ], header_libs: ["radio.util.header@1.0"], - test_suites: ["general-tests"], + test_suites: ["general-tests", "vts-core"], } diff --git a/radio/config/1.0/vts/functional/VtsHalRadioConfigV1_0TargetTest.cpp b/radio/config/1.0/vts/functional/VtsHalRadioConfigV1_0TargetTest.cpp index 2fc6b62345..b3fae86a19 100644 --- a/radio/config/1.0/vts/functional/VtsHalRadioConfigV1_0TargetTest.cpp +++ b/radio/config/1.0/vts/functional/VtsHalRadioConfigV1_0TargetTest.cpp @@ -16,11 +16,7 @@ #include -int main(int argc, char** argv) { - ::testing::AddGlobalTestEnvironment(RadioConfigHidlEnvironment::Instance()); - ::testing::InitGoogleTest(&argc, argv); - RadioConfigHidlEnvironment::Instance()->init(&argc, argv); - int status = RUN_ALL_TESTS(); - LOG(INFO) << "Test result = " << status; - return status; -} +INSTANTIATE_TEST_SUITE_P( + PerInstance, RadioConfigHidlTest, + testing::ValuesIn(android::hardware::getAllHalInstanceNames(IRadioConfig::descriptor)), + android::hardware::PrintInstanceNameToString); diff --git a/radio/config/1.0/vts/functional/radio_config_hidl_hal_api.cpp b/radio/config/1.0/vts/functional/radio_config_hidl_hal_api.cpp index 67823143e8..4ff560fc51 100644 --- a/radio/config/1.0/vts/functional/radio_config_hidl_hal_api.cpp +++ b/radio/config/1.0/vts/functional/radio_config_hidl_hal_api.cpp @@ -21,7 +21,7 @@ /* * Test IRadioConfig.getSimSlotsStatus() */ -TEST_F(RadioConfigHidlTest, getSimSlotsStatus) { +TEST_P(RadioConfigHidlTest, getSimSlotsStatus) { const int serial = GetRandomSerialNumber(); Return res = radioConfig->getSimSlotsStatus(serial); ASSERT_OK(res); @@ -38,7 +38,7 @@ TEST_F(RadioConfigHidlTest, getSimSlotsStatus) { /* * Test IRadioConfig.setSimSlotsMapping() */ -TEST_F(RadioConfigHidlTest, setSimSlotsMapping) { +TEST_P(RadioConfigHidlTest, setSimSlotsMapping) { const int serial = GetRandomSerialNumber(); android::hardware::hidl_vec mapping = {0}; Return res = radioConfig->setSimSlotsMapping(serial, mapping); diff --git a/radio/config/1.0/vts/functional/radio_config_hidl_hal_test.cpp b/radio/config/1.0/vts/functional/radio_config_hidl_hal_test.cpp index c01dc4c496..f589e2f2a4 100644 --- a/radio/config/1.0/vts/functional/radio_config_hidl_hal_test.cpp +++ b/radio/config/1.0/vts/functional/radio_config_hidl_hal_test.cpp @@ -17,14 +17,10 @@ #include void RadioConfigHidlTest::SetUp() { - radioConfig = ::testing::VtsHalHidlTargetTestBase::getService( - RadioConfigHidlEnvironment::Instance()->getServiceName( - hidl_string(RADIO_SERVICE_NAME))); + radioConfig = IRadioConfig::getService(GetParam()); if (radioConfig == NULL) { sleep(60); - radioConfig = ::testing::VtsHalHidlTargetTestBase::getService( - RadioConfigHidlEnvironment::Instance()->getServiceName( - hidl_string(RADIO_SERVICE_NAME))); + radioConfig = IRadioConfig::getService(GetParam()); } ASSERT_NE(nullptr, radioConfig.get()); diff --git a/radio/config/1.0/vts/functional/radio_config_hidl_hal_utils.h b/radio/config/1.0/vts/functional/radio_config_hidl_hal_utils.h index e7d697a742..6bc1b659be 100644 --- a/radio/config/1.0/vts/functional/radio_config_hidl_hal_utils.h +++ b/radio/config/1.0/vts/functional/radio_config_hidl_hal_utils.h @@ -16,8 +16,6 @@ #include -#include -#include #include #include #include @@ -26,6 +24,9 @@ #include #include #include +#include +#include +#include #include "vts_test_util.h" @@ -76,22 +77,8 @@ class RadioConfigIndication : public IRadioConfigIndication { RadioIndicationType type, const ::android::hardware::hidl_vec& slotStatus); }; -// Test environment for Radio HIDL HAL. -class RadioConfigHidlEnvironment : public ::testing::VtsHalHidlTargetTestEnvBase { - public: - // get the test environment singleton - static RadioConfigHidlEnvironment* Instance() { - static RadioConfigHidlEnvironment* instance = new RadioConfigHidlEnvironment; - return instance; - } - virtual void registerTestServices() override { registerTestService(); } - - private: - RadioConfigHidlEnvironment() {} -}; - // The main test class for Radio config HIDL. -class RadioConfigHidlTest : public ::testing::VtsHalHidlTargetTestBase { +class RadioConfigHidlTest : public ::testing::TestWithParam { protected: std::mutex mtx_; std::condition_variable cv_;