diff --git a/tv/cec/1.0/default/HdmiCec.cpp b/tv/cec/1.0/default/HdmiCec.cpp index ebe26816b3..171bdfe04f 100644 --- a/tv/cec/1.0/default/HdmiCec.cpp +++ b/tv/cec/1.0/default/HdmiCec.cpp @@ -264,8 +264,7 @@ static_assert(HDMI_OPTION_SYSTEM_CEC_CONTROL == static_cast(OptionKey::SYST sp HdmiCec::mCallback = nullptr; -HdmiCec::HdmiCec(hdmi_cec_device_t* device) : mDevice(device) { -} +HdmiCec::HdmiCec(hdmi_cec_device_t* device) : mDevice(device) {} // Methods from ::android::hardware::tv::cec::V1_0::IHdmiCec follow. Return HdmiCec::addLogicalAddress(CecLogicalAddress addr) { @@ -319,8 +318,16 @@ Return HdmiCec::sendMessage(const CecMessage& message) { } Return HdmiCec::setCallback(const sp& callback) { - mCallback = callback; - mDevice->register_event_callback(mDevice, eventCallback, nullptr); + if (mCallback != nullptr) { + mCallback->unlinkToDeath(this); + mCallback = nullptr; + } + + if (callback != nullptr) { + mCallback = callback; + mCallback->linkToDeath(this, 0 /*cookie*/); + mDevice->register_event_callback(mDevice, eventCallback, nullptr); + } return Void(); } diff --git a/tv/cec/1.0/default/HdmiCec.h b/tv/cec/1.0/default/HdmiCec.h index 34a3bb0816..0133abc087 100644 --- a/tv/cec/1.0/default/HdmiCec.h +++ b/tv/cec/1.0/default/HdmiCec.h @@ -47,7 +47,7 @@ using ::android::hardware::hidl_vec; using ::android::hardware::hidl_string; using ::android::sp; -struct HdmiCec : public IHdmiCec { +struct HdmiCec : public IHdmiCec, public hidl_death_recipient { HdmiCec(hdmi_cec_device_t* device); // Methods from ::android::hardware::tv::cec::V1_0::IHdmiCec follow. Return addLogicalAddress(CecLogicalAddress addr) override; @@ -87,7 +87,12 @@ struct HdmiCec : public IHdmiCec { } } -private: + virtual void serviceDied(uint64_t /*cookie*/, + const wp<::android::hidl::base::V1_0::IBase>& /*who*/) { + setCallback(nullptr); + } + + private: static sp mCallback; const hdmi_cec_device_t* mDevice; };