From fcf3654783dc0e0fb9060420b8d384d7d1c42beb Mon Sep 17 00:00:00 2001 From: Sanket Padawe Date: Tue, 24 Jan 2017 14:41:33 -0800 Subject: [PATCH] Removed TODOs from radio hal. + Opened new bug b/34683858 for addressing one of the TODO in P. Bug: 34109705 Test: Removed only comments. Change-Id: Ie78eacbc80def2df3ec448f14a89fbac185bf2af --- radio/1.0/IRadioIndication.hal | 6 +----- radio/1.0/types.hal | 6 ------ 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/radio/1.0/IRadioIndication.hal b/radio/1.0/IRadioIndication.hal index 79ebf30d17..fb8666f338 100644 --- a/radio/1.0/IRadioIndication.hal +++ b/radio/1.0/IRadioIndication.hal @@ -342,10 +342,6 @@ interface IRadioIndication { oneway exitEmergencyCallbackMode(RadioIndicationType type); /* - * TODO(Consider moving this to separate interface. Client will receive this function with an - * IRadioResponse interface so that all requests in that IRadioResponse will fail before - * rilConnected() is received) - * * Indicates the ril connects and returns the version * * @param type Type of radio indication @@ -472,4 +468,4 @@ interface IRadioIndication { * restart" that explains the cause of the modem restart */ oneway modemReset(RadioIndicationType type, string reason); -}; \ No newline at end of file +}; diff --git a/radio/1.0/types.hal b/radio/1.0/types.hal index 941a59ebfd..ebc1384678 100644 --- a/radio/1.0/types.hal +++ b/radio/1.0/types.hal @@ -117,9 +117,6 @@ enum RadioError : int32_t { ABORTED = 65, // Operation aborted INVALID_RESPONSE = 66, // Response from vendor had invalid data - // TODO(May be moved to vendor HAL extension) - // OEM specific error codes. To be used by OEM when they don't want to reveal - // specific error codes which would be replaced by Generic failure. OEM_ERROR_1 = 501, OEM_ERROR_2 = 502, OEM_ERROR_3 = 503, @@ -462,9 +459,6 @@ enum DataCallFailCause : int32_t { AUTH_FAILURE_ON_EMERGENCY_CALL = 0x7A, OEM_DCFAILCAUSE_1 = 0x1001, - // OEM specific error codes. To be used by OEMs when they don't want to - // reveal error code which would be replaced by PDP_FAIL_ERROR_UNSPECIFIED - // TODO(May be moved to vendor HAL extension) OEM_DCFAILCAUSE_2 = 0x1002, OEM_DCFAILCAUSE_3 = 0x1003, OEM_DCFAILCAUSE_4 = 0x1004,