diff --git a/security/keymint/aidl/vts/functional/AttestKeyTest.cpp b/security/keymint/aidl/vts/functional/AttestKeyTest.cpp index 970ae671ad..99d25106aa 100644 --- a/security/keymint/aidl/vts/functional/AttestKeyTest.cpp +++ b/security/keymint/aidl/vts/functional/AttestKeyTest.cpp @@ -846,13 +846,39 @@ TEST_P(AttestKeyTest, EcdsaAttestationID) { // Collection of valid attestation ID tags. auto attestation_id_tags = AuthorizationSetBuilder(); - add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_BRAND, "ro.product.brand"); + // Use ro.product.brand_for_attestation property for attestation if it is present else fallback + // to ro.product.brand + std::string prop_value = + ::android::base::GetProperty("ro.product.brand_for_attestation", /* default= */ ""); + if (!prop_value.empty()) { + add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_BRAND, + "ro.product.brand_for_attestation"); + } else { + add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_BRAND, "ro.product.brand"); + } add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_DEVICE, "ro.product.device"); - add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_PRODUCT, "ro.product.name"); + // Use ro.product.name_for_attestation property for attestation if it is present else fallback + // to ro.product.name + prop_value = ::android::base::GetProperty("ro.product.name_for_attestation", /* default= */ ""); + if (!prop_value.empty()) { + add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_PRODUCT, + "ro.product.name_for_attestation"); + } else { + add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_PRODUCT, "ro.product.name"); + } add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_SERIAL, "ro.serialno"); add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_MANUFACTURER, "ro.product.manufacturer"); - add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_MODEL, "ro.product.model"); + // Use ro.product.model_for_attestation property for attestation if it is present else fallback + // to ro.product.model + prop_value = + ::android::base::GetProperty("ro.product.model_for_attestation", /* default= */ ""); + if (!prop_value.empty()) { + add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_MODEL, + "ro.product.model_for_attestation"); + } else { + add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_MODEL, "ro.product.model"); + } string imei = get_imei(0); if (!imei.empty()) { diff --git a/security/keymint/aidl/vts/functional/DeviceUniqueAttestationTest.cpp b/security/keymint/aidl/vts/functional/DeviceUniqueAttestationTest.cpp index 26dc3f510f..55bb5b4fab 100644 --- a/security/keymint/aidl/vts/functional/DeviceUniqueAttestationTest.cpp +++ b/security/keymint/aidl/vts/functional/DeviceUniqueAttestationTest.cpp @@ -249,13 +249,39 @@ TEST_P(DeviceUniqueAttestationTest, EcdsaDeviceUniqueAttestationID) { // Collection of valid attestation ID tags. auto attestation_id_tags = AuthorizationSetBuilder(); - add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_BRAND, "ro.product.brand"); + // Use ro.product.brand_for_attestation property for attestation if it is present else fallback + // to ro.product.brand + std::string prop_value = + ::android::base::GetProperty("ro.product.brand_for_attestation", /* default= */ ""); + if (!prop_value.empty()) { + add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_BRAND, + "ro.product.brand_for_attestation"); + } else { + add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_BRAND, "ro.product.brand"); + } add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_DEVICE, "ro.product.device"); - add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_PRODUCT, "ro.product.name"); + // Use ro.product.name_for_attestation property for attestation if it is present else fallback + // to ro.product.name + prop_value = ::android::base::GetProperty("ro.product.name_for_attestation", /* default= */ ""); + if (!prop_value.empty()) { + add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_PRODUCT, + "ro.product.name_for_attestation"); + } else { + add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_PRODUCT, "ro.product.name"); + } add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_SERIAL, "ro.serialno"); add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_MANUFACTURER, "ro.product.manufacturer"); - add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_MODEL, "ro.product.model"); + // Use ro.product.model_for_attestation property for attestation if it is present else fallback + // to ro.product.model + prop_value = + ::android::base::GetProperty("ro.product.model_for_attestation", /* default= */ ""); + if (!prop_value.empty()) { + add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_MODEL, + "ro.product.model_for_attestation"); + } else { + add_tag_from_prop(&attestation_id_tags, TAG_ATTESTATION_ID_MODEL, "ro.product.model"); + } vector key_blob; vector key_characteristics; diff --git a/security/keymint/aidl/vts/functional/KeyMintTest.cpp b/security/keymint/aidl/vts/functional/KeyMintTest.cpp index 2440977c56..1b9e758b11 100644 --- a/security/keymint/aidl/vts/functional/KeyMintTest.cpp +++ b/security/keymint/aidl/vts/functional/KeyMintTest.cpp @@ -2080,12 +2080,38 @@ TEST_P(NewKeyGenerationTest, EcdsaAttestationIdTags) { // Various ATTESTATION_ID_* tags that map to fields in the attestation extension ASN.1 schema. auto extra_tags = AuthorizationSetBuilder(); - add_tag_from_prop(&extra_tags, TAG_ATTESTATION_ID_BRAND, "ro.product.brand"); + // Use ro.product.brand_for_attestation property for attestation if it is present else fallback + // to ro.product.brand + std::string prop_value = + ::android::base::GetProperty("ro.product.brand_for_attestation", /* default= */ ""); + if (!prop_value.empty()) { + add_tag_from_prop(&extra_tags, TAG_ATTESTATION_ID_BRAND, + "ro.product.brand_for_attestation"); + } else { + add_tag_from_prop(&extra_tags, TAG_ATTESTATION_ID_BRAND, "ro.product.brand"); + } add_tag_from_prop(&extra_tags, TAG_ATTESTATION_ID_DEVICE, "ro.product.device"); - add_tag_from_prop(&extra_tags, TAG_ATTESTATION_ID_PRODUCT, "ro.product.name"); + // Use ro.product.name_for_attestation property for attestation if it is present else fallback + // to ro.product.name + prop_value = ::android::base::GetProperty("ro.product.name_for_attestation", /* default= */ ""); + if (!prop_value.empty()) { + add_tag_from_prop(&extra_tags, TAG_ATTESTATION_ID_PRODUCT, + "ro.product.name_for_attestation"); + } else { + add_tag_from_prop(&extra_tags, TAG_ATTESTATION_ID_PRODUCT, "ro.product.name"); + } add_tag_from_prop(&extra_tags, TAG_ATTESTATION_ID_SERIAL, "ro.serialno"); add_tag_from_prop(&extra_tags, TAG_ATTESTATION_ID_MANUFACTURER, "ro.product.manufacturer"); - add_tag_from_prop(&extra_tags, TAG_ATTESTATION_ID_MODEL, "ro.product.model"); + // Use ro.product.model_for_attestation property for attestation if it is present else fallback + // to ro.product.model + prop_value = + ::android::base::GetProperty("ro.product.model_for_attestation", /* default= */ ""); + if (!prop_value.empty()) { + add_tag_from_prop(&extra_tags, TAG_ATTESTATION_ID_MODEL, + "ro.product.model_for_attestation"); + } else { + add_tag_from_prop(&extra_tags, TAG_ATTESTATION_ID_MODEL, "ro.product.model"); + } for (const KeyParameter& tag : extra_tags) { SCOPED_TRACE(testing::Message() << "tag-" << tag);