From ae119c5198b4140697661e654fb442990e4ab413 Mon Sep 17 00:00:00 2001 From: Aaqib Ismail Date: Tue, 10 Jan 2023 16:17:12 -0800 Subject: [PATCH] Update ADAS ENABLED properties documentation if property unavailable An implementation of AUTOMATIC_EMERGENCY_BRAKING_ENABLED or FORWARD_COLLISION_WARNING_ENABLED should return false when there's an issue with the ADAS system and it cannot retrieve the property. It should not return NOT_AVAILABLE. Bug: 264946034 Test: atest VtsHalAutomotiveVehicle_TargetTest Change-Id: Ieddbcdf766543cfb94cb5b295b22ac4369641c81 --- .../hardware/automotive/vehicle/VehicleProperty.aidl | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/automotive/vehicle/aidl_property/android/hardware/automotive/vehicle/VehicleProperty.aidl b/automotive/vehicle/aidl_property/android/hardware/automotive/vehicle/VehicleProperty.aidl index ce152200da..446a9fa4c3 100644 --- a/automotive/vehicle/aidl_property/android/hardware/automotive/vehicle/VehicleProperty.aidl +++ b/automotive/vehicle/aidl_property/android/hardware/automotive/vehicle/VehicleProperty.aidl @@ -3429,9 +3429,9 @@ enum VehicleProperty { * Set true to enable AEB and false to disable AEB. When AEB is enabled, the ADAS system in the * vehicle should be turned on and monitoring to avoid potential collisions. * - * IVehicle#get must not return any NOT_AVAILABLE value in StatusCode. Other StatusCode values - * like TRY_AGAIN may still be used as needed. For example, if AEB is not available because the - * vehicle speed is too low, IVehicle#get must return false. + * If AEB is not available, IVehicle#get must not return any NOT_AVAILABLE value in StatusCode. + * Other StatusCode values like TRY_AGAIN may still be used as needed. For example, if AEB is + * not available because the vehicle speed is too low, IVehicle#get must return false. * * This property is defined as read_write, but OEMs have the option to implement it as read * only. @@ -3470,6 +3470,10 @@ enum VehicleProperty { * Set true to enable FCW and false to disable FCW. When FCW is enabled, the ADAS system in the * vehicle should be turned on and monitoring for potential collisions. * + * If FCW is not available, IVehicle#get must not return any NOT_AVAILABLE value in StatusCode. + * Other StatusCode values like TRY_AGAIN may still be used as needed. For example, if FCW is + * not available because the vehicle speed is too low, IVehicle#get must return false. + * * This property is defined as read_write, but OEMs have the option to implement it as read * only. *