mirror of
https://github.com/Evolution-X/hardware_interfaces
synced 2026-02-01 22:04:26 +00:00
Fix IC vts bugs and add tests for IC IWritableIdentityCredential.aidl interface.
Fixed following bugs in WritableIdentityCredential.cpp
- Do not allow startPersonalization to be called more than once per
aidl.
- Do not preceed with beginAddEntry if addAccessControlProfile and
startPersonalization profile count mismatch.
- Verify access control profile ids are unique.
- Do not let empty name space to mess up beginAddEntry.
- Do not allow beginAddEntry to add entries interleaving namespace
groupings. Enforce all entries must be added in namespace "groups"
per aidl.
- Fix counting error that allowed one entries to be added per name
space than startPersonalization limit.
- Do not approve finishAddingEntries if there are more profiles or
entries to be added than startPersonalization set accounting.
- Add testing utilities library for identity credential.
- Refactored end to end tests.
Bug: 154909726
Test: atest VtsHalIdentityTargetTest
Test: atest android.security.identity.cts
Merged-In: I51902681776c6230e49589fc75a8145e79d7d1a6
Change-Id: Ib7c108f67c61125edba6177dcac61cfbf58da671
This commit is contained in:
committed by
David Zeuthen
parent
d78626d962
commit
d39b9fb604
179
identity/aidl/vts/VtsIdentityTestUtils.cpp
Normal file
179
identity/aidl/vts/VtsIdentityTestUtils.cpp
Normal file
@@ -0,0 +1,179 @@
|
||||
/*
|
||||
* Copyright 2019, The Android Open Source Project
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
#include "VtsIdentityTestUtils.h"
|
||||
|
||||
#include <aidl/Gtest.h>
|
||||
#include <map>
|
||||
|
||||
namespace android::hardware::identity::test_utils {
|
||||
|
||||
using std::endl;
|
||||
using std::map;
|
||||
using std::optional;
|
||||
using std::string;
|
||||
using std::vector;
|
||||
|
||||
using ::android::sp;
|
||||
using ::android::String16;
|
||||
using ::android::binder::Status;
|
||||
|
||||
bool SetupWritableCredential(sp<IWritableIdentityCredential>& writableCredential,
|
||||
sp<IIdentityCredentialStore>& credentialStore) {
|
||||
if (credentialStore == nullptr) {
|
||||
return false;
|
||||
}
|
||||
|
||||
string docType = "org.iso.18013-5.2019.mdl";
|
||||
bool testCredential = true;
|
||||
Status result = credentialStore->createCredential(docType, testCredential, &writableCredential);
|
||||
|
||||
if (result.isOk() && writableCredential != nullptr) {
|
||||
return true;
|
||||
} else {
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
||||
optional<vector<uint8_t>> GenerateReaderCertificate(string serialDecimal) {
|
||||
vector<uint8_t> privKey;
|
||||
return GenerateReaderCertificate(serialDecimal, privKey);
|
||||
}
|
||||
|
||||
optional<vector<uint8_t>> GenerateReaderCertificate(string serialDecimal,
|
||||
vector<uint8_t>& readerPrivateKey) {
|
||||
optional<vector<uint8_t>> readerKeyPKCS8 = support::createEcKeyPair();
|
||||
if (!readerKeyPKCS8) {
|
||||
return {};
|
||||
}
|
||||
|
||||
optional<vector<uint8_t>> readerPublicKey =
|
||||
support::ecKeyPairGetPublicKey(readerKeyPKCS8.value());
|
||||
optional<vector<uint8_t>> readerKey = support::ecKeyPairGetPrivateKey(readerKeyPKCS8.value());
|
||||
if (!readerPublicKey || !readerKey) {
|
||||
return {};
|
||||
}
|
||||
|
||||
readerPrivateKey = readerKey.value();
|
||||
|
||||
string issuer = "Android Open Source Project";
|
||||
string subject = "Android IdentityCredential VTS Test";
|
||||
time_t validityNotBefore = time(nullptr);
|
||||
time_t validityNotAfter = validityNotBefore + 365 * 24 * 3600;
|
||||
|
||||
return support::ecPublicKeyGenerateCertificate(readerPublicKey.value(), readerKey.value(),
|
||||
serialDecimal, issuer, subject,
|
||||
validityNotBefore, validityNotAfter);
|
||||
}
|
||||
|
||||
optional<vector<SecureAccessControlProfile>> AddAccessControlProfiles(
|
||||
sp<IWritableIdentityCredential>& writableCredential,
|
||||
const vector<TestProfile>& testProfiles) {
|
||||
Status result;
|
||||
|
||||
vector<SecureAccessControlProfile> secureProfiles;
|
||||
|
||||
for (const auto& testProfile : testProfiles) {
|
||||
SecureAccessControlProfile profile;
|
||||
Certificate cert;
|
||||
cert.encodedCertificate = testProfile.readerCertificate;
|
||||
result = writableCredential->addAccessControlProfile(
|
||||
testProfile.id, cert, testProfile.userAuthenticationRequired,
|
||||
testProfile.timeoutMillis, 0, &profile);
|
||||
|
||||
// Don't use assert so all errors can be outputed. Then return
|
||||
// instead of exit even on errors so caller can decide.
|
||||
EXPECT_TRUE(result.isOk()) << result.exceptionCode() << "; " << result.exceptionMessage()
|
||||
<< "test profile id = " << testProfile.id << endl;
|
||||
EXPECT_EQ(testProfile.id, profile.id);
|
||||
EXPECT_EQ(testProfile.readerCertificate, profile.readerCertificate.encodedCertificate);
|
||||
EXPECT_EQ(testProfile.userAuthenticationRequired, profile.userAuthenticationRequired);
|
||||
EXPECT_EQ(testProfile.timeoutMillis, profile.timeoutMillis);
|
||||
EXPECT_EQ(support::kAesGcmTagSize + support::kAesGcmIvSize, profile.mac.size());
|
||||
|
||||
if (!result.isOk() || testProfile.id != profile.id ||
|
||||
testProfile.readerCertificate != profile.readerCertificate.encodedCertificate ||
|
||||
testProfile.userAuthenticationRequired != profile.userAuthenticationRequired ||
|
||||
testProfile.timeoutMillis != profile.timeoutMillis ||
|
||||
support::kAesGcmTagSize + support::kAesGcmIvSize != profile.mac.size()) {
|
||||
return {};
|
||||
}
|
||||
|
||||
secureProfiles.push_back(profile);
|
||||
}
|
||||
|
||||
return secureProfiles;
|
||||
}
|
||||
|
||||
// Most test expects this function to pass. So we will print out additional
|
||||
// value if failed so more debug data can be provided.
|
||||
bool AddEntry(sp<IWritableIdentityCredential>& writableCredential, const TestEntryData& entry,
|
||||
int dataChunkSize, map<const TestEntryData*, vector<vector<uint8_t>>>& encryptedBlobs,
|
||||
bool expectSuccess) {
|
||||
Status result;
|
||||
vector<vector<uint8_t>> chunks = support::chunkVector(entry.valueCbor, dataChunkSize);
|
||||
|
||||
result = writableCredential->beginAddEntry(entry.profileIds, entry.nameSpace, entry.name,
|
||||
entry.valueCbor.size());
|
||||
|
||||
if (expectSuccess) {
|
||||
EXPECT_TRUE(result.isOk())
|
||||
<< result.exceptionCode() << "; " << result.exceptionMessage() << endl
|
||||
<< "entry name = " << entry.name << ", name space=" << entry.nameSpace << endl;
|
||||
}
|
||||
|
||||
if (!result.isOk()) {
|
||||
return false;
|
||||
}
|
||||
|
||||
vector<vector<uint8_t>> encryptedChunks;
|
||||
for (const auto& chunk : chunks) {
|
||||
vector<uint8_t> encryptedContent;
|
||||
result = writableCredential->addEntryValue(chunk, &encryptedContent);
|
||||
if (expectSuccess) {
|
||||
EXPECT_TRUE(result.isOk())
|
||||
<< result.exceptionCode() << "; " << result.exceptionMessage() << endl
|
||||
<< "entry name = " << entry.name << ", name space = " << entry.nameSpace
|
||||
<< endl;
|
||||
|
||||
EXPECT_GT(encryptedContent.size(), 0u) << "entry name = " << entry.name
|
||||
<< ", name space = " << entry.nameSpace << endl;
|
||||
}
|
||||
|
||||
if (!result.isOk() || encryptedContent.size() <= 0u) {
|
||||
return false;
|
||||
}
|
||||
|
||||
encryptedChunks.push_back(encryptedContent);
|
||||
}
|
||||
|
||||
encryptedBlobs[&entry] = encryptedChunks;
|
||||
return true;
|
||||
}
|
||||
|
||||
bool ValidateAttestationCertificate(vector<Certificate>& inputCertificates) {
|
||||
return (inputCertificates.size() >= 2);
|
||||
// TODO: add parsing of the certificate and make sure it is genuine.
|
||||
}
|
||||
|
||||
void SetImageData(vector<uint8_t>& image) {
|
||||
image.resize(256 * 1024 - 10);
|
||||
for (size_t n = 0; n < image.size(); n++) {
|
||||
image[n] = (uint8_t)n;
|
||||
}
|
||||
}
|
||||
|
||||
} // namespace android::hardware::identity::test_utils
|
||||
Reference in New Issue
Block a user