From 1e7339550471387879cc683af4144a275c844328 Mon Sep 17 00:00:00 2001 From: Max Bires Date: Tue, 21 Jul 2020 01:45:36 -0700 Subject: [PATCH] Fixing a test in DeviceUniqueAttestationTest The EC key check for generating a device unique attestation from a non-strongbox keymaster instance left out the TAG_DEVICE_UNIQUE_ATTESTATION_TAG, so the test should fail since the attestation should succeed. This commit adds the tag into the parameters passed into attestation. Fixes: 161327512 Test: m VtsHalKeymasterV4_1TargetTest Change-Id: I75a41a75b298c91ec41fa411f8a486ac347cf748 --- keymaster/4.1/vts/functional/DeviceUniqueAttestationTest.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/keymaster/4.1/vts/functional/DeviceUniqueAttestationTest.cpp b/keymaster/4.1/vts/functional/DeviceUniqueAttestationTest.cpp index 495de0f97d..f74d36c290 100644 --- a/keymaster/4.1/vts/functional/DeviceUniqueAttestationTest.cpp +++ b/keymaster/4.1/vts/functional/DeviceUniqueAttestationTest.cpp @@ -212,6 +212,7 @@ TEST_P(DeviceUniqueAttestationTest, NonStrongBoxOnly) { EXPECT_EQ(ErrorCode::UNIMPLEMENTED, convert(AttestKey( AuthorizationSetBuilder() + .Authorization(TAG_DEVICE_UNIQUE_ATTESTATION) .Authorization(TAG_ATTESTATION_CHALLENGE, HidlBuf("challenge")) .Authorization(TAG_ATTESTATION_APPLICATION_ID, HidlBuf("foo")), &cert_chain)));