From 5b9ba198ec0ad63c51c76719a34c1884692d3794 Mon Sep 17 00:00:00 2001 From: cmlin0118 Date: Wed, 28 Sep 2022 17:41:03 +0800 Subject: [PATCH] Fix tunerhal vts feId uninitialized on getFrontendIdByType Problem: FeId uninitialized on getFrontendIdByType Solution: Initializ feId Test: run vts -m VtsHalTvTunerV1_0TargetTest Bug: 248472007 Change-Id: I373c49cf0a105869743be7f2c0737b4f5b30ae26 --- tv/tuner/1.0/vts/functional/FrontendTests.cpp | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) mode change 100644 => 100755 tv/tuner/1.0/vts/functional/FrontendTests.cpp diff --git a/tv/tuner/1.0/vts/functional/FrontendTests.cpp b/tv/tuner/1.0/vts/functional/FrontendTests.cpp old mode 100644 new mode 100755 index 22a4bf97a3..237f4a44f5 --- a/tv/tuner/1.0/vts/functional/FrontendTests.cpp +++ b/tv/tuner/1.0/vts/functional/FrontendTests.cpp @@ -418,17 +418,14 @@ AssertionResult FrontendTests::closeFrontend() { void FrontendTests::getFrontendIdByType(FrontendType feType, uint32_t& feId) { ASSERT_TRUE(getFrontendIds()); - if (mFeIds.size() > 0) { - for (size_t i = 0; i < mFeIds.size(); i++) { - ASSERT_TRUE(getFrontendInfo(mFeIds[i])); - if (mFrontendInfo.type != feType) { + feId = INVALID_ID; + for (size_t i = 0; i < mFeIds.size(); i++) { + ASSERT_TRUE(getFrontendInfo(mFeIds[i])); + if (mFrontendInfo.type != feType) { continue; - } - feId = mFeIds[i]; - return; } - } else { - feId = INVALID_ID; + feId = mFeIds[i]; + return; } }