From 64f73a4c5fdc79a882c9047e69d9f64b89c013b9 Mon Sep 17 00:00:00 2001 From: Jason Macnak Date: Tue, 1 Oct 2024 15:40:33 -0700 Subject: [PATCH] Avoid leaking RenderEngine ... as this might allow an underlying `RenderEngineThreaded` thread to race against the process shutdown. Bug: b/361574971 Test: ATP cuttlefish_gfxstream_guest_angle_graphics_vts_tests Change-Id: Ief71d8931ec3560780a850d8bb8bc727bbff5c52 --- graphics/composer/aidl/vts/RenderEngineVts.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/graphics/composer/aidl/vts/RenderEngineVts.cpp b/graphics/composer/aidl/vts/RenderEngineVts.cpp index 4e7f7735ea..bc5eb6f77d 100644 --- a/graphics/composer/aidl/vts/RenderEngineVts.cpp +++ b/graphics/composer/aidl/vts/RenderEngineVts.cpp @@ -28,9 +28,7 @@ TestRenderEngine::TestRenderEngine(const RenderEngineCreationArgs& args) { mRenderEngine = ::android::renderengine::RenderEngine::create(args); } -TestRenderEngine::~TestRenderEngine() { - mRenderEngine.release(); -} +TestRenderEngine::~TestRenderEngine() {} void TestRenderEngine::setRenderLayers(std::vector> layers) { sort(layers.begin(), layers.end(),