Evolution-x/hardware_interfaces
1
0
Fork 0
mirror of https://github.com/Evolution-X/hardware_interfaces synced 2026-02-02 10:05:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Camera: Clean up TODOs that aren't going to be addressed." into oc-dev

Browse Source 
am: 0b3d86e05a

Change-Id: Ic0ca4e1eff6716466ef86bc6a660bc371da875d6
This commit is contained in:
Eino-Ville Talvala
2017-05-09 21:32:10 +00:00
committed by android-build-merger
parent 4f65adf509 0b3d86e05a
commit e643da4e19
3 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
camera/common/1.0/default/CameraMetadata.cpp
View File

@@ -508,8 +508,6 @@ status_t CameraMetadata::getTagFromName(const char *name,
} }
} }
// TODO: Make above get_camera_metadata_section_from_name ?
if (section == NULL) { if (section == NULL) {
return NAME_NOT_FOUND; return NAME_NOT_FOUND;
} else { } else {

3
camera/device/1.0/default/CameraDevice.cpp
View File

@@ -183,7 +183,6 @@ int CameraDevice::sDequeueBuffer(struct preview_stream_ops* w,
} }
int CameraDevice::sLockBuffer(struct preview_stream_ops*, buffer_handle_t*) { int CameraDevice::sLockBuffer(struct preview_stream_ops*, buffer_handle_t*) {
// TODO: make sure lock_buffer is indeed a no-op (and will always be)
return 0; return 0;
} }
@@ -585,8 +584,6 @@ Return<void> CameraDevice::getCameraInfo(getCameraInfo_cb _hidl_cb) {
cameraInfo.facing = (CameraFacing) info.facing; cameraInfo.facing = (CameraFacing) info.facing;
// Device 1.0 does not support external camera facing. // Device 1.0 does not support external camera facing.
// The closest approximation would be front camera. // The closest approximation would be front camera.
// TODO: figure out should we override here or let
// camera service handle it.
if (cameraInfo.facing == CameraFacing::EXTERNAL) { if (cameraInfo.facing == CameraFacing::EXTERNAL) {
cameraInfo.facing = CameraFacing::FRONT; cameraInfo.facing = CameraFacing::FRONT;
} }

4
camera/provider/2.4/default/CameraProvider.cpp
View File

@@ -461,10 +461,6 @@ Return<void> CameraProvider::getCameraDeviceInterface_V3_x(
return Void(); return Void();
} }
// TODO: we also need to keep a wp list of all generated devices to notify
// devices of device present status change, but then each device might
// need a sp<provider> to keep provider alive until all device closed?
// Problem: do we have external camera products to test this?
sp<android::hardware::camera::device::V3_2::implementation::CameraDevice> device = sp<android::hardware::camera::device::V3_2::implementation::CameraDevice> device =
new android::hardware::camera::device::V3_2::implementation::CameraDevice( new android::hardware::camera::device::V3_2::implementation::CameraDevice(
mModule, cameraId, mCameraDeviceNames); mModule, cameraId, mCameraDeviceNames);