From 5f5782276f1672a9dc0d6fe8081cb846a5c26b99 Mon Sep 17 00:00:00 2001 From: Chris Phoenix Date: Fri, 20 Jan 2017 13:46:36 -0800 Subject: [PATCH] bootctrl HAL uses "default" service name The getService() and registerAsService() methods of interface objects now have default parameters of "default" for the service name. HALs will not have to use any service name unless they want to register more than one service. Test: builds; verify HAL still works In support of b/33844934 Change-Id: I2c0aa199b5649f720710bfd564c077b6ce3acc9c Merged-In: I43f282ffedf18e4b0817b49fc4860ac39b127d04 --- boot/1.0/default/BootControl.cpp | 6 +++--- boot/1.0/default/service.cpp | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/boot/1.0/default/BootControl.cpp b/boot/1.0/default/BootControl.cpp index 5f4592facc..83ee1d27d1 100644 --- a/boot/1.0/default/BootControl.cpp +++ b/boot/1.0/default/BootControl.cpp @@ -78,14 +78,14 @@ Return BootControl::getSuffix(uint32_t slot, getSuffix_cb _hidl_cb) { } -IBootControl* HIDL_FETCH_IBootControl(const char* hal) { +IBootControl* HIDL_FETCH_IBootControl(const char* /* hal */) { int ret = 0; boot_control_module_t* module = NULL; hw_module_t **hwm = reinterpret_cast(&module); - ret = hw_get_module(hal, const_cast(hwm)); + ret = hw_get_module(BOOT_CONTROL_HARDWARE_MODULE_ID, const_cast(hwm)); if (ret) { - ALOGE("hw_get_module %s failed: %d", hal, ret); + ALOGE("hw_get_module %s failed: %d", BOOT_CONTROL_HARDWARE_MODULE_ID, ret); return nullptr; } module->init(module); diff --git a/boot/1.0/default/service.cpp b/boot/1.0/default/service.cpp index a594db6e1e..247e40e8e5 100644 --- a/boot/1.0/default/service.cpp +++ b/boot/1.0/default/service.cpp @@ -7,5 +7,5 @@ using ::android::hardware::boot::V1_0::IBootControl; using android::hardware::defaultPassthroughServiceImplementation; int main (int /* argc */, char * /* argv */ []) { - return defaultPassthroughServiceImplementation("bootctrl"); + return defaultPassthroughServiceImplementation(); }