From f5b45790b1c58a1430b3c6d2211781ed5022eff8 Mon Sep 17 00:00:00 2001 From: Zhuoyao Zhang Date: Thu, 8 Feb 2018 21:11:52 -0800 Subject: [PATCH] Convert usb hal test to use VtsHalHidlTargetTestEnvBase Bug: 64203181 Test: make vts vts-tradefed run vts -m VtsHalUsbV1_0Target vts-tradefed run vts -m VtsHalUsbV1_1Target Change-Id: I49d8af2b53e484cc68fcb72f75f8bfafc6d02f59 --- .../vts/functional/VtsHalUsbV1_0TargetTest.cpp | 18 +++++++++++++++++- .../vts/functional/VtsHalUsbV1_1TargetTest.cpp | 18 +++++++++++++++++- 2 files changed, 34 insertions(+), 2 deletions(-) diff --git a/usb/1.0/vts/functional/VtsHalUsbV1_0TargetTest.cpp b/usb/1.0/vts/functional/VtsHalUsbV1_0TargetTest.cpp index e01b974ab4..ee7ef1bebc 100644 --- a/usb/1.0/vts/functional/VtsHalUsbV1_0TargetTest.cpp +++ b/usb/1.0/vts/functional/VtsHalUsbV1_0TargetTest.cpp @@ -22,6 +22,7 @@ #include #include +#include #include #include #include @@ -48,6 +49,18 @@ using ::android::hardware::Return; using ::android::hardware::Void; using ::android::sp; +// Test environment for Usb HIDL HAL. +class UsbHidlEnvironment : public ::testing::VtsHalHidlTargetTestEnvBase { + public: + // get the test environment singleton + static UsbHidlEnvironment* Instance() { + static UsbHidlEnvironment* instance = new UsbHidlEnvironment; + return instance; + } + + virtual void registerTestServices() override { registerTestService(); } +}; + // The main test class for the USB hidl HAL class UsbHidlTest : public ::testing::VtsHalHidlTargetTestBase { public: @@ -96,7 +109,8 @@ class UsbHidlTest : public ::testing::VtsHalHidlTargetTestBase { virtual void SetUp() override { ALOGI("Setup"); - usb = ::testing::VtsHalHidlTargetTestBase::getService(); + usb = ::testing::VtsHalHidlTargetTestBase::getService( + UsbHidlEnvironment::Instance()->getServiceName()); ASSERT_NE(usb, nullptr); usb_cb_2 = new UsbCallback(*this, 2); @@ -343,7 +357,9 @@ TEST_F(UsbHidlTest, switchDataRole) { } int main(int argc, char** argv) { + ::testing::AddGlobalTestEnvironment(UsbHidlEnvironment::Instance()); ::testing::InitGoogleTest(&argc, argv); + UsbHidlEnvironment::Instance()->init(&argc, argv); int status = RUN_ALL_TESTS(); ALOGI("Test result = %d", status); return status; diff --git a/usb/1.1/vts/functional/VtsHalUsbV1_1TargetTest.cpp b/usb/1.1/vts/functional/VtsHalUsbV1_1TargetTest.cpp index 8a309930ad..c990b237fe 100644 --- a/usb/1.1/vts/functional/VtsHalUsbV1_1TargetTest.cpp +++ b/usb/1.1/vts/functional/VtsHalUsbV1_1TargetTest.cpp @@ -24,6 +24,7 @@ #include #include +#include #include #include #include @@ -113,12 +114,25 @@ class UsbCallback : public ::testing::VtsHalHidlTargetCallbackBase(); } +}; + // The main test class for the USB hidl HAL class UsbHidlTest : public ::testing::VtsHalHidlTargetTestBase { public: virtual void SetUp() override { ALOGI(__FUNCTION__); - usb = ::testing::VtsHalHidlTargetTestBase::getService(); + usb = ::testing::VtsHalHidlTargetTestBase::getService( + UsbHidlEnvironment::Instance()->getServiceName()); ASSERT_NE(usb, nullptr); usb_cb_2 = new UsbCallback(2); @@ -169,7 +183,9 @@ TEST_F(UsbHidlTest, queryPortStatus) { } int main(int argc, char** argv) { + ::testing::AddGlobalTestEnvironment(UsbHidlEnvironment::Instance()); ::testing::InitGoogleTest(&argc, argv); + UsbHidlEnvironment::Instance()->init(&argc, argv); int status = RUN_ALL_TESTS(); ALOGI("Test result = %d", status); return status;