Evolution-x/hardware_interfaces
1
0
Fork 0
mirror of https://github.com/Evolution-X/hardware_interfaces synced 2026-02-01 16:50:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

audio: Use hardcoded r_submix configuration with XML

Browse Source 
There are several reasons why parsing the canonical XML
configuration for the remote submix module will not work
correctly (see the commend in the code).

Since de facto all vendors use the canonical configuration
XML for the remote submix, substitute parsing it with
a correct hardcoded version.

Bug: 205884982
Test: atest VtsHalAudioCoreTargetTest
(cherry picked from commit ea604d50de)
Change-Id: Ib9d9da25d315ff4ce36c1870241fb61d95fcca88
This commit is contained in:
Mikhail Naganov
2023-10-02 17:08:12 -07:00
parent f7492518c7
commit fc35ca3d32
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
audio/aidl/default/AudioPolicyConfigXmlConverter.cpp
View File

@@ -184,9 +184,15 @@ void AudioPolicyConfigXmlConverter::init() {
// 'primary' in the XML schema used by HIDL is equivalent to 'default' module. // 'primary' in the XML schema used by HIDL is equivalent to 'default' module.
const std::string name = const std::string name =
xsdcModule.getName() != "primary" ? xsdcModule.getName() : "default"; xsdcModule.getName() != "primary" ? xsdcModule.getName() : "default";
mModuleConfigurations->emplace_back( if (name != "r_submix") {
name, VALUE_OR_FATAL(convertModuleConfigToAidl(xsdcModule))); mModuleConfigurations->emplace_back(
name, VALUE_OR_FATAL(convertModuleConfigToAidl(xsdcModule)));
} else {
// See the note on the 'getRSubmixConfiguration' function.
mModuleConfigurations->emplace_back(name, nullptr);
}
} }
} }
} }
} // namespace aidl::android::hardware::audio::core::internal } // namespace aidl::android::hardware::audio::core::internal