From fcf186bd5949f3bbb4274f8f7bf4ab9e4497d541 Mon Sep 17 00:00:00 2001 From: Kevin Rocard Date: Wed, 3 May 2017 11:16:05 -0700 Subject: [PATCH] Audio HAL VTS: Some methods are not optional Some mandatory methods were allowed to return NOT_SUPPORTED although their implementations is mandatory. Test: vts-tradefed run vts --module VtsHalAudioV2_0Target Test: call/play music/record/video... Bug: 36311550 Change-Id: Ibe4b3cf73257309975ed11269a38315051fa9064 Signed-off-by: Kevin Rocard --- audio/2.0/vts/functional/AudioPrimaryHidlHalTest.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/audio/2.0/vts/functional/AudioPrimaryHidlHalTest.cpp b/audio/2.0/vts/functional/AudioPrimaryHidlHalTest.cpp index 83a1db04c8..f2e7aacfcd 100644 --- a/audio/2.0/vts/functional/AudioPrimaryHidlHalTest.cpp +++ b/audio/2.0/vts/functional/AudioPrimaryHidlHalTest.cpp @@ -1076,7 +1076,7 @@ static void testPrepareForReading(IStreamIn* stream, uint32_t frameSize, ASSERT_OK(stream->prepareForReading( frameSize, framesCount, [&res](auto r, auto&, auto&, auto&, auto&) { res = r; })); - EXPECT_RESULT(invalidArgsOrNotSupported, res); + EXPECT_RESULT(Result::INVALID_ARGUMENTS, res); } TEST_P(InputStreamTest, PrepareForReadingWithZeroBuffer) { @@ -1144,7 +1144,7 @@ static void testPrepareForWriting(IStreamOut* stream, uint32_t frameSize, ASSERT_OK(stream->prepareForWriting( frameSize, framesCount, [&res](auto r, auto&, auto&, auto&, auto&) { res = r; })); - EXPECT_RESULT(invalidArgsOrNotSupported, res); + EXPECT_RESULT(Result::INVALID_ARGUMENTS, res); } TEST_P(OutputStreamTest, PrepareForWriteWithZeroBuffer) {