Commit Graph

3010 Commits

Author SHA1 Message Date
Treehugger Robot
4835bb4884 Merge "audio: Implement more accurate timing for the stub stream" into main am: 722afde62a am: e759910683
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3236976

Change-Id: Ifc5eb26584444f2f86883074c0a97e8a3e32776e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-21 20:33:19 +00:00
Treehugger Robot
e759910683 Merge "audio: Implement more accurate timing for the stub stream" into main am: 722afde62a
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3236976

Change-Id: I05a2926c27382419d07e0d220e7b055644243a24
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-21 20:25:19 +00:00
Mikhail Naganov
10fc96386e audio: Implement more accurate timing for the stub stream
Stub output stream is like a /dev/null audio device, however
for synchronous transfers it must block for the duration of
the audio chunk being transferred. Implement more accurate
accounting for the blocking time using the same approach as
employed by the remote submix stream implementation.

Bug: 356719263
Test: atest CtsNativeMediaAAudioTestCases
      on aosp_cf_x86_64_auto target
Change-Id: I137aed397246bcf2b5ef6789aa4d2d27ead64467
2024-08-21 11:34:05 -07:00
Treehugger Robot
9fe75fa4ee Merge "audio: Start Binder pool thread explicitly" into main am: 08c7c29c11 am: 14483ffaf0
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3228808

Change-Id: Ie5dd7f6aed666eb75592779290592ce441eda56d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-20 21:56:07 +00:00
Treehugger Robot
5a457d81e5 Merge "Add scale factor fields to HapticGenerator AIDL" into main 2024-08-20 17:28:17 +00:00
Treehugger Robot
14483ffaf0 Merge "audio: Start Binder pool thread explicitly" into main am: 08c7c29c11
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3228808

Change-Id: If5ba5e367257abd83244f2f6eb7c4f65cec96281
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-19 23:02:05 +00:00
Treehugger Robot
08c7c29c11 Merge "audio: Start Binder pool thread explicitly" into main 2024-08-19 22:46:05 +00:00
Mikhail Naganov
1840d35645 audio: Start Binder pool thread explicitly
It was noted that calling 'ABinderProcess_startThreadPool'
results in the audio HAL service having more Binder pool
threads than without it. This is preferred to having
just one thread via 'ABinderProcess_joinThreadPool'
as in the latter case clients may seemingly be blocked
instead of being served by a newly spawned thread from
the pool.

Bug: 357669241
Test: atest VtsHalAudioCoreTargetTest
Change-Id: Ia8ed52b3c5a95cea12d063a0e75ac908af9260f8
2024-08-19 14:48:28 -07:00
Mikhail Naganov
3f32ed237a Merge "audio: Fix stream cleanup sequence" into main am: a6c2d43c79
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3221028

Change-Id: I43ade00b1877f7d0ce16edcfaa3cd02cda7aacbe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-19 16:54:40 +00:00
Mikhail Naganov
a6c2d43c79 Merge "audio: Fix stream cleanup sequence" into main 2024-08-19 16:30:45 +00:00
Lais Andrade
90381a3df4 Add scale factor fields to HapticGenerator AIDL
Add support for haptic scale factors introduced to the HapticScale
parcelable defined at HapticGenerator.aidl. These fields are used by the
platform to scale the haptic channel data before it's sent to the vibrator
motor.

The fields have a default negative value which will be interpreted as
undefined by the scale function and ignored. The VibratorScale enum will
still be supported by the platform when the scale factors are undefined.

Fix: 356406324
Fix: 356406686
Flag: EXEMPT HAL interface change
Test: VtsHalHapticGeneratorTargetTest
Change-Id: I9da0f6f2573722089efadb78ff96fc265bdad164
2024-08-16 11:10:12 +01:00
Mikhail Naganov
0413d077f7 audio: Fix stream cleanup sequence
Move the cleanup of the stream worker thread from '~StreamCommonImpl'
up to concrete stream implementations. This is because when
the worker thread is stopping, it calls 'DriverInterface::shutdown'
method of the stream. At the time when '~StreamCommonImpl' is
running, the concrete stream class has already been destroyed.

The cleanup actually only happens in the case when the client
did not close the stream properly via 'IStreamCommon.close', or
when the stream creation has failed in the middle.

Bug: 355804294
Test: atest VtsHalAudioCoreTargetTest
Change-Id: Ie86f682af202976ed48d24338b2dffcfd20d9a76
2024-08-15 14:18:51 -07:00
Treehugger Robot
2fb82209e0 Merge "audio: Remove unnecessary std::move" into main am: 6883d48156
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3217976

Change-Id: Id3a73ba5fa3f4483b13036eb80af9afdcc6df714
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-13 21:04:34 +00:00
Yi Kong
e62f97fb5b audio: Remove unnecessary std::move
Moving a temporary object prevents copy elision, and could reduce
performance.

This fixes -Wpessimizing-move compiler warning.

Test: presubmit
Bug: 154270751
Change-Id: Idb1a4abf4da9eb6dbe1e9a8fd66461d60985c8e1
2024-08-14 01:52:25 +08:00
Shunkai Yao
1b9d201e40 Merge "Audio Effect : Add base implementation of commandImpl method" into main am: 5ef1f45f9e
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3195744

Change-Id: I29acd9951e6efedb24e7b4775b1fc99a25add45a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-06 18:15:57 +00:00
Shunkai Yao
07bbeec466 Merge "Adding yaoshunkai@ to hardware/interface/audio owner" into main am: c3eee4f253
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3208211

Change-Id: I0a831cb4acea783edce7b61bcd888c7b691088d7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-06 18:15:28 +00:00
Shunkai Yao
5ef1f45f9e Merge "Audio Effect : Add base implementation of commandImpl method" into main 2024-08-06 18:07:40 +00:00
Shunkai Yao
b43047f795 Adding yaoshunkai@ to hardware/interface/audio owner
Bug: 305866207
Test: N/A
Change-Id: I6fa8bd91b344dceab0c864735bb7d50a36264b0c
2024-08-06 17:26:07 +00:00
Shraddha Basantwani
0a981d36cf Audio Effect : Add base implementation of commandImpl method
Removing code repeatation and moving this method to base class.
Effect implementations can override enable, disable and reset methods.

Bug: 305866207
Test: atest --test-mapping hardware/interfaces/audio/aidl/vts:presubmit
Change-Id: Iceb7ad51185d6f6bd2b6d70a5a1dd51e7bd37276
2024-07-30 05:23:02 +00:00
Treehugger Robot
207cca8188 Merge "audio: Use 'join' instead of 'stop' for stream workers" into main am: 592430c84e
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3192950

Change-Id: I7fd7876b9f79f70c78737b865bc740ea87aee79b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-24 21:27:34 +00:00
Mikhail Naganov
657284d4ef audio: Use 'join' instead of 'stop' for stream workers
Calling 'stop' can cause the worker thread to terminate
before it handles the 'halReservedExit' command. This should
be avoided because a proper exit sequence may do cleanups.
Since all stream workers must handle the 'halReservedExit'
command, use of 'stop' should not be needed (if the thread
code gets stuck on a call to drivers, calling 'stop' will
not interrupt this), thus it is being replaced by 'join'.

Bug: 344482249
Test: atest CtsMediaAudioTestCases
Test: atest VtsHalAudioCoreTargetTest
Change-Id: If13f7239423657b80091239ff67e7fe350957e2e
Merged-In: If13f7239423657b80091239ff67e7fe350957e2e
2024-07-24 08:53:19 -07:00
Treehugger Robot
3bc169c78d Merge "audio: Prolong reading attempts from the remote submix pipe" into main am: 080d6b39ed
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3180240

Change-Id: I26764afcb8072af834778d303da0515c8eb0dc28
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-22 18:20:53 +00:00
Treehugger Robot
080d6b39ed Merge "audio: Prolong reading attempts from the remote submix pipe" into main 2024-07-22 18:08:07 +00:00
Mikhail Naganov
2be5078e25 audio: Prolong reading attempts from the remote submix pipe
In order to use the time interval for reading from the remote
submix pipe more efficiently, increase the deadline time
to the buffer duration minus a small amount. This should
minimize chances to have discontinuities in the remote submix
input.

Bug: 334363414
Test: atest --test-filter=".*RemoteSubmixTest#testRemoteSubmixRecordingContinuity" CtsMediaAudioTestCases
Change-Id: I02968d09afd8ecdad4d61e635393842d7280e55f
2024-07-22 16:04:23 +00:00
Mikhail Naganov
c778e25cae Merge "audio: Restrict reported channel masks to "mono" and "stereo"" into main am: 96c0123401
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3183105

Change-Id: I8a44d826b8e3ffa9ed71d7dcd4d0ce73866a88c3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-22 15:01:22 +00:00
Mikhail Naganov
96c0123401 Merge "audio: Restrict reported channel masks to "mono" and "stereo"" into main 2024-07-22 14:34:22 +00:00
François Gaffie
65bbd61254 Restore Default Device Effects support with AIDL AudioHAL am: ed095e62ab
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3106081

Change-Id: I8cdaa9246bf2db6dd7922c6f8f009ad70f32e040
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-19 01:02:47 +00:00
Mikhail Naganov
8c27e46bb9 audio: Restrict reported channel masks to "mono" and "stereo"
When translating supported channel counts into channel masks,
only use channel layouts for 1 and 2 channels: "mono" and
"stereo", while reporting all other counts via indexed
masks. This helps to support output to multichannel USB Audio
interfaces properly.

Bug: 329571487
Test: repro steps in the bug
Change-Id: Ibbbf71e7f04a6622cccaddeb3f4f140193d7f8fb
2024-07-18 17:03:53 -07:00
François Gaffie
ed095e62ab Restore Default Device Effects support with AIDL AudioHAL
Bug: 329395147
Test: atest CtsMediaAudioTestCases
Test: atest --test-mapping hardware/interfaces/audio/aidl/vts:presubmit

Change-Id: I0f4f680b4db4eaa69d6c6e9e7b897631ed94928b
Signed-off-by: François Gaffie <francois.gaffie@renault.com>
2024-07-18 23:16:43 +00:00
Treehugger Robot
ae6b1351a3 Merge "audio: Increase test timeout for VtsHalAudioTargetTest" into main am: 553e9ecec5
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3163640

Change-Id: I1a31c16c8e1f56e1c434f7d05c72dd94b468094c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-11 00:12:50 +00:00
Treehugger Robot
553e9ecec5 Merge "audio: Increase test timeout for VtsHalAudioTargetTest" into main 2024-07-10 23:47:17 +00:00
Mikhail Naganov
842106a030 audio: Increase test timeout for VtsHalAudioTargetTest
Some tests in `VtsHalAudioCoreTargetTest` may run for a long
time because they test all combinations of stream configurations.
As a result, the test was timing out on partners' devices.
The partner has confirmed that increasing the timeout to
30 minutes fixes the problem.

Bug: 350998390
Test: atest VtsHalAudioCoreTargetTest
Change-Id: I5eddd19f14d49e88b71134d040ebfb06a1f2d375
2024-07-10 13:02:55 -07:00
Treehugger Robot
676252e792 Merge "vts: skip data path reverb tests on offload effects" into main am: 92f359013c
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3161078

Change-Id: Ib60a8f02f455cf53af5dd592e3e7c93baf8dbaae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-10 16:09:10 +00:00
Jaideep Sharma
120aa0837f vts: skip data path reverb tests on offload effects
Skip the data path tests for offloading reverb, as offloading
effects don't publish fmqs and don't actually process the data.

Test: VtsHalEnvironmentalReverbTargetTest
Bug: 351751648

Change-Id: Ib5f37c4568d405c6c597eb27fe216e6e345a2eae
2024-07-08 14:55:53 +05:30
Treehugger Robot
35b81e0b47 Merge "audio: fix mmap output" into main am: f28b8e809c
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3116044

Change-Id: Icdcdba9afd9cad7753720c45d50ff786c39d9f98
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-27 01:30:56 +00:00
Treehugger Robot
f28b8e809c Merge "audio: fix mmap output" into main 2024-06-27 01:07:49 +00:00
Kuowei Li
53a8d4d62e audio: fix mmap output
1. add createMmapBuffer() for vendor to override and create mmap fd.
2. add refineMmapPosition() for vendor to override and update
latency in mmap case.
3. fix testcases position check in mmap case.

Bug: 274456992
Bug: 345591089
Test: atest VtsHalAudioCoreTargetTest
Change-Id: Ie63fdd47c0ddc563d84699dfdf6d4e9b72b5af43
2024-06-26 16:51:31 -07:00
Treehugger Robot
32cde75cee Merge "Migrate all related audio component to media.audio.common.types V4" into main am: 31b4c4f88d
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3041812

Change-Id: I73d089e62d88468b1b27a444f47e59a8f021cd6f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-26 20:42:19 +00:00
Treehugger Robot
31b4c4f88d Merge "Migrate all related audio component to media.audio.common.types V4" into main 2024-06-26 20:23:51 +00:00
François Gaffie
dab7ab0807 Migrate all related audio component to media.audio.common.types V4
-Change latest
-Unfreeze deps
-Update next compatibility matrix
-add opt sounddose v3 to fcm compat exclusions

Flag: EXEMPT HAL interface change
Bug: 307310023
Test: build & boot
Signed-off-by: François Gaffie <francois.gaffie@renault.com>
Merged-In: I3929603471d9543febca76ef6e2959063393194f
Change-Id: I3929603471d9543febca76ef6e2959063393194f
2024-06-26 18:13:56 +00:00
Treehugger Robot
8f116e72c5 Merge "EnvironmentalReverb: Add Basic Validation for Density Parameter" into main am: 062d1ecc16
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3145899

Change-Id: I446e5acd8d36e93bcd613722f31a2e0b0253a0f5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-26 17:32:58 +00:00
Sneha Patil
8ff6035fda EnvironmentalReverb: Add Basic Validation for Density Parameter
Bug: 305866207
Test: atest VtsHalEnvironmentalReverbTargetTest
Change-Id: I846dda585d788e808b8164d09ac088edbb05f160
2024-06-26 12:31:54 +00:00
Shunkai Yao
470826b2cc Merge "Update VTSHalAudioEffectTargetTest with frameSize" into main am: d0dc9486c9
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3134315

Change-Id: Ie571ebd2db7d05f3021da032e7779a52517875a8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-20 23:54:59 +00:00
Shunkai Yao
d0dc9486c9 Merge "Update VTSHalAudioEffectTargetTest with frameSize" into main 2024-06-20 23:35:28 +00:00
Treehugger Robot
8db9aa0e7e Merge "Modify the buffer size according to the framecounts" into main am: 4b3c7182bc
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3125515

Change-Id: I8530f4132f00132b0954653a42e959ebcec238e8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-20 22:01:25 +00:00
Treehugger Robot
3c6ada5c2c Merge "EnvironmentalReverbTest: Add test for diffusion parameter" into main am: 3310dd44c2
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/3125535

Change-Id: I667dc4d48613865bfe5109c054c890548d68327e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-20 22:01:10 +00:00
Treehugger Robot
4b3c7182bc Merge "Modify the buffer size according to the framecounts" into main 2024-06-20 21:40:41 +00:00
Treehugger Robot
3310dd44c2 Merge "EnvironmentalReverbTest: Add test for diffusion parameter" into main 2024-06-20 21:39:59 +00:00
Shunkai Yao
28aff3ddc0 Update VTSHalAudioEffectTargetTest with frameSize
- create buffer and check the fmq data with frameSize
- check effect state after open/close/command

Bug: 338040049
Test: atest --test-mapping hardware/interfaces/audio/aidl/vts
Change-Id: I45af2faec3cdcef5307fbdcf600a63d7da759261
2024-06-18 15:35:54 +00:00
Sneha Patil
807c9523e7 Modify the buffer size according to the framecounts
Bug: 305866207
Test: atest VtsHalDownmixTargetTest
      atest VtsHalLoudnessEnhancerTargetTest
Change-Id: I448875e7d79ac766a882cc3a958fb54ef76265ce
2024-06-12 17:18:18 +05:30