Commit Graph

714 Commits

Author SHA1 Message Date
Edward Liaw
69771123ba Merge "TEST_MAPPING: enable vts hal tests in kernel-presubmit" am: 24a8a39219
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2610093

Change-Id: Ifb1fe3792f481cfe57d3b4e9e0f7995ced887a7c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-01 21:11:34 +00:00
Edward Liaw
24696b3e32 TEST_MAPPING: enable vts hal tests in kernel-presubmit
Enable the following tests:
VtsHalBluetoothAudioTargetTest
VtsHalGraphicsComposerV2_4TargetTest

Bug: 284307085
Bug: 258819618
Test: atest :kernel-presubmit
Change-Id: I8667eaee120777a776339481f72558566e6c94b3
Signed-off-by: Edward Liaw <edliaw@google.com>
2023-06-01 16:08:42 +00:00
ramindani
ea9ab1c01e VTS add length is not zero check for executeSetClientTarget am: d00b8598bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/22434697

Change-Id: I711607fc79f2ea513daba2b5017b9b5222a13d08
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-05 00:49:57 +00:00
ramindani
d00b8598bb VTS add length is not zero check for executeSetClientTarget
Test: atest VtsHalGraphicsComposerV2_1TargetTest
BUG: 252764410
Change-Id: Icd15f6e7bfdd7b3e3d0d4b407195258d4171c560
(cherry picked from commit 708d49cfce)
Merged-In: Icd15f6e7bfdd7b3e3d0d4b407195258d4171c560
2023-04-03 20:55:08 +00:00
Sally Qi
2060a4e647 Remove length check to allow empty HDR10+ blobs to HWC
Bug: 212496177
Test: builds
Change-Id: Iad121cd6515e826c4b57976b14e7a5eb947b1728
2023-01-10 11:11:54 -08:00
Shubhangi Pawar
3e1907ae4a Merge "composer: vts: Init display dimension using active config" into android13-tests-dev 2023-01-09 18:59:00 +00:00
HyunKyoung
37b3413684 composer: vts: Init display dimension using active config
Dimension was initialized to the size of the last config that is in the config list.
VTS didn't change the dimension in the readback test and allocated buffer
for the readback with the dimension size.
However it was different with actual display size.
This change initializes display dimension to the actual display size.

Bug: 259155172
Change-Id: I64fec02f5386eb6ca1f41ab376be193231810b93
Merged-In: I64fec02f5386eb6ca1f41ab376be193231810b93
Signed-off-by: HyunKyoung <hk310.kim@samsung.com>
2023-01-09 04:56:06 +00:00
Treehugger Robot
12c9d664aa Merge "composer: vts: Init display dimension using active config" 2023-01-09 04:51:54 +00:00
HyunKyoung
4775bdce26 composer: vts: Init display dimension using active config
Dimension was initialized to the size of the last config that is in the config list.
VTS didn't change the dimension in the readback test and allocated buffer
for the readback with the dimension size.
However it was different with actual display size.
This change initializes display dimension to the actual display size.

Bug: 259155172
Change-Id: I64fec02f5386eb6ca1f41ab376be193231810b93
Signed-off-by: HyunKyoung <hk310.kim@samsung.com>
2023-01-05 10:17:34 +09:00
Marc Kassis
9c428fe3ed graphics.common V3 -> V4
Bug: 251177105
Test: m
Change-Id: I816b8e14a0741402090cdc4732c2a904e830ff4e
Merged-In: I1cb84ec85f98789d0737207a1661b39a25538c96
Merged-In: I2e1561f4ccb59a2a833af9a7afd07840ab2ebfa4
2022-12-07 10:53:12 +00:00
Midas Chien
1120a6f78c composer: vts: configure layer for DisplayDecoration
Some HW may not support crop function for decoration and current API
can't query this capability. Configure decoration layer to full screen
to avoid this limitation.

Bug: 225765061
Bug: 259505289
Test: VtsHalGraphicsComposer3_TargetTest
--gtest_filter=*DisplayDecoration*

Change-Id: If47154adf9d48f9c1b8390b4bee090d8bf40ff3b
(cherry picked from commit 7d55d4269d)
Merged-In: If47154adf9d48f9c1b8390b4bee090d8bf40ff3b
(cherry picked from commit 308f4ac906)
Merged-In: If47154adf9d48f9c1b8390b4bee090d8bf40ff3b
2022-11-22 18:06:39 +08:00
Steven Moreland
576e098973 composer3 frozen
magic -> explicit

Bug: 259465531
Test: build
Merged-In: Iefdfe812fc9309a0a758eedb3da9d3676e956f02
Change-Id: Icc336c6640adc064e755ab23c934d7d07cc6339f
2022-11-19 04:26:01 +00:00
Treehugger Robot
e42d6d0bb9 Merge "Remove unused include Util.h." 2022-11-02 18:57:18 +00:00
John Reck
15703c76af Update OWNERS
Remove all subfolder OWNERS in favor of single top-level
Update top-level OWNERS

Fixes: 230785548
Test: n/a

Change-Id: I9e4f4fa7938e31f0caf864836889f8ebb5ca5675
2022-11-02 12:36:41 -04:00
Rachel Lee
c85172b200 Remove unused include Util.h.
Util.h is not used in ComposerServiceWriter so it should not be
included. Otherwise when using ComposerServiceWriter, Util.h is not
found in the local directory.

Bug: 255623263
Test: m
Test: flashall to device

Change-Id: I4ce57b37d6a9a899d114e5ac64d443cfa51d826a
Merged-In: I4ce57b37d6a9a899d114e5ac64d443cfa51d826a
2022-11-01 17:17:11 +00:00
Sally Qi
a1c66a2993 Add cc_defaults wrapper for android.hardware.graphics.allocator ndk
package.

- to avoid manually rev up if needed.

Bug: 243429120
Test: builds
Change-Id: I25bfcc203cda61af308c37c3766fa9efe6c6784c
Merged-In: I25bfcc203cda61af308c37c3766fa9efe6c6784c
2022-10-20 18:27:12 -04:00
JihCheng Chiu
d0dbe4ef03 fix segmentation fault of GraphicsComposerAidlCommandTest
When we run the VTS of GraphicsComposerAidlCommandTest, we always meet
segmentation fault issue in some test items. VTS test items crashed
when it deleted the layer or display from resource manager and try to
go next loop.
The problem is the test item try to delete the layer iterator or
display iterator in the loop, so the iterator become an invalid
iterator. Then it try to use the invalid iterator for going to next
iterator. This behavior caused segmentation fault. We use different
way to fix deleting layer and deleting display.
Delete layer: Test item always delete all layer for each display, so
              we always delete layer via get the first iterator until
              the resource manager is empty.
Delete display: Test item only delete virtual display, so we move the
                physical display to a temporary map. After delete all
                virtual display, we swap the temporary map and
                original map.

Bug: 243781450
Test: 1. test GraphicsComposerAidlCommandTest.SetLayerColorTransform
         for deleting layer
      2. test GraphicsComposerAidlCommandTest.SetOutputBuffer
         for deleting disply

Change-Id: Id467df658e78ed29fdfc039cabc119f8bf62d69d
2022-08-26 02:11:23 +00:00
JihCheng Chiu
10750526a6 fix segmentation fault of GraphicsComposerAidlCommandTest
When we run the VTS of GraphicsComposerAidlCommandTest, we always meet
segmentation fault issue in some test items. VTS test items crashed
when it deleted the layer or display from resource manager and try to
go next loop.
The problem is the test item try to delete the layer iterator or
display iterator in the loop, so the iterator become an invalid
iterator. Then it try to use the invalid iterator for going to next
iterator. This behavior caused segmentation fault. We use different
way to fix deleting layer and deleting display.
Delete layer: Test item always delete all layer for each display, so
              we always delete layer via get the first iterator until
              the resource manager is empty.
Delete display: Test item only delete virtual display, so we move the
                physical display to a temporary map. After delete all
                virtual display, we swap the temporary map and
                original map.

Bug: 243781450
Test: 1. test GraphicsComposerAidlCommandTest.SetLayerColorTransform
         for deleting layer
      2. test GraphicsComposerAidlCommandTest.SetOutputBuffer
         for deleting disply

Change-Id: Id467df658e78ed29fdfc039cabc119f8bf62d69d
2022-08-25 12:21:47 +00:00
Xin Li
035ee7b933 DO NOT MERGE - Merge TP1A.220624.013
Merged-In: I25e8f827645db8e83c8c3142f5e76a912fdf7b22
Change-Id: Iabfc2e451749cbfe858e7bca6492565bf020d878
2022-07-11 21:47:42 -07:00
Midas Chien
8c75b834f4 composer: vts: configure layer for DisplayDecoration
Some HW may not support crop function for decoration and current API
can't query this capability. Configure decoration layer to full screen
to avoid this limitation.

Bug: 225765061
Test: VtsHalGraphicsComposer3_TargetTest
--gtest_filter=*DisplayDecoration*

Change-Id: If47154adf9d48f9c1b8390b4bee090d8bf40ff3b
(cherry picked from commit 7d55d4269d)
Merged-In: If47154adf9d48f9c1b8390b4bee090d8bf40ff3b
(cherry picked from commit 308f4ac906)
Merged-In: If47154adf9d48f9c1b8390b4bee090d8bf40ff3b
2022-06-29 00:03:45 +00:00
Ram Indani
3171473723 Merge "[VTS] Update allocator name for AIDL allocator." into tm-dev am: 82b65f9e42
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/18739824

Change-Id: I5650d21dbca7fd050c2d37d9d057566783c4c823
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 17:56:11 +00:00
ramindani
b2b747ffd4 [VTS] Update allocator name for AIDL allocator.
We used "default" value for the allocator in the test
and this value was used as is for the AIDL allocator.
This caused the test to fail because we were not able to acquire the
appropriate allocator as AIDL allocator instance is not named "default".
Update the test to use the correct instance name for AIDL allocator,
if available.

Test: atest VtsHalGraphicsComposerV2_1TargetTest
atest VtsHalGraphicsComposerV2_2TargetTest
atest VtsHalGraphicsComposerV2_3TargetTest
atest VtsHalGraphicsComposerV2_4TargetTest
atest VtsHalGraphicsComposer3_TargetTest
BUG: 234671596

test results after updates:
VTS 2.1 : http://ab/I84600010058657636
VTS 2.2 : http://ab/I51800010058498973
VTS 2.3 : http://ab/I87700010058914863
VTS 2.4 : http://ab/I88900010058592031
VTS 3.0 : http://ab/I96200010058838905

Change-Id: I04ae1a18d757cfd941d4929ad08f6bb2c8643f76
2022-06-07 23:33:12 +00:00
TreeHugger Robot
0971537d4e Merge "Tweak IMapper 4.0 VTS to run with AIDL IAllocator" into tm-dev am: 412f907bd3
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/18418692

Change-Id: Ic6798f01c122a09543e130027fb2ca0157cc95c2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-23 22:39:52 +00:00
Alec Mouri
38ccfd7a29 Tweak IMapper 4.0 VTS to run with AIDL IAllocator
When there is no HIDL IAllocator installed on the device, then these
tests must still run.

Bug: 231982605
Test: VtsHalGraphicsMapperV4_0TargetTest
Change-Id: If7503d398c03086df470971cc2c10029270525f9
2022-05-23 18:38:37 +00:00
Alix Espino
bc8a276ddd Merge changes I07c0f96d,I8734474f am: 5440b3663c am: a629baedb9
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2066561

Change-Id: I6f6cd5818d27f6e5bca6aa6d4ebeb9e1ac3b3cfc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-10 23:51:42 +00:00
Alix
ea13312de0 Deleted clang property in Android.bp files
Deleted deprecated clang property in Android.bp files using bpmodify.

Bug: 208980553
Test: treehugger
Change-Id: I07c0f96d07ad39dfedfc7ede275b7794c58bf2d2
2022-04-25 21:00:34 +00:00
Alix
3ce97170b1 autogenerated reformatting by bpfmt
Bug: 208980553
Test: treehugger
Change-Id: I8734474f4e75bcf808701bcbc747bc53c64907cc
2022-04-25 20:58:57 +00:00
ramindani
d575109c1e Check Exception Code for Service specific error
Before checking the service specific error
we need to check that getExceptionCode returns
EX_SERVICE_SPECIFIC error code. Added a method and
used that to do the two checks together for exceptionCode
and for the service specific error code, so that we don't
repeat two lines in all the tests that need them.

EXPECT_NO_FATAL_FAILURES print the correct line number of the test
or iteration of the test when used with helper functions, and
testing guidelines recommend it too here: go/gunitadvanced#propagating-fatal-failures

Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 205152739
Change-Id: I1d3c3aa9b34dcefb14be507ff61b73b6f08a5204
2022-04-25 20:44:04 +00:00
ramindani
c7585d9dc4 Set isOpaque For BlendMode::None
Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 216205298
BUG: 219576457

Change-Id: I479d8367e5abf8893b94ac64b7149a2f0e4cf75b
2022-04-22 16:25:39 +00:00
TreeHugger Robot
bce81ecc1e Merge "Move ComposerServiceWriter to composer3." into tm-dev 2022-04-19 21:32:21 +00:00
Alec Mouri
da91f729c1 Merge "Send brightness nits to composer" into tm-dev 2022-04-11 16:28:58 +00:00
Rachel Lee
d69c54a4e1 Move ComposerServiceWriter to composer3.
It can be reused more easily.

Bug: 216204575
Test: m; flashall
Change-Id: I76b8533ba16ad1d01fcd182bf72b65982dce7c20
2022-04-08 16:09:32 -07:00
TreeHugger Robot
486839fdef Merge "Update renderengine dependency to VTS" into tm-dev 2022-04-02 07:47:52 +00:00
Jiyong Park
703e97920e Freeze AIDL APIs for TM
Bug: 225941299
Test: m
Change-Id: Ie41cc0797710f813f92c65c387f247c7806d8394
2022-03-31 12:01:39 +09:00
Alec Mouri
55f76ca7af Update renderengine dependency to VTS
Bug: 218954037
Test: builds
Change-Id: I31f8a8764fa66a9aec4762354c425ba1442ef351
Merged-In: I31f8a8764fa66a9aec4762354c425ba1442ef351
2022-03-31 01:16:14 +00:00
Alec Mouri
03b6daac4a Send brightness nits to composer
Bug: 220396224
Test: builds, boots
Change-Id: I6866422130776ae25d791b3cfd0d1a754d2488b9
2022-03-31 01:12:34 +00:00
Alec Mouri
d48a5a9829 Clarify documentation for the dimming stage.
Plumbing this enum to RenderEngine requires knowledge of the intended
transfer function to apply the dimming stage in. Because this is
expected to be a contrained use-case and because apis are frozen,
document that RenderEngine is allowed to assume that the resulting
dimming matrix may be gamma corrected using a 2.2 power function.

Bug: 218954037
Test: builds
Change-Id: Ie7d357f8ce79295af017d80c62a2759dbccce5d2
2022-03-24 15:54:05 +00:00
ramindani
476314cc54 [HWC3.0] Add capability BOOT_DISPLAY_CONFIG
This Capabiliy::BOOT_DISPLAY_CONFIG will make
the display boot display config optional on the HWC3.0

BUG: 216113429
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: I3be3383922fdd91e0bbccebd3c73e458753b749f
2022-03-16 18:43:15 +00:00
Ady Abraham
261db780b4 composer: minor documentation fix
Bug: NA
Change-Id: I167f6a1224ceed48723f3af15a07d71fbde168cc
Test: NA
2022-03-08 23:22:37 +00:00
ramindani
a4e7636e62 Vts BlendMode tests skip for UNSUPPORTED ColorMode
BUG: 221887749
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: I6c0a35c64883333c70451c717f50cb84d85ce994
2022-03-02 04:14:18 +00:00
ramindani
44c952f69c Vts readback status check fixes
When we query for the getReadbackBufferAttributes
we can get EX_UNSUPPORTED error when not supported
and when this happens readback should not be supported.
EXPECT_TRUE for this failure case
was causing the test to fail when we received an EX_UNSUPPORTED
 for this.
See for documentation: https://source.corp.google.com/android/hardware/interfaces/graphics/composer/aidl/android/hardware/graphics/composer3/IComposerClient.aidl;rcl=e1f0950945f687ed374a45911e2d7786de724ca4;l=436

BUG: 221889462
Test: atest VtsHalGraphicsComposer3_TargetTest
Test link for the cf_x86_64_phone-userdebug  http://ab/I39800010022763398
All the other test failures are tracked else where.

Change-Id: Idf352761c5cc808540edfe2042c5ee4602b5e96b
2022-03-01 01:18:53 +00:00
Leon Scroggins III
68b9acc4fe DisplayDecoration VTS: remove expected changed composition types
If validateDisplay returns an error, changed composition types are not
propagated back to the caller. Remove the expectation that they will be.

Fixes: 221406264
Test: this
Change-Id: I3e07e40b0c12a2cf6eaa685435647aab93172bb0
2022-02-25 13:17:10 -05:00
TreeHugger Robot
a123e7688d Merge "Actually add DimmingStage to client target properties" into tm-dev 2022-02-24 22:51:17 +00:00
Leon Scroggins
5298f2c0e2 Merge "getDisplayDecorationSupport: expect IComposerClient::EX_UNSUPPORTED" into tm-dev 2022-02-24 21:27:42 +00:00
Alec Mouri
88e871b663 Actually add DimmingStage to client target properties
This change was missed while cherry-picking
I5675c16f0895f9958e3bee3ee4c85df8937ecdb7 due to merge conflicts.
So...actually merge this.

Bug: 218954037
Test: builds
Change-Id: Idb3a518f7dfd4f4fd598672ee709ccd5b1f3f06a
2022-02-24 12:18:37 -08:00
Jason Macnak
194a26f53d Merge "Minor spelling fix" into tm-dev 2022-02-24 18:16:50 +00:00
Leon Scroggins III
6455e797c6 getDisplayDecorationSupport: expect IComposerClient::EX_UNSUPPORTED
This is the error returned by cuttlefish, not EX_UNSUPPORTED_OPERATION.
This also matches other tests, e.g. SetDisplayBrightness.

Bug: 209458568
Test: this
Change-Id: I885767c4f1c42edfb11359b36852a863cbc8b0ed
2022-02-24 12:21:11 -05:00
TreeHugger Robot
b4fa6d0138 Merge "Update the test directory structure" into tm-dev 2022-02-24 04:53:07 +00:00
TreeHugger Robot
6f62c70f4f Merge "Add composer API changes in accordance to partner feedback" into tm-dev 2022-02-24 04:41:53 +00:00
Alec Mouri
ca18b9661b Merge "Remove concept of nits from the client target properties" into tm-dev 2022-02-24 01:48:53 +00:00