Commit Graph

25 Commits

Author SHA1 Message Date
Dan Shi
e5c9b5e722 Suppress gtest error for tests without any instance am: ba4d532fee am: 73122cd284
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1374050

Change-Id: Ie5e956d4613f5e947c36ba4f1048f0c3aa8944ba
2020-07-29 05:45:58 +00:00
Dan Shi
ba4d532fee Suppress gtest error for tests without any instance
Bug: 162052785
Test: m -j vts
Change-Id: I8c1a48e6fbd7c8161137902b5332911fa0d7b8b3
2020-07-28 15:12:32 -07:00
Treehugger Robot
042f31daf2 Merge "vibrator: vts: Validate Primitive Duration" am: 5ec6625bd6 am: 231b61abb5
Change-Id: I8db95eb838681b8a58853c534e420372b4f3de65
2020-04-21 02:03:39 +00:00
Harpreet \"Eli\" Sangha
b075a6a599 vibrator: vts: Validate Primitive Duration
Bug: 148496381
Test: Ran on Pixel 4
Signed-off-by: Harpreet \"Eli\" Sangha <eliptus@google.com>
Change-Id: Ie74f9458b881a51746539f61526fbe4898485b00
2020-04-17 13:22:41 +09:00
Harpreet \"Eli\" Sangha
7aec50208c vibrator: aidl: Apply Compose API Feedback
- Make Thud and Spin optional due to complexity.
- Make "scale" inclusive of zero, which represents minimum "feelable"
  intensity.
- Update VTS tests appropriately.
- Fix typo in VTS test names.

Bug: 151084263
Test: VTS on Flame, Walleye, and Cuttlefish
Signed-off-by: Harpreet \"Eli\" Sangha <eliptus@google.com>
Change-Id: Ib0d046be83ee79ab38e0b9c3fb87a41f23879f8b
2020-03-12 05:49:35 +09:00
Harpreet \"Eli\" Sangha
8922e56088 vibrator: aidl: Remove Output Checks on Error
VTS tests should treat output values as uninitialized when the returns
status is not OK.

Bug: 151174217
Test: Ran on Flame and Walleye
Signed-off-by: Harpreet \"Eli\" Sangha <eliptus@google.com>
Change-Id: I8a3fa77d35265b6dd371caace18ffb810e83a72f
2020-03-11 06:53:39 +09:00
Harpreet \"Eli\" Sangha
523e29603b vibrator: Compose API Related Improvements
- Allow querying duration of each primitive.
- Allow querying of supported primitives.
- Enforce all-of-nothing requirement for supported primitives via VTS.
- Enforce callback support requirement via VTS.

Bug: 139762802
Bug: 147852209
Test: atest VtsHalVibratorTargetTest
Change-Id: I9009e38d446ed9ea38b3a9d6eb8dd55e6be2792f
Merged-In: I9009e38d446ed9ea38b3a9d6eb8dd55e6be2792f
Signed-off-by: Harpreet \"Eli\" Sangha <eliptus@google.com>
2020-01-27 07:19:29 +00:00
Harpreet \"Eli\" Sangha
afa8636ce2 vibrator: Compose API Related Improvements
- Allow querying duration of each primitive.
- Allow querying of supported primitives.
- Enforce all-of-nothing requirement for supported primitives via VTS.
- Enforce callback support requirement via VTS.

Bug: 139762802
Bug: 147852209
Test: atest VtsHalVibratorTargetTest
Change-Id: I9009e38d446ed9ea38b3a9d6eb8dd55e6be2792f
Signed-off-by: Harpreet \"Eli\" Sangha <eliptus@google.com>
2020-01-21 17:06:35 +09:00
Steven Moreland
1c26978dd1 vibrator vts: use CompositePrimitives enum_range
Bug: 143992652
Test: TH (added TEST_MAPPING now)

Change-Id: If36ba0d2fa41db1b05bb1d65e6ee062b22c1b564
2020-01-10 19:27:14 +00:00
Jooyung Han
9eca80bd16 Merge "Revert submission" 2019-12-18 01:03:48 +00:00
Jooyung Han
716648deb4 Revert submission
Reason for revert: Trying to reland the changes with fix for build errors.

Change-Id: I64a9f6091a53ffb15433b8c5ff22b6a1b9cd01e8
2019-12-17 14:17:48 +00:00
Jooyung Han
91770e0381 Merge "Revert submission" 2019-12-17 08:47:50 +00:00
Jooyung Han
61d357ebce Revert submission
Reason for revert: b/146402634

Change-Id: Ibaf2854bc5cbe63f557dcf63be9e285ef6678bd3
2019-12-17 08:36:07 +00:00
Jooyung Han
74b4460f28 Merge "vibrator: Use enum_range<Enum>" 2019-12-17 06:10:59 +00:00
Jooyung Han
9bce98b45a vibrator: Use enum_range<Enum>
to avoid accidental omission of Effect/EffectStrength in test

Bug: 143992652
Test: VtsHalVibratorTargetTest
Change-Id: I0894a7bb426d134b052d43ef9a9f55ace8146a44
2019-12-13 15:39:19 +09:00
Harpreet \"Eli\" Sangha
63624099e3 vibrator: Support Always-On Effects
Bug: 138909021
Test: Verify always-on haptics are configured on boot and settings
      change.
Change-Id: I11ce5f2b974267c6e84b1843a750847492a7de15
Signed-off-by: Harpreet \"Eli\" Sangha <eliptus@google.com>
2019-12-12 11:09:06 +09:00
Harpreet \"Eli\" Sangha
e1723a49df vibrator: vts: Utilize New toString() Support
Use the new toString() support for AIDL enums for improved logging.

Test: atest VtsHalVibratorTargetTest
Change-Id: Ie9d98f6b9f367dec9e6f0b9b0ed18dab0a32c742
Signed-off-by: Harpreet \"Eli\" Sangha <eliptus@google.com>
2019-12-10 14:52:59 +09:00
Harpreet \"Eli\" Sangha
f4de5b065f vibrator: Add Composition APIs
Bug: 139762802
Test: Manual Invocation via 'idlcli'
Change-Id: Ibc938d08f186039681d523784b90f4172a52af51
Signed-off-by: Harpreet \"Eli\" Sangha <eliptus@google.com>
2019-11-21 16:12:13 +09:00
Steven Moreland
d13b7577e1 Merge "vibrator: fix VTS for effects" 2019-11-11 05:28:38 +00:00
Treehugger Robot
a7e5d5fd5b Merge "Fix build with new googletest" 2019-11-09 01:06:56 +00:00
Haibo Huang
83b4c1e3e1 Fix build with new googletest
The new googletest requires prefix to be non-empty.

Change-Id: I3ebd13861c4803b53dbeb4ac5f247984814bef45
2019-11-08 12:17:34 -08:00
Steven Moreland
f33538889f vibrator: fix VTS for effects
A few issues were causing effects tests to fail:
- invalid effects were not actually invalid
- test for invalid effects improved to consider invalid effects and
  strengths separately
- test sleeps for appropriate amount of time after requesting effect to
  be performed
- logging used to diagnose issues left in place for convenience

Bug: 141828236
Test: atest VtsHalVibratorTargetTest (on device which suffers from these
  issues that cf did not hit)

Change-Id: Id220d36c27d85f068dce6b8961f705eef8dc6a4f
2019-11-08 10:24:34 -08:00
Steven Moreland
c0b92d5388 vibrator: add CAP_EXTERNAL_AMPLITUDE_CONTROL
For HIDL, vibrator may change the value of supportsAmplitudeControl
based on context. Since the interface is being redone in AIDL, we're
avoiding this changing value and providing capabilities for amplitudes
we expect to be available in different states.

Bug: 141828236
Test: VtsHalVibratorTargetTest
Change-Id: Idf0b28ffe5b1175469d32e790b10b4232482dc2b
2019-11-07 03:00:25 +00:00
Steven Moreland
2932b22571 vibrator: add getSupportedEffects
It's a real gap in this interface, since we need to call perform to
understand if an effect is supported.

Bug: 141828236
Test: atest VtsHalVibratorTargetTest
Change-Id: Iffbd9c0acf5e4c368767c7718025a4aef8f44ce3
2019-11-06 16:34:37 +00:00
Steven Moreland
d91e449020 s/staidl/aidl/
staidl is a term I made up w/o precedence. aidl is clearer and more
consistent w/ practices elsewhere.

Bug: 141828236
Test: N/A
Change-Id: I3f044ddf470b63956f2aa496ae9fe9e5893f479a
2019-11-05 13:29:10 -08:00