Commit Graph

44 Commits

Author SHA1 Message Date
Nathan Kulczak
0d1929162f vibrator/vts: Update tests for short durations
Add minimum wait time for effect completion. Effects with short
durations were not completing in time with current wait time estimation.

Bug: 240946208
Test: Ran updated tests
Change-Id: I40f65244c3478fb2f0a3b84c3991313ad5e28cd9
Signed-off-by: Nathan Kulczak <nathankulczak@google.com>
2022-12-20 18:22:23 +00:00
donghongweng
af442b177f Explicit conversion
Test: m tests
Change-Id: Ie0c00a51dee1d97239b0ef6f29334d176ddec32a
2022-08-17 06:59:51 +00:00
Treehugger Robot
05eb1a279b Merge "vibrator: turn off vibrator after testing ChangeVibrationAmplitude" 2022-06-08 13:48:44 +00:00
Fenglin Wu
a464fb4db6 vibrator: turn off vibrator after testing ChangeVibrationAmplitude
Turn off vibrator explicitly after testing ChangeVibrationAmplitude.

Bug: 232319176
Test: VtsHalVibratorTargetTest
Change-Id: I482ea8266378636340c614eda832f4237d22e005
2022-05-24 09:02:58 +08:00
Lais Andrade
f1b4dd3f1d Check primitive duration is positive for supported primitives
Bug: 203629838
Fix: 231486866
Test: VtsHalVibratorTargetTest
Signed-off-by: chasewu <chasewu@google.com>
Change-Id: I2e534f4589c9f594884385a99051c06f518103f7
Merged-In: I2e534f4589c9f594884385a99051c06f518103f7
2022-05-16 16:14:46 +08:00
chasewu
22cb901d1a Correct the PWLE valid duration
Getting the maximum duration from HAL to avoid
different supported duration under different devices.

Fix: 231486866
Test: atest VtsHalVibratorTargetTest
Signed-off-by: chasewu <chasewu@google.com>
Change-Id: I02e96869d9a8e6d5143ae64e3a077bf90dcdb43e
Merged-In: I02e96869d9a8e6d5143ae64e3a077bf90dcdb43e
2022-05-11 15:58:46 +08:00
chasewu
70da3cc0a1 Fix the maximum frequency value calculation
Fix: 205250672
Test: VtsHalVibratorTargetTest
Signed-off-by: chasewu <chasewu@google.com>
Change-Id: I908ab93eaee17de2af163c0fe3c50feea567ee48
Merged-In: I908ab93eaee17de2af163c0fe3c50feea567ee48
2022-03-29 19:32:42 +08:00
Lais Andrade
22754c5fa7 Update ActivePwle description for amplitude values
Update description to clarify that the value 1 should map to the maximum
output acceleration supported by the device at any frequency, not exclusively
to the one at resonant frequency.

Also add information linking the  ActivePwle input parameters of composePwle
to the output values returned by getBandwidthAmplitudeMap, and update
the bandwidth description as well.

Change-Id: Id6e02c5d323aec57db7e7127e219a9705d0289a3
Fix: 199753151
Test: VtsHalVibratorTargetTest
2021-09-21 15:48:15 +00:00
Lais Andrade
7e643777e1 Update vibrator VTS to only validate support from required primitives
Bug: 193196353
Test: VtsHalVibratorTargetTest
Change-Id: I7ec2f0d82290f42259f8383db9ff00a126a2a7a4
2021-07-09 15:01:00 +01:00
Lais Andrade
149320003e Fix vibrator VTS failure on older HAL versions
Fixing tests missed by ag/14937086.

Fix: 186481596
Test: VtsHalVibratorTargetTest
Change-Id: Ib4b4885a99effb6c010573146f5b016872f7a202
2021-06-16 13:37:37 +01:00
Lais Andrade
4b54b1fc49 Fix vibrator VTS failure on older HAL versions
Fix tests to expect STATUS_UNKNOWN_TRANSACTION as well as
EX_UNSUPPORTED_OPERATION when the vibrator does not have a capability
required for the method being tested.

Older versions of the HAL will return that status code instead of
unsupported, as explained at:
https://source.android.com/devices/architecture/aidl/stable-aidl#versioning-interfaces

Fix: 190526054
Test: VtsHalVibratorTargetTest & VtsHalVibratorManagerTargetTest
Change-Id: I538843fbbdbf8353cd57f1c83392baeabdcbadd2
2021-06-11 12:29:11 +01:00
Vince Leung
7b8606eaa1 Increase timeout values for callback
We need to increase the timeout values for waiting for the callback to
be called.

Bug: 184719072
Test: atest to verify that the affected tests pass on P21
Change-Id: I5a5b2ae1fb99f98e3d94cd956685fabc45b89b30
2021-05-04 14:07:46 -07:00
Vince Leung
36f70d6ffc Relax timing parameters for vibrator VTS
First we set the start timestamp before we call the compose method.
We'll increase the allowed latency to if the system is under heavy load
then there can be more latencies.

Bug: 184578694
Test: atest
Change-Id: I5c06017ab0242d32b281ff3a0d0dddcb2106de5d
2021-04-14 04:33:20 +00:00
Vince Leung
823cf5f455 Add Chirp APIs for PWLE sequence creation
Add the necessary Chirp APIs required to allow for piecewise-linear
equation sequencing of haptic waveforms. These APIs will allow
developers to create a fully customizable sequence of haptics waveforms
for playback.

Bug: 162859057
Test: verify pwle sequences can be created and played using idlcli
command. Also verify using atest.

Change-Id: I7fec224b7090e482bbcd1c94a3799ec232cc547f
2021-03-24 06:20:21 +00:00
Vince Leung
4bae4f943d vibrator: aidl: Add get f0 and get Q APIs
Add APIs to get f0, resonant frequency, and Q factor.

Bug: 178826612
Test: m and verify using idlcli
Change-Id: I834693693a91871f988504d2d9448497ef10e7fc
2021-02-17 20:16:47 +00:00
Treehugger Robot
22646c2f6e Merge "vibrator: vts: correct the checking flag when testing on() interfaces" am: 321618f711 am: 47c899b6c8 am: 8bb44c34b2
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1505756

Change-Id: I96e20cea13eb8ec3314838aecef4afe6f831db72
2020-11-30 06:59:00 +00:00
Fenglin Wu
15b01dc53b vibrator: vts: correct the checking flag when testing on() interfaces
Check CAP_ON_CALLBACK flag when testing vibrator onWithCallback() and
OnCallbackNotSupported() functions.

Bug: 172485963
Change-Id: Ie5c926ec943f191d1e5309ac85e7c8e1540fb824
2020-11-23 10:37:45 +08:00
Lais Andrade
80b1861b20 Introduce IVibratorManager.aidl
Introduce interface for vibrator manager HAL.

A default implementation is made available to the existing
android.hardware.vibrator-service.example, which now provides a top
level devault IVibrator and a top level IVibratorManager with a
different vibrator in it.

VTS tests were also introduced for the new manager, and existing tests
for IVibrator where changed to run in all top level and managed HAL
instances found on a device.

Bug: 166586119
Test: atest VtsHalVibratorTargetTest
      atest VtsHalVibratorManagerTargetTest
Change-Id: Iec9175167e795bc03c4f3d873e2ac6682ed52512
2020-11-16 14:29:29 +00:00
Xin Li
36dcf1a404 Merge Android R (rvc-dev-plus-aosp-without-vendor@6692709)
Bug: 166295507
Merged-In: I6502829205ede2de914b27e6c2c5c42916af2b39
Change-Id: I7cb06511e43bd1fffd5f80a11dbdf5b1314cfe8e
2020-08-28 13:05:04 -07:00
Dan Shi
e5c9b5e722 Suppress gtest error for tests without any instance am: ba4d532fee am: 73122cd284
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1374050

Change-Id: Ie5e956d4613f5e947c36ba4f1048f0c3aa8944ba
2020-07-29 05:45:58 +00:00
Dan Shi
ba4d532fee Suppress gtest error for tests without any instance
Bug: 162052785
Test: m -j vts
Change-Id: I8c1a48e6fbd7c8161137902b5332911fa0d7b8b3
2020-07-28 15:12:32 -07:00
Treehugger Robot
042f31daf2 Merge "vibrator: vts: Validate Primitive Duration" am: 5ec6625bd6 am: 231b61abb5
Change-Id: I8db95eb838681b8a58853c534e420372b4f3de65
2020-04-21 02:03:39 +00:00
Harpreet \"Eli\" Sangha
b075a6a599 vibrator: vts: Validate Primitive Duration
Bug: 148496381
Test: Ran on Pixel 4
Signed-off-by: Harpreet \"Eli\" Sangha <eliptus@google.com>
Change-Id: Ie74f9458b881a51746539f61526fbe4898485b00
2020-04-17 13:22:41 +09:00
Harpreet \"Eli\" Sangha
7aec50208c vibrator: aidl: Apply Compose API Feedback
- Make Thud and Spin optional due to complexity.
- Make "scale" inclusive of zero, which represents minimum "feelable"
  intensity.
- Update VTS tests appropriately.
- Fix typo in VTS test names.

Bug: 151084263
Test: VTS on Flame, Walleye, and Cuttlefish
Signed-off-by: Harpreet \"Eli\" Sangha <eliptus@google.com>
Change-Id: Ib0d046be83ee79ab38e0b9c3fb87a41f23879f8b
2020-03-12 05:49:35 +09:00
Harpreet \"Eli\" Sangha
8922e56088 vibrator: aidl: Remove Output Checks on Error
VTS tests should treat output values as uninitialized when the returns
status is not OK.

Bug: 151174217
Test: Ran on Flame and Walleye
Signed-off-by: Harpreet \"Eli\" Sangha <eliptus@google.com>
Change-Id: I8a3fa77d35265b6dd371caace18ffb810e83a72f
2020-03-11 06:53:39 +09:00
Harpreet \"Eli\" Sangha
523e29603b vibrator: Compose API Related Improvements
- Allow querying duration of each primitive.
- Allow querying of supported primitives.
- Enforce all-of-nothing requirement for supported primitives via VTS.
- Enforce callback support requirement via VTS.

Bug: 139762802
Bug: 147852209
Test: atest VtsHalVibratorTargetTest
Change-Id: I9009e38d446ed9ea38b3a9d6eb8dd55e6be2792f
Merged-In: I9009e38d446ed9ea38b3a9d6eb8dd55e6be2792f
Signed-off-by: Harpreet \"Eli\" Sangha <eliptus@google.com>
2020-01-27 07:19:29 +00:00
Harpreet \"Eli\" Sangha
afa8636ce2 vibrator: Compose API Related Improvements
- Allow querying duration of each primitive.
- Allow querying of supported primitives.
- Enforce all-of-nothing requirement for supported primitives via VTS.
- Enforce callback support requirement via VTS.

Bug: 139762802
Bug: 147852209
Test: atest VtsHalVibratorTargetTest
Change-Id: I9009e38d446ed9ea38b3a9d6eb8dd55e6be2792f
Signed-off-by: Harpreet \"Eli\" Sangha <eliptus@google.com>
2020-01-21 17:06:35 +09:00
Steven Moreland
1c26978dd1 vibrator vts: use CompositePrimitives enum_range
Bug: 143992652
Test: TH (added TEST_MAPPING now)

Change-Id: If36ba0d2fa41db1b05bb1d65e6ee062b22c1b564
2020-01-10 19:27:14 +00:00
Jooyung Han
9eca80bd16 Merge "Revert submission" 2019-12-18 01:03:48 +00:00
Jooyung Han
716648deb4 Revert submission
Reason for revert: Trying to reland the changes with fix for build errors.

Change-Id: I64a9f6091a53ffb15433b8c5ff22b6a1b9cd01e8
2019-12-17 14:17:48 +00:00
Jooyung Han
91770e0381 Merge "Revert submission" 2019-12-17 08:47:50 +00:00
Jooyung Han
61d357ebce Revert submission
Reason for revert: b/146402634

Change-Id: Ibaf2854bc5cbe63f557dcf63be9e285ef6678bd3
2019-12-17 08:36:07 +00:00
Jooyung Han
74b4460f28 Merge "vibrator: Use enum_range<Enum>" 2019-12-17 06:10:59 +00:00
Jooyung Han
9bce98b45a vibrator: Use enum_range<Enum>
to avoid accidental omission of Effect/EffectStrength in test

Bug: 143992652
Test: VtsHalVibratorTargetTest
Change-Id: I0894a7bb426d134b052d43ef9a9f55ace8146a44
2019-12-13 15:39:19 +09:00
Harpreet \"Eli\" Sangha
63624099e3 vibrator: Support Always-On Effects
Bug: 138909021
Test: Verify always-on haptics are configured on boot and settings
      change.
Change-Id: I11ce5f2b974267c6e84b1843a750847492a7de15
Signed-off-by: Harpreet \"Eli\" Sangha <eliptus@google.com>
2019-12-12 11:09:06 +09:00
Harpreet \"Eli\" Sangha
e1723a49df vibrator: vts: Utilize New toString() Support
Use the new toString() support for AIDL enums for improved logging.

Test: atest VtsHalVibratorTargetTest
Change-Id: Ie9d98f6b9f367dec9e6f0b9b0ed18dab0a32c742
Signed-off-by: Harpreet \"Eli\" Sangha <eliptus@google.com>
2019-12-10 14:52:59 +09:00
Harpreet \"Eli\" Sangha
f4de5b065f vibrator: Add Composition APIs
Bug: 139762802
Test: Manual Invocation via 'idlcli'
Change-Id: Ibc938d08f186039681d523784b90f4172a52af51
Signed-off-by: Harpreet \"Eli\" Sangha <eliptus@google.com>
2019-11-21 16:12:13 +09:00
Steven Moreland
d13b7577e1 Merge "vibrator: fix VTS for effects" 2019-11-11 05:28:38 +00:00
Treehugger Robot
a7e5d5fd5b Merge "Fix build with new googletest" 2019-11-09 01:06:56 +00:00
Haibo Huang
83b4c1e3e1 Fix build with new googletest
The new googletest requires prefix to be non-empty.

Change-Id: I3ebd13861c4803b53dbeb4ac5f247984814bef45
2019-11-08 12:17:34 -08:00
Steven Moreland
f33538889f vibrator: fix VTS for effects
A few issues were causing effects tests to fail:
- invalid effects were not actually invalid
- test for invalid effects improved to consider invalid effects and
  strengths separately
- test sleeps for appropriate amount of time after requesting effect to
  be performed
- logging used to diagnose issues left in place for convenience

Bug: 141828236
Test: atest VtsHalVibratorTargetTest (on device which suffers from these
  issues that cf did not hit)

Change-Id: Id220d36c27d85f068dce6b8961f705eef8dc6a4f
2019-11-08 10:24:34 -08:00
Steven Moreland
c0b92d5388 vibrator: add CAP_EXTERNAL_AMPLITUDE_CONTROL
For HIDL, vibrator may change the value of supportsAmplitudeControl
based on context. Since the interface is being redone in AIDL, we're
avoiding this changing value and providing capabilities for amplitudes
we expect to be available in different states.

Bug: 141828236
Test: VtsHalVibratorTargetTest
Change-Id: Idf0b28ffe5b1175469d32e790b10b4232482dc2b
2019-11-07 03:00:25 +00:00
Steven Moreland
2932b22571 vibrator: add getSupportedEffects
It's a real gap in this interface, since we need to call perform to
understand if an effect is supported.

Bug: 141828236
Test: atest VtsHalVibratorTargetTest
Change-Id: Iffbd9c0acf5e4c368767c7718025a4aef8f44ce3
2019-11-06 16:34:37 +00:00
Steven Moreland
d91e449020 s/staidl/aidl/
staidl is a term I made up w/o precedence. aidl is clearer and more
consistent w/ practices elsewhere.

Bug: 141828236
Test: N/A
Change-Id: I3f044ddf470b63956f2aa496ae9fe9e5893f479a
2019-11-05 13:29:10 -08:00