The default External Camera HAL accidentally used `sizeof` on a `char *`
to get the length of the string. This "worked" because the string in
question "/dev/" has length of 5, while on a 32-bit system `char *`
has a size of 4. This difference of 1 was handled a few lines later.
However on 64-bit system `sizeof(char *)` returns 8 which breaks the
logic later in code.
As `sizeof` was being used as a proxy for strlen, this CL converts the
uses C++'s std::char_traits::length to determine the string lengths
at compile time.
Bug: 265168485
Test: Manually tested that the calculated length is correct after the
fix.
Change-Id: I92481a2bcb74fdbbb483ef552168debf07b2d68a
We directly use erase(), and its return value, so we only need
to look up 'deviceName' once.
Test: TreeHugger
Bug: 191248460
Change-Id: I7c229e7d1de5f76071f55f965eab447b6c868bcc
Add default implementation for external camera
provider with lazy HAL support v2.7.
Test configuration for devices:
PRODUCT_PACKAGES += android.hardware.camera.provider@2.7-impl
PRODUCT_PACKAGES += android.hardware.camera.provider@2.7-external-service-lazy
PRODUCT_PROPERTY_OVERRIDES += ro.camera.enableLazyHal=true
Test: atest CtsCameraTestCases
atest VtsHalCameraProviderV2_4TargetTest
Bug: 191248460
Change-Id: I57c8130d7c331028eff35dc68e360fdd8d8c32e2
