3 Commits

Author	SHA1	Message	Date
Chong Zhang	4aabc95234	cas: fix UAF in descrambler ... Change the plugin holder in both CasImpl and DescramblerImpl to shared_ptr, and use atomic store/load for read/write. bug: 73172817 Test:CTS MediaCasTest, VTS VtsHalCasV1_0Target, poc in bug Change-Id: I3f1472d3b9d8d3dc74168c07325c5c319a96807d	2018-03-23 18:50:38 -07:00
Chong Zhang	ea3f07b614	cas: manually clear strong ref before callback ... Hidl doesn't guarantee the server side method goes out of scope before the client side returns. Even when client calls on the same thread, the next method could overlap the previous call. Next call can come in as soon as the hidl callback is called. In case of openSession and release, there is a rare chance that release call comes in before previous openSession is returned. If this happens, the cas plugin object destructor is delayed to the point when openSession goes out of scope (thus let go its strong ref to the plugin). This violates our contract that the plugin object and all associated sessions are released by the time release() returns. Manually clean up the strong ref before calling hidl callback in openSession would fix this. bug: 70544685 Change-Id: Id89a00591a354c8a46def3cc691dd8e28b4c971b	2017-12-12 22:09:20 -08:00
Chong Zhang	a4f6751e49	cas: add CAS hal ... Add CAS hal definitions and default service implementation. bug: 22804304 Change-Id: I0a89608fe75c5f3c5e6888f9b771305742760707	2017-06-23 16:24:17 -07:00