Evolution-x/hardware_interfaces
1
0
Fork 0
mirror of https://github.com/Evolution-X/hardware_interfaces synced 2026-02-02 09:36:03 +00:00
Code Issues Packages Projects Releases Wiki Activity
67,323 Commits 4 Branches 0 Tags
a2fa54aa75e312845a3e19de30dbc7e789914708
Commit Graph

7 Commits

Author SHA1 Message Date
Eric Biggers
649c20ef27 Remove the used_slots assertion from VtsHalWeaverTargetTest 
Since fixing the boot-time issues in OMAPI based Weaver HALs has proven
to be more difficult than expected, for now the
config_disableWeaverOnUnsecuredUsers option is being added as a
workaround.  It weakens the security benefit of Weaver, but it's better
than not being able to enable Weaver at all.  As a result of supporting
this option, the !used_slots.empty() assertion has to be removed.

Bug: 368151356
Test: mmm hardware/interfaces/weaver
Change-Id: I2b06e477ee276296e2f8216c2ee99f4c526005a5
 2024-09-30 23:49:42 +00:00
Eric Biggers
b267fcced5 Update comment about Weaver slot assertion 
Explain more clearly why this assertion is important.

Test: comment-only change
Bug: 356562932
Change-Id: I0ef2862fb6fbb062520c98935d347f1445a7dfae
 2024-08-28 00:11:28 +00:00
Eric Biggers
e1d4bc5591 Assert that at least one Weaver slot is used 
Uncomment an assertion that had been temporarily commented out because
AOSP was out-of-date.  This addresses a TODO in the code.

Test: atest VtsHalWeaverTargetTest
Change-Id: Ie572bb5fa05fcae3845aa46478cde0ac49206137
 2024-01-26 02:59:34 +00:00
Eric Biggers
47b145a0d8 Allow uninstantiated WeaverTest 
Add back GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST, which I had
accidentally removed while merging the AIDL and HIDL tests.  I think
this is still needed on devices that don't support Weaver at all.

Bug: 291284381
Test: atest VtsHalWeaverTargetTest
Change-Id: Iac1b4476620e51c645e3ad57444ee386cb879029
 2023-07-24 17:28:37 +00:00
Eric Biggers
31380e7bc9 Don't overwrite in-use Weaver slots during VTS 
VtsHalWeaverTargetTest always overwrote the first and last Weaver slots.
Before Android 14, apparently this didn't cause problems because Android
didn't use Weaver for users that never had an LSKF set.  However, now
users get a Weaver slot right away.  That typically means that the first
Weaver slot will be used by user 0.

Fix the test to read /metadata/password_slots/slot_map to determine
which slots are in use by the system, and only write to unused slots.

Bug: 291284381
Test: 'atest -v VtsHalWeaverTargetTest'.  Checked for INFO messages
      showing that slots 1 and 63 were used by the test.  Then rebooted
      and verified that the device can still be unlocked.
Change-Id: Id2cce4240d68999471e7d1e8fc7a8449587eed97
 2023-07-19 15:59:10 +00:00
Eric Biggers
961a138e47 Simplify Weaver VTS test 
- Get the config in SetUp() so that it's easily available to test cases.
- Rename "weaver" class member to "weaver_" to match coding style.
- Eliminate unnecessary variables when checking WeaverReadResponse.
- Fix a typo.

Bug: 291284381
Test: 'atest VtsHalWeaverTargetTest' on bramble
Change-Id: Ia6dca996103057bfdc9002bc9ab2c039e2333ed9
 2023-07-19 04:09:01 +00:00
Eric Biggers
f0d6907d20 Move VtsHalWeaverTargetTest to common directory 
Since VtsHalWeaverTargetTest now handles both AIDL and HIDL, move it
from weaver/aidl/vts/ to weaver/vts/.

Bug: 291284381
Test: 'atest VtsHalWeaverTargetTest' on bramble
Change-Id: Icfa0ff3b22b036110df327674fda44820057aabd
 2023-07-19 04:09:01 +00:00