Commit Graph

797 Commits

Author SHA1 Message Date
Marin Shalamanov
ac6cc1f97e Clean ComposerClient cache on hotplug
On subsequent hotplug connected event for a display
SurfaceFlinger destroys the previous framebuffers and
recreates them. When the new buffers are created
ComposerClient still holds a handle to the old buffers and
they are not destroyed. This way the new framebuffers
may get allocated on non continuous memory causing garbled
screens for the user.

Bug: 160112047
Bug: 169255692
Test: 1. limit cma ion memory to 32 MB
      2. flash device
      3. plug hdmi out and in
      4. verify that the display image is not garbled
Change-Id: Idf7cdf7a070ffc83ecec34ac24c8a7d696f68aa6
2020-10-27 13:37:40 +01:00
Steven Moreland
e04821595c Update VNDK version for common graphics HALs.
We are adding things to them, and in order for core libraries like libui
to use them, the newer versions need to be in the VNDK.

Bug: 170435409
Test: build
Change-Id: I4094240656f357b5ae52194befd0e10627b9fe23
2020-10-19 18:07:57 +00:00
TreeHugger Robot
e601b1ca37 Merge "composer: hold a sp<IComposer> from the service itself" 2020-10-01 22:56:15 +00:00
Ady Abraham
43e42ff6ec composer: hold a sp<IComposer> from the service itself
IComposerClient assumes that IComposer will outlive its life cycle
and holds a simple pointer to HwcHal. This change is taking the same
approach of newer composer versions (2.2, 2.3, and 2.4) to make sure
that IComposer would outlive IComposerClient.

Test: coral booting with this change
Fixes: 155769496
Change-Id: I3962ede51ce823368c62c4e4e5fb30f7a5680bdf
2020-10-01 20:12:38 +00:00
Marin Shalamanov
5127a97bd8 Update the comment for ReplacedHandle
Test: n/a
Bug: n/a
Change-Id: I388af766fb1b5e78aabfc72c70883e71d05ce18c
2020-09-29 16:04:49 +02:00
John Reck
066a7d944c Add missing skia_deps
Test: make
Change-Id: I51e664120fd9fb6f574b5676eedca63df2c13951
2020-09-14 13:26:30 -07:00
Dan Shi
6b0fd062bb Suppress gtest error for tests without any instance
Bug: 162052785
Test: m -j vts
Change-Id: I627d6790aa08aa9c6e3c5b8bdc533213ee08de21
2020-09-08 10:42:38 -07:00
Chris Forbes
48d97f3921 Mark GraphicsMapperHidlTest as allowing not being instantiated
Only the variant(s) actually implemented by the device will be
instantiated.

This is consistent with tests for other versioned or optional HALs.

Bug: b/167222309
Test: atest VtsHalGraphicsMapperV2_0TargetTest:GoogleTestVerification#UninstantiatedParameterizedTestSuite<GraphicsMapperHidlTest> -- --abi arm64-v8a
Change-Id: I4f1bfbad47bdbf75578ec48a3a56fb5351e7729a
2020-08-31 17:14:39 -07:00
Dan Shi
ff985a85a8 Suppress gtest error for tests without any instance
Bug: 162052785
Test: m -j vts
Change-Id: I58bc808a82b2128bb8774f762f9b9fcecd2614fb
2020-07-29 09:46:36 -07:00
Ady Abraham
2fb43f0108 composer: 2.4: fix VTS usage of desired time am: 30d2573834 am: b672893691 am: 30261db626 am: 81650b5cb7
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/12171999

Change-Id: If06626d941d1f7588fbf51edb32f0e42e780073d
2020-07-16 22:20:10 +00:00
Ady Abraham
30261db626 composer: 2.4: fix VTS usage of desired time am: 30d2573834 am: b672893691
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/12171999

Change-Id: Ibbdc435742ff5d89553ae178c3924306400e8ca8
2020-07-16 21:26:54 +00:00
Ady Abraham
30d2573834 composer: 2.4: fix VTS usage of desired time
Test_setActiveConfigWithConstraints is setting the desired time
for a config change to be before the test starts.
This causes the test to use the same value for all configurations,
which becomes stale the more configurations the device supports.
This fix is setting the desired time before calling
to setActiveConfigWithConstraints.

Bug: 161023185
Test: adb shell data/nativetest64/VtsHalGraphicsComposerV2_4TargetTest/VtsHalGraphicsComposerV2_4TargetTest
Change-Id: I236e5c9c16b4ba730677cd4c980a7071ba25840e
2020-07-16 20:00:44 +00:00
TreeHugger Robot
fc856a4aab Merge "composer: 2.4: VTS using old value for parameter" into rvc-dev am: 32e3cd9a02 am: 247528e180 am: 034e764769 am: 50629e7afd
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/12143287

Change-Id: If87fc83a81599b10292d2c970f48926e5fb9171d
2020-07-14 19:53:58 +00:00
TreeHugger Robot
50629e7afd Merge "composer: 2.4: VTS using old value for parameter" into rvc-dev am: 32e3cd9a02 am: 247528e180 am: 034e764769
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/12143287

Change-Id: I84b6877662e3a8efb50a54fd404291c6ad88224c
2020-07-14 19:41:25 +00:00
TreeHugger Robot
e76932a612 Merge "composer: 2.4: VTS using old value for parameter" into rvc-dev am: 32e3cd9a02 am: 247528e180
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/12143287

Change-Id: Ided256d0a30fbbf07b1be2be23d897e4b0ab2c99
2020-07-14 19:28:29 +00:00
Ady Abraham
0a19601eae composer: 2.4: VTS using old value for parameter
Fix a test that is using the incorrect parameter.

Bug: 161023185
Test: adb shell data/nativetest64/VtsHalGraphicsComposerV2_4TargetTest/VtsHalGraphicsComposerV2_4TargetTest
Change-Id: I8574abed50c23657f5d96e9d396709cb9b92e1fd
2020-07-13 23:30:05 +00:00
Jooyung Han
d18cba85fe update hidl .bp
HIDL libs are not necessarily part of VNDK now. Because some are
used by VNDK libs, they are still VNDK. But rest are now just
vendor-available.

.hidl_for_test files are also removed because they are used to exclude
test-purpose hidl libs from VNDK libs.

Instead, .hidl_for_system_ext files are added to tests/lazy to
distinguish them from others which are installed /system.

Bug: 143933769
Test: update-makefiles.sh && m com.android.vndk.current
Merged-In: Ia81312dda340b6b5cbdd7a3c21e1d323bda39a4a
Change-Id: Ia81312dda340b6b5cbdd7a3c21e1d323bda39a4a
(cherry picked from commit b0907a6bb8)
2020-07-02 12:26:37 +09:00
Jooyung Han
b0907a6bb8 update hidl .bp
HIDL libs are not necessarily part of VNDK now. Because some are
used by VNDK libs, they are still VNDK. But rest are now just
vendor-available.

.hidl_for_test files are also removed because they are used to exclude
test-purpose hidl libs from VNDK libs.

Instead, .hidl_for_system_ext files are added to tests/lazy to
distinguish them from others which are installed /system.

Bug: 143933769
Test: update-makefiles.sh && m com.android.vndk.current
Change-Id: Ia81312dda340b6b5cbdd7a3c21e1d323bda39a4a
2020-07-02 09:18:17 +09:00
Naseer Ahmed
e44f9340f0 Do not link mapper libraries statically am: fbcb5a89c9 am: 5f9995dc9a am: 395017b957 am: 49d3f81210
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11970027

Change-Id: Idfd3dddbd7b3c55b44a39c29b895e0341e047002
2020-06-24 08:54:52 +00:00
Naseer Ahmed
5f9995dc9a Do not link mapper libraries statically am: fbcb5a89c9
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11970027

Change-Id: I600ebe8bd0291a81f03efc33a7642bb2b0b7c9c4
2020-06-24 08:16:34 +00:00
Naseer Ahmed
fbcb5a89c9 Do not link mapper libraries statically
Linking them statically prevents the mapper SP HAL from being
extended

Bug: 158465474
Test: local build vts tools.
      Passed on VtsHalGraphicsComposerV2_XTargetTest.
Change-Id: I916b1c042b1e81e53f7398cd4a1a2231469ea91f
2020-06-24 07:10:58 +00:00
TreeHugger Robot
c152a361c2 Merge "Add test for subsample metadata for YUV420 format" into rvc-dev am: e83c8b22e3 am: 1705471cc1 am: 1f6a1aeab0 am: ccc4c67587
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11736601

Change-Id: I6aa0352673ce7f52cb2a650843ae2541f629d38c
2020-06-23 16:46:44 +00:00
TreeHugger Robot
1705471cc1 Merge "Add test for subsample metadata for YUV420 format" into rvc-dev am: e83c8b22e3
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11736601

Change-Id: Ibb503d88b4656056a63195c40b4dcad0422a9016
2020-06-23 16:00:47 +00:00
TreeHugger Robot
e83c8b22e3 Merge "Add test for subsample metadata for YUV420 format" into rvc-dev 2020-06-23 15:44:49 +00:00
layog
e886f80942 Add test for subsample metadata for YUV420 format
Bug: 153704651
Test: atest VtsHalGraphicsMapperV4_0TargetTest
Change-Id: Ie7a521b19b2eb1c459327fe699253aaa50ae8257
2020-06-20 11:54:25 +08:00
TreeHugger Robot
751e44ead5 Merge "gralloc4-vts: Correct the ownership of fence fd" into rvc-dev am: 86aa285936 am: c117f9254a am: 429d1f53b2 am: f51af509ab
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11880423

Change-Id: I6eae9857ef504941be7782b2788bef26653ef28f
2020-06-19 02:04:27 +00:00
TreeHugger Robot
429d1f53b2 Merge "gralloc4-vts: Correct the ownership of fence fd" into rvc-dev am: 86aa285936 am: c117f9254a
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11880423

Change-Id: I2959701130721c9ad0f0c239cdf45d57ba0f6ddb
2020-06-19 01:34:22 +00:00
TreeHugger Robot
dc2a322213 Merge "gralloc4-vts: Correct the ownership of fence fd" into rvc-dev am: 86aa285936
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11880423

Change-Id: I4d0b921bd4a3cddb0b306d02aed5f0f1830d4831
2020-06-19 01:16:42 +00:00
Yichi Chen
448369c954 gralloc4-vts: Correct the ownership of fence fd
Gralloc::lock takes the ownership of acquireFence and closes the fence
by itself. The patch changes the behavior of fence to transfer the
ownership by unique_fd::release.

Bug: 157534008
Test: VtsHalGraphicsMapperV4_0TargetTest
Change-Id: Ie4ee9cd9c3b148cab9187fa07a4e52cbf9ad798a
2020-06-16 17:26:18 +08:00
TreeHugger Robot
4259c529da Merge changes Ic0d7b4d2,I3441e630,Ie504e687 into rvc-dev am: 2e5dd7ab32 am: 0fd2d1e936 am: 0b47a00e13 am: a4bbdbd208
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11686091

Change-Id: I407bf9c5b81532c2dfa9f4a44912831b7bd64387
2020-06-15 04:25:07 +00:00
TreeHugger Robot
0b47a00e13 Merge changes Ic0d7b4d2,I3441e630,Ie504e687 into rvc-dev am: 2e5dd7ab32 am: 0fd2d1e936
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11686091

Change-Id: Idaa4b4c0e7c60230e8c6be56902da40d9385f107
2020-06-15 03:54:46 +00:00
TreeHugger Robot
e8303a537a Merge changes Ic0d7b4d2,I3441e630,Ie504e687 into rvc-dev am: 2e5dd7ab32
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11686091

Change-Id: Ie8902039154646d934efb7bf773ca1c8ada5ff1a
2020-06-15 03:42:54 +00:00
TreeHugger Robot
2e5dd7ab32 Merge changes Ic0d7b4d2,I3441e630,Ie504e687 into rvc-dev
* changes:
  gralloc4-vts: Test metadata is consistent in cloned buffers
  gralloc4-vts: Test layout and component info of RAW12
  gralloc4-vts: Test layout and component info of RAW10
2020-06-15 03:25:50 +00:00
TreeHugger Robot
088355be85 Merge "Fix subsampling doc in PlaneLayout.aidl" into rvc-dev am: 6841c3e5e8 am: fc64a96d54 am: 16ab890cc2 am: bcad580160
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11716801

Change-Id: Id4b1ec56735bc5dc13f003b956da6db6d29cb78c
2020-06-09 15:33:51 +00:00
TreeHugger Robot
bcad580160 Merge "Fix subsampling doc in PlaneLayout.aidl" into rvc-dev am: 6841c3e5e8 am: fc64a96d54 am: 16ab890cc2
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11716801

Change-Id: Id22b4814757bc341939524bcadb5bdf5d870ff2a
2020-06-09 15:18:29 +00:00
TreeHugger Robot
3fee5183fe Merge "Fix subsampling doc in PlaneLayout.aidl" into rvc-dev am: 6841c3e5e8 am: fc64a96d54
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11716801

Change-Id: I1a33ce87ea13134d036084a65e16fbd1607cd6fe
2020-06-09 14:55:01 +00:00
TreeHugger Robot
4a2c990dd7 Merge "Fix subsampling doc in PlaneLayout.aidl" into rvc-dev am: 6841c3e5e8
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11716801

Change-Id: I7ca1d951940fc05ea1c7e957b5e52956117ad880
2020-06-09 14:38:43 +00:00
Yichi Chen
35d97d5417 gralloc4-vts: Test metadata is consistent in cloned buffers
GetMetadataClonedHandle checks the metadata can be gotten after a native
handle is cloned. SetMetadataClonedHandle checks the metadata can be set
on a cloned native handle.

Bug: 155224585
Test: VtsHalGraphicsMapperV4_0TargetTest
Change-Id: Ic0d7b4d21a64822f2f1dbeca8d48c450711ed494
2020-06-08 16:43:55 +08:00
layog
26ddd0125c gralloc4-vts: Test layout and component info of RAW12
Bug: 157534008
Test: VtsHalGraphicsMapperV4_0TargetTest
Change-Id: I3441e630b18f3d6e0f5cbcecf8a54dc1b42faa84
2020-06-08 16:43:53 +08:00
Yichi Chen
0809466b61 gralloc4-vts: Test layout and component info of RAW10
To ensure the correctness of the plane layout and layout component on
RAW10 format, the patch creates the test case to check corresponding
data.

Bug: 157534008
Test: VtsHalGraphicsMapperV4_0TargetTest
Change-Id: Ie504e687e149ee4f4fb3f715ee0de7d7ec31952a
2020-06-08 16:42:39 +08:00
layog
96c0c3705e Fix subsampling doc in PlaneLayout.aidl
A subsampling value of 1 is a valid value indicating no subsampling

Fix: 158067777
Test: Compiles
Change-Id: I58f20df0b61e3637cb01a69f28ecef414f88a27d
2020-06-04 15:26:57 +08:00
Midas Chien
6302ca412d Merge "composer: vts: send refresh frame even composition changes" into rvc-dev am: ac4ee96268 am: e01dd849b6 am: 8ed6b58680 am: f9fcd21539
Original change: undetermined

Change-Id: I067adfb8254ea1d706eb1a69d77fc3f50b517bf4
2020-06-02 17:52:34 +00:00
Midas Chien
8ed6b58680 Merge "composer: vts: send refresh frame even composition changes" into rvc-dev am: ac4ee96268 am: e01dd849b6
Original change: undetermined

Change-Id: Iaf2ac21883d6661dc925d2b4fbe2b4a74ddd8b32
2020-06-02 17:16:25 +00:00
Midas Chien
8c79371377 Merge "composer: vts: send refresh frame even composition changes" into rvc-dev am: ac4ee96268
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11631145

Change-Id: Ie92e8d7df9f0622c5f4fa23b0244ba433cc55e54
2020-06-02 16:57:19 +00:00
Midas Chien
2f5aec7024 composer: vts: send refresh frame even composition changes
sendRefreshFrame is used to send refresh frame to composer, so even
composition changes should present frame to composer.

Bug: 157638511
Test: VtsHalGraphicsComposerV2_4TargetTest on C2, R3
Change-Id: I325668b7a75cbbe72841c424eb9fc43479ac48b6
2020-05-28 22:53:01 +08:00
TreeHugger Robot
20ecaebf58 Merge "gralloc4-vts: Allow getFromBufferDescriptorInfo return unsupported" into rvc-dev am: 5f0ce20538 am: d120e5a638 am: dd4d30f891 am: 7596011a9b
Change-Id: I598ebb08c48b5f75005db750ab5f16327ac6e67a
2020-05-25 03:33:28 +00:00
TreeHugger Robot
dd4d30f891 Merge "gralloc4-vts: Allow getFromBufferDescriptorInfo return unsupported" into rvc-dev am: 5f0ce20538 am: d120e5a638
Change-Id: I240c68874f55bfc1f295e53421e42091488de132
2020-05-25 03:04:45 +00:00
TreeHugger Robot
fe6dec9f22 Merge "gralloc4-vts: Allow getFromBufferDescriptorInfo return unsupported" into rvc-dev am: 5f0ce20538
Change-Id: If11bf8b0f2c728199c95b032785af63ef8e2134f
2020-05-25 02:49:51 +00:00
TreeHugger Robot
5f0ce20538 Merge "gralloc4-vts: Allow getFromBufferDescriptorInfo return unsupported" into rvc-dev 2020-05-25 02:33:51 +00:00
Jooyung Han
5329ec0cac Set min_sdk_version to be part of mainline modules am: 350467dac3 am: b3310b3667 am: 544c0bdb82 am: e98135f31f
Change-Id: If4d4c6350d98428ff9ab6c5ca07fb142c6bfbed6
2020-05-21 21:36:20 +00:00