Commit Graph

612 Commits

Author SHA1 Message Date
Patrick Rohr
6a4e929c1c add filter delay hint
Test: TreeHugger
Bug: 183057734
Change-Id: Ifcff75b0d46661678bce79d5587c898a2348c2dc
2021-10-28 19:45:43 +02:00
Gareth Fenn
53ae3838d5 Fix TunerHAL deadlock issue
testRecordOutput() holds msgLock preventing record thread from progressing
  Calls to stopRecordThread() block forever
  Therefore remove the calls to stopRecordThread()
Fix mDataOutputBuffer copy size
Fix getCiCamInfo config

Bug: 201556155
Test: VtsHalTvTunerV1_{0,1}TargetTest on BCM device
Signed-off-by: Pierre Couillaud <pierre@broadcom.com>
Change-Id: I7faeed032281b58fdc3361f297cb541491c4049d
2021-10-19 12:37:43 -07:00
Gareth Fenn
282fb370ab TunerHAL fixes
TunerHAL expects Hz
Fix stopRecordThread race
Push segment000000.ts to device
getFrontendIdByType() should return INVALID_ID when no FE found

Bug: 201556155
Test: VtsHalTvTunerV1_{0,1}TargetTest on BCM device
Change-Id: Idab6817e47f3e10f07a36a8b2fd805336b9f0e5d
Signed-off-by: Pierre Couillaud <pierre@broadcom.com>
2021-10-19 12:34:22 -07:00
Hongguang
76ca9a880e Stop current tuning before starting a new tuning.
If a new tuning request comes before stop old tuning, there is race
condition that the Frontend loop thread may crash while terminate().

Bug: 202335601
Fix: 202335601
Test: atest android.media.tv.tuner.cts
Change-Id: Ic168b585f0a8fe36bd8eeceee3e0b4c83d5388aa
2021-10-07 12:43:58 -07:00
Pierre Couillaud
d73352eab9 Fix closure of record thread
Bug: 197763854
Fix: 197763854
Change-Id: I8c3e843ddac6ad77aecaca7c91f0884204145ee6
2021-08-27 17:18:20 -07:00
Hongguang
901aa7b754 Refine tuner aidl hal threads.
Bug: 197763854
Test: VtsHalTvTunerTargetTest
Test: atest android.media.tv.tuner.cts
Test: sampletunertvinput
Change-Id: Id707438178ed93731919f0155cab805436147f86
2021-08-26 13:07:09 -07:00
Hongguang
11da2cb5f7 Adjust tuner default implementation and VTS types size.
Bug: 195693712
Test: atest VtsHalTvTunerTargetTest
Test: atest android.media.tv.tuner.cts
Change-Id: Ie9d20c74b05ecc10333ca883fe38d26d78f33949
2021-08-16 17:33:24 -07:00
Hongguang
22122b3014 Adjust some tuner aidl types size to align with frameworks.
Bug: 195693712
Test: atest VtsHalTvTunerTargetTest
Change-Id: Ia558614759928579bda7dd8e88f5e3fb538bf412
2021-08-16 16:32:33 -07:00
Hongguang Chen
ff2c6b0d85 Add init() to avoid crash when creating ref in constructor.
This reverts commit 50899fb269.

Bug: 195717690
Fix: 195717690
Test: atest VtsHalTvTunerTargetTest
Change-Id: Icae435f1166e6cf2e2f235979e3d1d37d182d517
2021-08-09 15:41:50 -07:00
Hongguang
50899fb269 Fix tuner example crash.
Bug: 195717690
Fix: 195717690
Test: atest VtsHalTvTunerTargetTest
Change-Id: Ie1ac0f12f9802ac55f1e35ff8dc7c0c34ccce086
2021-08-06 06:26:33 +00:00
Jiyong Park
1519b41bdd Merge "Remove ndk_platform backend. Use the ndk backend." 2021-08-05 13:51:02 +00:00
Hongguang
278bb563bc Cast packetSize to uint8_t before using.
packetSize is int8_t on AIDL HAL, but packet size may be longer than
128, which will cause a HAL crash.

Bug: 191825295
Test: atest android.media.tv.tuner.cts
Test: atest VtsHalTvTunerTargetTest
Change-Id: I9ee52d3cacab40e69f5f01dbe51c397fa09bfea0
2021-08-04 15:00:17 -07:00
TreeHugger Robot
b728aeb3b2 Merge changes from topic "tuner_aidl_isdbt_update"
* changes:
  Update tuner AIDL default implementation.
  Fix a typo in ISDBT Frontend.
2021-08-04 18:10:19 +00:00
Jiyong Park
c426c6dbdc Remove ndk_platform backend. Use the ndk backend.
The ndk_platform backend will soon be deprecated because the ndk backend
can serve the same purpose. This is to eliminate the confusion about
having two variants (ndk and ndk_platform) for the same ndk backend.

Bug: 161456198
Test: m
Change-Id: I0652f1efe920111d79dd8c2ecd52e55dda54538f
2021-08-04 12:48:07 +09:00
Lu Chen
79129882f8 Merge "Make a few function parameters to be reference" 2021-08-04 01:52:11 +00:00
Hongguang
e69a3b29e7 Update tuner AIDL default implementation.
*) Fix ISDBT Frontend in the default implementation.
*) Merge ag/15455889.

Bug: 191825295
Test: atest VtsHalTvTunerTargetTest
Change-Id: I70029cfc856aadcdfda0d3c3a1eb1a80f9674e25
2021-08-03 17:50:52 -07:00
Hongguang
5fc72a6379 Fix a typo in ISDBT Frontend.
FrontendIsdbtCoderate and FrontendIsdbtGuardInterval are typedefs in
HIDL HAL. The hidl2aidl tool used the original types in the parcelable
while conversion. And the wrong comment on FrontendIsdbtCoderate was
herited from HIDL too.

Bug: 191825295
Test: atest VtsHalTvTunerTargetTest
Change-Id: I44679e171b353010e9ea9cdd84b09a715459b4e7
2021-08-03 17:50:10 -07:00
Lu Chen
fdf37fc742 Make a few function parameters to be reference
To avoid redundant copies of input data, const reference is used.

Note that there is a behavior change when calling
createMediaFilterEventWithIon: the output buffer will be cleared even if
the operation fails to unblock future calls.

Test: vts-tradefed run vts -m VtsHalTvTunerV1_1TargetTest
Change-Id: Ib26f90930d288738c5b55843e2aecde5318c3786
2021-08-03 16:07:02 -07:00
Hongguang
ce1e30d578 Update tuner default implementation and VTS.
*) DemuxFilterTypeDemuxFilterSubType -> DemuxFilterSubType.

Bug: 191825295
Test: make and run VtsHalTvTunerTargetTest
Change-Id: I9069ff91d35b58ee1db4297f888ef241cdfbc135
2021-08-03 08:57:32 -07:00
Hongguang
e24a0dce53 Update tuner AIDL HAL.
*) Remove unused FrontendDtmbCapabilities from ITuner.
*) DemuxFilterTypeDemuxFilterSubType -> DemuxFilterSubType.

Bug: 191825295
Test: make and run VtsHalTvTunerTargetTest
Change-Id: I79cb58d3eff559d381a6cf13711250330d2066b1
2021-08-03 08:57:02 -07:00
Hongguang
e423acd4b5 Update tuner default AIDL HAL.
*) Use tuner AIDL HAL return values.
*) Replace mTunerService with mTuner to avoid confusing.
*) Merge other HIDL HAL changes.
   *) ag/15371813, ag/15371814 and ag/15371815.

Bug: 191825295
Test: make and run VtsHalTvTunerTargetTest
Change-Id: Ibbf94c4fc36c3bda94a7e0f3e0697c83ac414d0e
2021-07-28 19:33:47 -07:00
Hongguang
84d45ee992 Add Tuner AIDL error codes to align with HIDL.
Aidl will return these error codes as service specific errors in
EX_SERVICE_SPECIFIC.

Bug: 191825295
Test: make and run VtsHalTvTunerTargetTest
Change-Id: Ib27300229e30f40bd779188083f1db309dec89e4
2021-07-28 18:34:49 -07:00
Patrick Rohr
7d34149e8a Merge changes I388fc2b8,I639e8314
* changes:
  Remove Unused Function Declarations from DVR Default Implementation
  Clean Up Playback Thread in DVR Test Implementation
2021-07-27 06:55:32 +00:00
TreeHugger Robot
3884b0f221 Merge "Remove Unused Member from Default Impl" 2021-07-27 01:25:57 +00:00
Hongguang
600a6ae738 Add Tuner AIDL HAL VTS test cases
Bug: 191825295
Test: make and run VtsHalTvTunerTargetTest
Change-Id: Id7360e1b2da148db5c13ed2bdf3c866cc53db17b
2021-07-23 13:54:15 -07:00
Hongguang
4092f2f39c Add Tuner AIDL default implementation
Bug: 191825295
Test: make and run VtsHalTvTunerTargetTest
Change-Id: I781f67424ca1890f038160a4fda660507ab9e916
2021-07-23 13:53:56 -07:00
Hongguang
6ee5dc3327 Convert Tuner 1.1 HIDL HAL to AIDL
Bug: 191825295
Test: make and run VtsHalTvTunerTargetTest
Change-Id: I0c346c2c2d58fd6319d0310013da4d4c00ea2b50
2021-07-23 13:48:30 -07:00
Patrick Rohr
eae26b7608 Remove Unused Function Declarations from DVR Default Implementation
Bug: 194476544
Test: atest VtsHalTvTunerV1_0TargetTest && atest
VtsHalTvTunerV1_1TargetTest

Change-Id: I388fc2b864763ca38f960de2698d292964d0c15b
2021-07-23 15:17:07 +02:00
Patrick Rohr
45eff329e0 Clean Up Playback Thread in DVR Test Implementation
Bug: 194476544
Test: atest VtsHalTvTunerV1_0TargetTest && atest
VtsHalTvTunerV1_1TargetTest

Change-Id: I639e8314a499c07758c4927fa10cb4ff0e6dcb50
2021-07-23 15:14:17 +02:00
Patrick Rohr
93b2454563 Remove Unused Member from Default Impl
Bug: 194476544
Test: atest VtsHalTvTunerV1_0TargetTest && atest
VtsHalTvTunerV1_1TargetTest

Change-Id: I347ca125bdc557e36ca42b7a4f308a6151e12fe5
2021-07-23 13:58:32 +02:00
Hongguang
ac8f96b922 Use reference or pointer in tuner vts.
Bug: 188709323
Bug: 191825295
Test: VtsHalTvTunerV1_0TargetTest and VtsHalTvTunerV1_1TargetTest.
Change-Id: I93f2c9639033f8cb0f48de035e1c6ba488ea83e0
2021-07-08 16:24:57 +00:00
Nathalie Le Clair
562e4f2aa8 Merge "Adding OWNERS for CEC HAL" 2021-07-01 07:41:17 +00:00
Treehugger Robot
dfcbb902d3 Merge "CEC: Add implementation of WAKEUP option to default HdmiCec" am: 229d55513b am: a5a924db68
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1742234

Change-Id: I1fb7c4a068454680075be7ae7653370637466657
2021-06-30 12:13:13 +00:00
Treehugger Robot
f5bf43772e Merge "CEC: Add implementation of ENABLE_CEC option to default HdmiCec" am: 22135d775e am: 85f9d241c0
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1742233

Change-Id: I5af558a3acb89e47b019335ba17281ab600ba1eb
2021-06-30 12:13:05 +00:00
Treehugger Robot
229d55513b Merge "CEC: Add implementation of WAKEUP option to default HdmiCec" 2021-06-30 11:52:03 +00:00
Treehugger Robot
22135d775e Merge "CEC: Add implementation of ENABLE_CEC option to default HdmiCec" 2021-06-30 11:41:43 +00:00
Treehugger Robot
4007d5df6d Merge changes Iaaec9a0a,I280d1424,Ic8a65044,I019cb5cf,I245d52a7, ... am: dba159dcfd am: 0bbe24d12d
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1730535

Change-Id: Ibe0d554ca146a75db95beb7fef55949317c92ae5
2021-06-30 11:22:15 +00:00
Treehugger Robot
dba159dcfd Merge changes Iaaec9a0a,I280d1424,Ic8a65044,I019cb5cf,I245d52a7, ...
* changes:
  CEC: Add event handler to default HdmiCec
  CEC: Add implementation of setCallback method to default HdmiCec
  CEC: Add implementation of addLogicalAddress method to default HdmiCec
  CEC: Add implementation of getCecVersion method to default HdmiCec
  CEC: Add implementation of isConnected method to default HdmiCec
  CEC: Add implementation of getVendorId method to default HdmiCec
  CEC: Add implementation of getPortInfo method to default HdmiCec
  CEC: Add implementation of clearLogicalAddress method to default HdmiCec
  CEC: Add implementation of getPhysicalAddress method to default HdmiCec
  CEC: Add implementation of SendMessage method to default HdmiCec
  CEC: Initialise the HAL based on default implementation
2021-06-30 10:53:02 +00:00
Nathalie Le Clair
e45604161a Adding OWNERS for CEC HAL
Bug: 185434120
Test: none

Change-Id: Ie475d581a7e703f9f82a7afb9188c9a2c789189b
2021-06-30 09:33:46 +00:00
Shraddha Basantwani
05c454f356 CEC: Add implementation of WAKEUP option to default HdmiCec
When WAKEUP is set to false, HAL does not wake up the system
upon receiving <Image View On> or <Text View On> messages.

Bug: 185434120
Test: manual
Change-Id: Iaf98020decc887f04b02da480adc70b76189b66d
2021-06-24 16:30:47 +05:30
Shraddha Basantwani
d591d97536 CEC: Add implementation of ENABLE_CEC option to default HdmiCec
When ENABLE_CEC is set to false, all the CEC commands are discarded

Bug: 185434120
Test: manual
Change-Id: Iaf7e61af0b5047b041818acf2590c3ffce2f3318
2021-06-24 16:30:47 +05:30
Treehugger Robot
555c368ddb Merge "Replace writepid with task_profiles command for cgroup migration" am: a43f14bdac am: 7151796908
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1740279

Change-Id: I8c9ebb5de59a2b8a87c8045cfc8c64b71eac0f10
2021-06-23 23:09:57 +00:00
Suren Baghdasaryan
dd50b2f45d Replace writepid with task_profiles command for cgroup migration
writepid command usage to join a cgroup has been deprecated in favor
of a more flexible approach using task_profiles. This way cgroup path
is not hardcoded and cgroup changes can be easily made. Replace
writepid with task_profiles command to migrate between cgroups.

Bug: 191283136
Test: build and boot
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Change-Id: I249ecc45a001a69d73b06b77154f9b6e5f9964d9
2021-06-23 18:43:27 +00:00
Shraddha Basantwani
0c8a05440b CEC: Add event handler to default HdmiCec
Event handler polls the file descriptor for
CEC messages and events

Bug: 185434120
Test: manual
Change-Id: Iaaec9a0a74b264e5ec8625d7fce3d821208fd5ac
2021-06-18 20:26:09 +05:30
Shraddha Basantwani
92fa8e926f CEC: Add implementation of setCallback method to default HdmiCec
Bug: 185434120
Test: manual
Change-Id: I280d142427ae49eca5abce01eded569efdaf8221
2021-06-18 16:12:42 +05:30
Shraddha Basantwani
d50fd04f4c CEC: Add implementation of addLogicalAddress method to default HdmiCec
Bug: 185434120
Test: manual
Change-Id: Ic8a65044434d3b8a4e0aead5ccf9534dab388d9e
2021-06-18 16:12:42 +05:30
Shraddha Basantwani
105b1c3007 CEC: Add implementation of getCecVersion method to default HdmiCec
Bug: 185434120
Test: manual
Change-Id: I019cb5cf68e73331b1468b60cbfb95be7a052522
2021-06-18 16:12:42 +05:30
Shraddha Basantwani
2120790ee6 CEC: Add implementation of isConnected method to default HdmiCec
Bug: 185434120
Test: manual
Change-Id: I245d52a7ef4e57852277fce655bd6383e0461f92
2021-06-18 16:12:42 +05:30
Shraddha Basantwani
697e280bde CEC: Add implementation of getVendorId method to default HdmiCec
Bug: 185434120
Test: manual
Change-Id: Ie6b1f0d2551ca271d492c59be5897f77e18b0698
2021-06-18 16:12:42 +05:30
Shraddha Basantwani
332541054e CEC: Add implementation of getPortInfo method to default HdmiCec
Bug: 185434120
Test: manual
Change-Id: Icb12d161304559b12723900192482173c6280052
2021-06-18 16:12:42 +05:30