Commit Graph

4 Commits

Author SHA1 Message Date
Michael Butler
fd14e27b89 Fix RS HIDL server, pass data by bytes instead of by elements.
Our current stack:
  API->API_TO_HAL_translator->HAL
          ->HAL_TO_Implementation_translator->Implementation

  For most APIs:
  - API passes objectCount.
  - HAL expects objectCount.
  - Implementation expects objectCount.

  For APIs like ScriptGroupCreate:
  - API passes byteCount. And unfortunately, these APIs are part of
    NDK, we could not make them also passing objectCount like others.
  - HAL expects objectCount.
  - Implementation expects byteCount.

  So that both API_TO_HAL_translator and
  HAL_TO_Implementation_translator should correctly convert input
  objectCount/byteCount to byteCount/objectCount.

  This CL only fixes the HAL_TO_Implementation_translator part,
  whereas aosp/356395 fixes the API_TO_HAL_translator part. Both
  parts were mistakenly using byteCount as objectCount, causing
  potential out-of-bound access.

Bug: 36404879
Test: mm on angler
Change-Id: I28541a8926aeafece40e2a3f664bda67e26a34a2
2017-03-29 17:09:57 -07:00
Steven Moreland
96d2e3e9df renderscript: fix unused variable warning
Test: pass
Change-Id: I1f87c4430a908a41f7fd117de0d669420d508a69
2017-03-08 16:22:00 -08:00
Stephen Hines
746f3cd894 Fix mips-related build breakage.
Bug: http://b/34396220
Test: Builds successfully.

MIPS targets predefine _mips to 1, which will conflict with the _mips
variable name that was being used in the HAL here. Rename it to _amips
instead, so that it won't conflict.

Merged-In: Id13f34b740959852dff600259e3405eb72d0983a
Change-Id: Id13f34b740959852dff600259e3405eb72d0983a
2017-02-21 11:56:20 -08:00
Miao Wang
b78b2f4ee6 RenderScript HIDL HAL definition and server-side implementation.
Contains the definition and implementation of the HAL.

Bug: 34396220

Test: mm, all cts tests pass on bullhead and sailfish
Merged-In: Ic560efef34f647f441c32ba01ca29d83a3d98b69
Change-Id: Ic560efef34f647f441c32ba01ca29d83a3d98b69
2017-02-21 11:55:32 -08:00