mirror of
https://github.com/Evolution-X/hardware_interfaces
synced 2026-02-09 02:20:18 +00:00
Pass "no fixup base dirs" flag to the XInclude processor to avoid modifications of the top-level elements from included XML files as a result of "fixup." Added tests to ensure that all relevant XInclude scenarios work. Bug: 192619060 Test: atest -host android.hardware.audio.common.test.utility_tests Change-Id: Id595c9fd30be378d76387ee55a8937e0bf28d1cd
184 lines
6.6 KiB
C++
184 lines
6.6 KiB
C++
/*
|
|
* Copyright (C) 2018 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#define LOG_TAG "ValidateAudioConfig"
|
|
#include <utils/Log.h>
|
|
|
|
#include <numeric>
|
|
|
|
#define LIBXML_SCHEMAS_ENABLED
|
|
#include <libxml/xmlschemastypes.h>
|
|
#define LIBXML_XINCLUDE_ENABLED
|
|
#include <libxml/xinclude.h>
|
|
|
|
#include <memory>
|
|
#include <string>
|
|
|
|
#include "ValidateXml.h"
|
|
|
|
namespace android {
|
|
namespace hardware {
|
|
namespace audio {
|
|
namespace common {
|
|
namespace test {
|
|
namespace utility {
|
|
|
|
/** Map libxml2 structures to their corresponding deleters. */
|
|
template <class T>
|
|
constexpr void (*xmlDeleter)(T* t);
|
|
template <>
|
|
constexpr auto xmlDeleter<xmlSchema> = xmlSchemaFree;
|
|
template <>
|
|
constexpr auto xmlDeleter<xmlDoc> = xmlFreeDoc;
|
|
template <>
|
|
constexpr auto xmlDeleter<xmlSchemaParserCtxt> = xmlSchemaFreeParserCtxt;
|
|
template <>
|
|
constexpr auto xmlDeleter<xmlSchemaValidCtxt> = xmlSchemaFreeValidCtxt;
|
|
|
|
/** @return a unique_ptr with the correct deleter for the libxml2 object. */
|
|
template <class T>
|
|
constexpr auto make_xmlUnique(T* t) {
|
|
// Wrap deleter in lambda to enable empty base optimization
|
|
auto deleter = [](T* t) { xmlDeleter<T>(t); };
|
|
return std::unique_ptr<T, decltype(deleter)>{t, deleter};
|
|
}
|
|
|
|
/** Class that handles libxml2 initialization and cleanup. NOT THREAD SAFE*/
|
|
struct Libxml2Global {
|
|
Libxml2Global() {
|
|
xmlLineNumbersDefault(1); // Better error message
|
|
xmlSetGenericErrorFunc(this, errorCb);
|
|
}
|
|
~Libxml2Global() {
|
|
// TODO: check if all those cleanup are needed
|
|
xmlSetGenericErrorFunc(nullptr, nullptr);
|
|
xmlSchemaCleanupTypes();
|
|
xmlCleanupParser();
|
|
xmlCleanupThreads();
|
|
}
|
|
|
|
const std::string& getErrors() { return errors; }
|
|
|
|
private:
|
|
static void errorCb(void* ctxt, const char* msg, ...) {
|
|
auto* self = static_cast<Libxml2Global*>(ctxt);
|
|
va_list args;
|
|
va_start(args, msg);
|
|
|
|
char* formatedMsg;
|
|
if (vasprintf(&formatedMsg, msg, args) >= 0) {
|
|
LOG_PRI(ANDROID_LOG_ERROR, LOG_TAG, "%s", formatedMsg);
|
|
self->errors += "Error: ";
|
|
self->errors += formatedMsg;
|
|
}
|
|
free(formatedMsg);
|
|
|
|
va_end(args);
|
|
}
|
|
std::string errors;
|
|
};
|
|
|
|
::testing::AssertionResult validateXml(const char* xmlFilePathExpr, const char* xsdFilePathExpr,
|
|
const char* xmlFilePath, const char* xsdFilePath) {
|
|
Libxml2Global libxml2;
|
|
|
|
auto context = [&]() {
|
|
return std::string() + " While validating: " + xmlFilePathExpr +
|
|
"\n Which is: " + xmlFilePath + "\nAgainst the schema: " + xsdFilePathExpr +
|
|
"\n Which is: " + xsdFilePath + "\nLibxml2 errors:\n" + libxml2.getErrors();
|
|
};
|
|
|
|
auto schemaParserCtxt = make_xmlUnique(xmlSchemaNewParserCtxt(xsdFilePath));
|
|
auto schema = make_xmlUnique(xmlSchemaParse(schemaParserCtxt.get()));
|
|
if (schema == nullptr) {
|
|
return ::testing::AssertionFailure() << "Failed to parse schema (xsd)\n" << context();
|
|
}
|
|
|
|
auto doc = make_xmlUnique(xmlReadFile(xmlFilePath, nullptr, 0));
|
|
if (doc == nullptr) {
|
|
return ::testing::AssertionFailure() << "Failed to parse xml\n" << context();
|
|
}
|
|
|
|
// Process 'include' directives w/o modifying elements loaded from included files.
|
|
if (xmlXIncludeProcessFlags(doc.get(), XML_PARSE_NOBASEFIX) == -1) {
|
|
return ::testing::AssertionFailure() << "Failed to resolve xincludes in xml\n" << context();
|
|
}
|
|
|
|
auto schemaCtxt = make_xmlUnique(xmlSchemaNewValidCtxt(schema.get()));
|
|
int ret = xmlSchemaValidateDoc(schemaCtxt.get(), doc.get());
|
|
if (ret > 0) {
|
|
return ::testing::AssertionFailure() << "XML is not valid according to the xsd\n"
|
|
<< context();
|
|
}
|
|
if (ret < 0) {
|
|
return ::testing::AssertionFailure() << "Internal or API error\n" << context();
|
|
}
|
|
|
|
return ::testing::AssertionSuccess();
|
|
}
|
|
|
|
template <bool atLeastOneRequired>
|
|
::testing::AssertionResult validateXmlMultipleLocations(
|
|
const char* xmlFileNameExpr, const char* xmlFileLocationsExpr, const char* xsdFilePathExpr,
|
|
const char* xmlFileName, const std::vector<std::string>& xmlFileLocations,
|
|
const char* xsdFilePath) {
|
|
using namespace std::string_literals;
|
|
|
|
std::vector<std::string> errors;
|
|
std::vector<std::string> foundFiles;
|
|
|
|
for (const auto& location : xmlFileLocations) {
|
|
std::string xmlFilePath = location + "/"s + xmlFileName;
|
|
if (access(xmlFilePath.c_str(), F_OK) != 0) {
|
|
// If the file does not exist ignore this location and fallback on the next one
|
|
continue;
|
|
}
|
|
foundFiles.push_back(" " + xmlFilePath + '\n');
|
|
auto result = validateXml("xmlFilePath", xsdFilePathExpr, xmlFilePath.c_str(), xsdFilePath);
|
|
if (!result) {
|
|
errors.push_back(result.message());
|
|
}
|
|
}
|
|
|
|
if (atLeastOneRequired && foundFiles.empty()) {
|
|
errors.push_back("No xml file found in provided locations.\n");
|
|
}
|
|
|
|
return ::testing::AssertionResult(errors.empty())
|
|
<< errors.size() << " error" << (errors.size() == 1 ? " " : "s ")
|
|
<< std::accumulate(begin(errors), end(errors), "occurred during xml validation:\n"s)
|
|
<< " While validating all: " << xmlFileNameExpr
|
|
<< "\n Which is: " << xmlFileName
|
|
<< "\n In the following folders: " << xmlFileLocationsExpr
|
|
<< "\n Which is: " << ::testing::PrintToString(xmlFileLocations)
|
|
<< (atLeastOneRequired ? "\nWhere at least one file must be found."
|
|
: "\nWhere no file might exist.");
|
|
}
|
|
|
|
template ::testing::AssertionResult validateXmlMultipleLocations<true>(
|
|
const char*, const char*, const char*, const char*, const std::vector<std::string>&,
|
|
const char*);
|
|
template ::testing::AssertionResult validateXmlMultipleLocations<false>(
|
|
const char*, const char*, const char*, const char*, const std::vector<std::string>&,
|
|
const char*);
|
|
|
|
} // namespace utility
|
|
} // namespace test
|
|
} // namespace common
|
|
} // namespace audio
|
|
} // namespace hardware
|
|
} // namespace android
|