Merge "Use regex names for EVS HAL implementations"

This commit is contained in:
TreeHugger Robot
2020-01-30 23:08:21 +00:00
committed by Android (Google) Code Review
5 changed files with 11 additions and 2 deletions

View File

@@ -47,4 +47,11 @@ interface IEvsEnumerator extends @1.0::IEvsEnumerator {
* configured differently by another client.
*/
openCamera_1_1(string cameraId, Stream streamCfg) generates (IEvsCamera evsCamera);
/**
* Tells whether this is EVS manager or HAL implementation.
*
* @return result False for EVS manager implementations and true for all others.
*/
isHardware() generates (bool result);
};

View File

@@ -59,6 +59,7 @@ public:
Return<void> getCameraList_1_1(getCameraList_1_1_cb _hidl_cb) override;
Return<sp<IEvsCamera_1_1>> openCamera_1_1(const hidl_string& cameraId,
const Stream& streamCfg) override;
Return<bool> isHardware() override { return true; }
// Implementation details
EvsEnumerator();

View File

@@ -14,4 +14,4 @@
* limitations under the License.
*/
const static char kEnumeratorServiceName[] = "EvsEnumeratorHw";
const static char kEnumeratorServiceName[] = "hw/0";

View File

@@ -117,7 +117,7 @@ public:
pEnumerator = getService<IEvsEnumerator>(service_name);
ASSERT_NE(pEnumerator.get(), nullptr);
mIsHwModule = !service_name.compare(kEnumeratorName);
mIsHwModule = pEnumerator->isHardware();
}
virtual void TearDown() override {

View File

@@ -45,6 +45,7 @@
<interface>
<name>IEvsEnumerator</name>
<instance>default</instance>
<regex-instance>[a-z]+/[0-9]+</regex-instance>
</interface>
</hal>
<hal format="aidl" optional="true">