Evolution-x/hardware_interfaces
1
0
Fork 0
mirror of https://github.com/Evolution-X/hardware_interfaces synced 2026-02-01 11:36:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Updated VTS getSimultaneousCallingSupport test.

Browse Source 
This CL updates the getSimultaneousCallingSupport VTS test to ensure that REQUEST_NOT_SUPPORTED is not returned and that enabledLogicalSlots is set to an empty array by default for the default CF impl.

Test: VtsHalRadioTargetTest
Bug: 311495663
Change-Id: Ie382c14a19951bb69c7b7db4056f0e9dabc27685
This commit is contained in:
Grant Menke
2024-01-04 11:48:48 -08:00
parent f162180e87
commit 3bc635e7b7
3 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
radio/aidl/vts/radio_config_response.cpp
View File

@@ -41,8 +41,9 @@ ndk::ScopedAStatus RadioConfigResponse::getPhoneCapabilityResponse(
}
ndk::ScopedAStatus RadioConfigResponse::getSimultaneousCallingSupportResponse(
const RadioResponseInfo& info, const std::vector<int32_t>& /* enabledLogicalSlots */) {
const RadioResponseInfo& info, const std::vector<int32_t>& enabledLogicalSlots) {
rspInfo = info;
currentEnabledLogicalSlots = enabledLogicalSlots;
parent_config.notify(info.serial);
return ndk::ScopedAStatus::ok();
}

9
radio/aidl/vts/radio_config_test.cpp
View File

@@ -150,10 +150,17 @@ TEST_P(RadioConfigTest, getSimultaneousCallingSupport) {
ALOGI("getSimultaneousCallingSupport, rspInfo.error = %s\n",
toString(radioRsp_config->rspInfo.error).c_str());
// REQUEST_NOT_SUPPORTED is omitted here because users of the V3 HAL should implement this
// method and return at least an empty array
ASSERT_TRUE(CheckAnyOfErrors(
radioRsp_config->rspInfo.error,
{RadioError::NONE, RadioError::RADIO_NOT_AVAILABLE, RadioError::INTERNAL_ERR,
RadioError::MODEM_ERR, RadioError::REQUEST_NOT_SUPPORTED}));
RadioError::MODEM_ERR}));
if (radioRsp_config->rspInfo.error == RadioError ::NONE) {
// The size of enabledLogicalSLots should be 0 or a positive number:
EXPECT_GE(radioRsp_config->currentEnabledLogicalSlots.size(), 0);
}
}
/*

1
radio/aidl/vts/radio_config_utils.h
View File

@@ -39,6 +39,7 @@ class RadioConfigResponse : public BnRadioConfigResponse {
PhoneCapability phoneCap;
bool modemReducedFeatureSet1;
std::vector<SimSlotStatus> simSlotStatus;
std::vector<int32_t> currentEnabledLogicalSlots;
virtual ndk::ScopedAStatus getSimSlotsStatusResponse(
const RadioResponseInfo& info, const std::vector<SimSlotStatus>& slotStatus) override;