Merge changes from topic "lights-aidl-rust-derive"

* changes:
  lights: Add state to the example service
  lights aidl: Add required @Rust derive statements

light/aidl/aidl_api/android.hardware.light/2/.hash

@@ -1 +1,2 @@
 c8b1e8ebb88c57dcb2c350a8d9b722e77dd864c8
+c7d3d941d303c70d1c22759a0b09e41930c1cddb

light/aidl/aidl_api/android.hardware.light/2/android/hardware/light/HwLight.aidl

@@ -32,7 +32,7 @@
 // later when a module using the interface is updated, e.g., Mainline modules.
 
 package android.hardware.light;
-@VintfStability
+@RustDerive(Clone=true, Copy=true) @VintfStability
 parcelable HwLight {
   int id;
   int ordinal;

light/aidl/aidl_api/android.hardware.light/2/android/hardware/light/HwLightState.aidl

@@ -32,7 +32,7 @@
 // later when a module using the interface is updated, e.g., Mainline modules.
 
 package android.hardware.light;
-@VintfStability
+@RustDerive(Clone=true, Copy=true) @VintfStability
 parcelable HwLightState {
   int color;
   android.hardware.light.FlashMode flashMode;

light/aidl/aidl_api/android.hardware.light/current/android/hardware/light/HwLight.aidl

@@ -32,7 +32,7 @@
 // later when a module using the interface is updated, e.g., Mainline modules.
 
 package android.hardware.light;
-@VintfStability
+@RustDerive(Clone=true, Copy=true) @VintfStability
 parcelable HwLight {
   int id;
   int ordinal;

light/aidl/aidl_api/android.hardware.light/current/android/hardware/light/HwLightState.aidl

@@ -32,7 +32,7 @@
 // later when a module using the interface is updated, e.g., Mainline modules.
 
 package android.hardware.light;
-@VintfStability
+@RustDerive(Clone=true, Copy=true) @VintfStability
 parcelable HwLightState {
   int color;
   android.hardware.light.FlashMode flashMode;

light/aidl/android/hardware/light/HwLight.aidl

@@ -22,7 +22,7 @@ import android.hardware.light.LightType;
  * A description of a single light. Multiple lights can map to the same physical
  * LED. Separate physical LEDs are always represented by separate instances.
  */
-@VintfStability
+@RustDerive(Clone=true, Copy=true) @VintfStability
 parcelable HwLight {
     /**
      * Integer ID used for controlling this light

light/aidl/android/hardware/light/HwLightState.aidl

@@ -25,7 +25,7 @@ import android.hardware.light.FlashMode;
  * Not all lights must support all parameters. If you
  * can do something backward-compatible, do it.
  */
-@VintfStability
+@RustDerive(Clone=true, Copy=true) @VintfStability
 parcelable HwLightState {
     /**
      * The color of the LED in ARGB.

light/aidl/default/lights.rs

@@ -15,6 +15,9 @@
  */
 //! This module implements the ILights AIDL interface.
 
+use std::collections::HashMap;
+use std::sync::Mutex;
+
 use log::info;
 
 use android_hardware_light::aidl::android::hardware::light::{
@@ -23,33 +26,55 @@ use android_hardware_light::aidl::android::hardware::light::{
 
 use binder::{ExceptionCode, Interface, Status};
 
+struct Light {
+    hw_light: HwLight,
+    state: HwLightState,
+}
+
+const NUM_DEFAULT_LIGHTS: i32 = 3;
+
 /// Defined so we can implement the ILights AIDL interface.
-pub struct LightsService;
+pub struct LightsService {
+    lights: Mutex<HashMap<i32, Light>>,
+}
 
 impl Interface for LightsService {}
 
-const NUM_DEFAULT_LIGHTS: i32 = 3;
+impl LightsService {
+    fn new(hw_lights: impl IntoIterator<Item = HwLight>) -> Self {
+        let mut lights_map = HashMap::new();
+
+        for hw_light in hw_lights {
+            lights_map.insert(hw_light.id, Light { hw_light, state: Default::default() });
+        }
+
+        Self { lights: Mutex::new(lights_map) }
+    }
+}
+
+impl Default for LightsService {
+    fn default() -> Self {
+        let id_mapping_closure =
+            |light_id| HwLight { id: light_id, ordinal: light_id, r#type: LightType::BACKLIGHT };
+
+        Self::new((1..=NUM_DEFAULT_LIGHTS).map(id_mapping_closure))
+    }
+}
 
 impl ILights for LightsService {
     fn setLightState(&self, id: i32, state: &HwLightState) -> binder::Result<()> {
         info!("Lights setting state for id={} to color {:x}", id, state.color);
-        if id <= 0 || id > NUM_DEFAULT_LIGHTS {
-            return Err(Status::new_exception(ExceptionCode::UNSUPPORTED_OPERATION, None));
-        }
 
-        Ok(())
+        if let Some(light) = self.lights.lock().unwrap().get_mut(&id) {
+            light.state = *state;
+            Ok(())
+        } else {
+            Err(Status::new_exception(ExceptionCode::UNSUPPORTED_OPERATION, None))
+        }
     }
 
     fn getLights(&self) -> binder::Result<Vec<HwLight>> {
-        let mut lights: Vec<HwLight> = Vec::with_capacity(NUM_DEFAULT_LIGHTS.try_into().unwrap());
-
-        for i in 1..=NUM_DEFAULT_LIGHTS {
-            let light = HwLight { id: i, ordinal: i, r#type: LightType::BACKLIGHT };
-
-            lights.push(light);
-        }
-
         info!("Lights reporting supported lights");
-        Ok(lights)
+        Ok(self.lights.lock().unwrap().values().map(|light| light.hw_light).collect())
     }
 }

light/aidl/default/main.rs

@@ -35,7 +35,7 @@ fn main() {
 
     binder::ProcessState::set_thread_pool_max_thread_count(0);
 
-    let lights_service = LightsService;
+    let lights_service = LightsService::default();
     let lights_service_binder = BnLights::new_binder(lights_service, BinderFeatures::default());
 
     let service_name = format!("{}/default", LightsService::get_descriptor());