Evolution-x/hardware_interfaces
1
0
Fork 0
mirror of https://github.com/Evolution-X/hardware_interfaces synced 2026-02-01 11:36:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove use of ILLEGAL_ARGUMENT in hostEndpointDisconnected

Browse Source 
Since an invalid argument to hostEndpointDisconnected should
be ignored by the HAL (and the Context Hub service), remove
the EX_ILLEGAL_ARGUMENT requirement in the Context Hub AIDL
HAL.

Bug: 216798253
Test: Compile
Change-Id: I83f08ccb998e6b494307de51f8709f3e0fbd2c99
This commit is contained in:
Arthur Ishiguro
2022-02-01 17:03:32 +00:00
parent b12d418142
commit 5dba921320
2 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
contexthub/aidl/android/hardware/contexthub/IContextHub.aidl
View File

@@ -189,9 +189,8 @@ interface IContextHub {
* called, the HAL is expected to clean up any resources attached to the messaging channel
* associated with this host endpoint ID.
*
* @param hostEndPointId The ID of the host that has disconnected.
*
* @throws EX_ILLEGAL_ARGUMENT if hostEndpointId is not associated with a connected host.
* @param hostEndPointId The ID of the host that has disconnected. Any invalid values for this
* parameter should be ignored (no-op).
*/
void onHostEndpointDisconnected(char hostEndpointId);

3
contexthub/aidl/vts/VtsAidlHalContextHubTargetTest.cpp
View File

@@ -338,8 +338,7 @@ TEST_P(ContextHubAidl, TestHostConnection) {
TEST_P(ContextHubAidl, TestInvalidHostConnection) {
constexpr char16_t kHostEndpointId = 1;
Status status = contextHub->onHostEndpointDisconnected(kHostEndpointId);
ASSERT_EQ(status.exceptionCode(), android::binder::Status::EX_ILLEGAL_ARGUMENT);
ASSERT_TRUE(contextHub->onHostEndpointDisconnected(kHostEndpointId).isOk());
}
std::string PrintGeneratedTest(const testing::TestParamInfo<ContextHubAidl::ParamType>& info) {