Evolution-x/hardware_interfaces
1
0
Fork 0
mirror of https://github.com/Evolution-X/hardware_interfaces synced 2026-02-01 11:36:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Add warning about AIDL CAN HAL"

Browse Source
This commit is contained in:
Chris Weir
2022-12-17 01:46:04 +00:00
committed by Android (Google) Code Review
parent ca91d59122 c847a3cfda
commit 6911968348
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
automotive/can/1.0/tools/configurator/canhalconfigurator.cpp
View File

@@ -70,6 +70,9 @@ static bool processPbCfg(const config::CanBusConfig& pb_cfg) {
static bool configuratorStart(const std::string& filepath) {
base::SetDefaultTag("CanConfigurator");
LOG(WARNING) << "The HIDL version of CAN HAL has been deprecated, if this tool fails with "
<< "SIGABRT, you may need canhalconfigurator-aidl instead.";
auto pb_cfg = config::parseConfigFile(filepath);
if (!pb_cfg.has_value()) {
return false;

4
automotive/can/1.0/tools/libcanhaltools/libcanhaltools.cpp
View File

@@ -34,8 +34,8 @@ hidl_vec<hidl_string> getControlServices() {
auto manager = hidl::manager::V1_2::IServiceManager::getService();
hidl_vec<hidl_string> services;
manager->listManifestByInterface(ICanController::descriptor, hidl_utils::fill(&services));
CHECK(services.size() > 0) << "No ICanController services registered (missing privileges?)"
<< std::endl;
CHECK(services.size() > 0) << "No ICanController services registered (missing privileges?). "
<< "are you using the AIDL CanController?" << std::endl;
return services;
}