Evolution-x/hardware_interfaces
1
0
Fork 0
mirror of https://github.com/Evolution-X/hardware_interfaces synced 2026-02-01 05:49:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Assert the errors size to 1 for case SetDisplayBrightness

Browse Source 
null pointer dereference crash will be triggered if vector errors
is emptry when accessing errors[0].errorCode, so change EXPECT_EQ
to ASSERT_EQ to avoid this issue.

Test: run vts -m VtsHalGraphicsComposer3_TargetTest

Signed-off-by: Liu, Kai1 <kai1.liu@intel.com>
(cherry picked from https://android-review.googlesource.com/q/commit:aec33e9a41e4bccfd1834e1ab03f785eea4f0b52)
Merged-In: I3b30d491ef886b98e462447e6de78828e7822fca
Change-Id: I3b30d491ef886b98e462447e6de78828e7822fca
This commit is contained in:
Liu, Kai1
2024-05-15 14:58:43 +08:00
committed by Android Build Cherrypicker Worker
parent 0309dddb6c
commit 6adbf0c117
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
graphics/composer/aidl/vts/VtsHalGraphicsComposer3_TargetTest.cpp
View File

@@ -1839,7 +1839,7 @@ TEST_P(GraphicsComposerAidlCommandTest, SetDisplayBrightness) {
writer.setDisplayBrightness(getPrimaryDisplayId(), /*brightness*/ 0.5f, -1.f);
execute();
const auto errors = mReader.takeErrors();
EXPECT_EQ(1, errors.size());
ASSERT_EQ(1, errors.size());
EXPECT_EQ(IComposerClient::EX_UNSUPPORTED, errors[0].errorCode);
GTEST_SUCCEED() << "SetDisplayBrightness is not supported";
return;