Evolution-x/hardware_interfaces
1
0
Fork 0
mirror of https://github.com/Evolution-X/hardware_interfaces synced 2026-02-01 21:37:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Correct bug in HmacKeySharingTest

Browse Source 
The key sharing test modified the seed in an invalid way.

Bug: 77588764
Test: VtsHalKeymasterV4_0TargetTest
Change-Id: I0b2ac90397a3f23258ebd4dddc5f6043af7b1600
This commit is contained in:
Shawn Willden
2018-03-29 20:57:01 -06:00
parent 0a6c3d47da
commit 86a33acfce
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
keymaster/4.0/vts/functional/HmacKeySharingTest.cpp
View File

@@ -136,6 +136,7 @@ TEST_F(HmacKeySharingTest, ComputeSharedHmac) {
responses = computeSharedHmac(all_keymasters(), params);
ASSERT_GT(responses.size(), 0U);
ASSERT_EQ(32U, responses[0].sharing_check.size());
verifyResponses(responses[0].sharing_check, responses);
}
@@ -216,7 +217,11 @@ TEST_F(HmacKeySharingTest, ComputeSharedHmacCorruptSeed) {
// matter what value is in the additional byte; it changes the seed regardless.
auto param_to_tweak = rand() % params.size();
auto& to_tweak = params[param_to_tweak].seed;
to_tweak.resize(to_tweak.size() + 1);
ASSERT_TRUE(to_tweak.size() == 32 || to_tweak.size() == 0);
if (!to_tweak.size()) {
to_tweak.resize(32); // Contents don't matter; a little randomization is nice.
}
to_tweak[0]++;
responses = computeSharedHmac(all_keymasters(), params);
for (size_t i = 0; i < responses.size(); ++i) {