Evolution-x/hardware_interfaces
1
0
Fork 0
mirror of https://github.com/Evolution-X/hardware_interfaces synced 2026-02-01 11:36:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

composer: remove IComposer.dumpDebugInfo

Browse Source 
aidl already have a dump funciton, so there is no need to
expose a custom dumpDebugInfo from IComposer.

Bug: 220171623
Test: atest VtsHalGraphicsComposer3_TargetTest
Test: adb shell dumpsys SurfaceFlinger
Test: adb shell dumpsys android.hardware.graphics.composer3.IComposer/default
Change-Id: I5036193c06ba9fdd8aa5f79cd756541d9edc146c
This commit is contained in:
Ady Abraham
2022-02-18 17:04:55 -08:00
parent 5cb7fe91c6
commit 89d7270dcd
3 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
graphics/composer/aidl/aidl_api/android.hardware.graphics.composer3/current/android/hardware/graphics/composer3/IComposer.aidl
View File

@@ -35,7 +35,6 @@ package android.hardware.graphics.composer3;
@VintfStability
interface IComposer {
android.hardware.graphics.composer3.IComposerClient createClient();
String dumpDebugInfo();
android.hardware.graphics.composer3.Capability[] getCapabilities();
const int EX_NO_RESOURCES = 6;
}

8
graphics/composer/aidl/android/hardware/graphics/composer3/IComposer.aidl
View File

@@ -35,14 +35,6 @@ interface IComposer {
*/
IComposerClient createClient();
/**
* Retrieves implementation-defined debug information, which will be
* displayed during, for example, `dumpsys SurfaceFlinger`.
*
* @return is a string of debug information.
*/
String dumpDebugInfo();
/**
* Provides a list of supported capabilities (as described in the
* definition of Capability above). This list must not change after

11
graphics/composer/aidl/android/hardware/graphics/composer3/vts/functional/composer-vts/VtsComposerClient.cpp
View File

@@ -173,8 +173,15 @@ std::pair<ScopedAStatus, std::vector<DisplayCapability>> VtsComposerClient::getD
}
ScopedAStatus VtsComposerClient::dumpDebugInfo() {
std::string debugInfo;
return mComposer->dumpDebugInfo(&debugInfo);
int pipefds[2];
if (pipe(pipefds) < 0) {
return ScopedAStatus::fromServiceSpecificError(IComposer::EX_NO_RESOURCES);
}
const auto status = mComposer->dump(pipefds[1], /*args*/ nullptr, /*numArgs*/ 0);
close(pipefds[0]);
close(pipefds[1]);
return ScopedAStatus::fromStatus(status);
}
std::pair<ScopedAStatus, DisplayIdentification> VtsComposerClient::getDisplayIdentificationData(