Evolution-x/hardware_interfaces
1
0
Fork 0
mirror of https://github.com/Evolution-X/hardware_interfaces synced 2026-02-01 16:50:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix bad command length calculation

Browse Source 
SET_LAYER_PER_FRAME_METADATA_BLOBS command length
was calculated wrong. With wrong length
it's impossible to read current and any next commands right.

Test: manual
Bug: 144367999

Change-Id: I09a23bbf507996972ce7de0634f8866bbb13152a
Signed-off-by: o.v.yevtushenko <o.v.yevtushenko@globallogic.com>
This commit is contained in:
o.v.yevtushenko
2019-08-16 11:53:56 +03:00
committed by Oleksandr Yevtushenko
parent bbdd5e32fd
commit 8f76b5cfe6
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
graphics/composer/2.3/utils/command-buffer/include/composer-command-buffer/2.3/ComposerCommandBuffer.h
View File

@@ -79,6 +79,7 @@ class CommandWriterBase : public V2_2::CommandWriterBase {
void setLayerPerFrameMetadataBlobs(
const hidl_vec<IComposerClient::PerFrameMetadataBlob>& metadata) {
// in units of uint32_t's
size_t commandLength = 0;
if (metadata.size() > std::numeric_limits<uint32_t>::max()) {
@@ -86,12 +87,12 @@ class CommandWriterBase : public V2_2::CommandWriterBase {
return;
}
// number of blobs
commandLength += metadata.size();
// space for numElements
commandLength += 1;
for (auto metadataBlob : metadata) {
commandLength += sizeof(int32_t); // key of metadata blob
commandLength += 1; // size information of metadata blob
commandLength += 1; // key of metadata blob
commandLength += 1; // size information of metadata blob
// metadata content size
size_t metadataSize = metadataBlob.blob.size() / sizeof(uint32_t);