uwb(hal): Remove getAndroidCapabilities HAL API

This is unnecessary since we are anyway using GET_CAPS_INFO for querying
non-fira capabilities.

Bug: 208678993
Bug: 209053358
Test: Compiles
Change-Id: Id9af03b313ceaf00fb6d5231c454dc7c74a6287a
This commit is contained in:
Roshan Pius
2022-02-07 08:02:56 -08:00
parent 5ea2d1799c
commit b44de0093b
12 changed files with 20 additions and 103 deletions

View File

@@ -1,39 +0,0 @@
/*
* Copyright (C) 2021 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* You may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
///////////////////////////////////////////////////////////////////////////////
// THIS FILE IS IMMUTABLE. DO NOT EDIT IN ANY CASE. //
///////////////////////////////////////////////////////////////////////////////
// This file is a snapshot of an AIDL file. Do not edit it manually. There are
// two cases:
// 1). this is a frozen version file - do not edit this in any case.
// 2). this is a 'current' file. If you make a backwards compatible change to
// the interface (from the latest frozen version), the build system will
// prompt you to update this file with `m <name>-update-api`.
//
// You must not make a backward incompatible change to any AIDL file built
// with the aidl_interface module type with versions property set. The module
// type is used to build AIDL files in a way that they can be used across
// independently updatable components of the system. If a device is shipped
// with such a backward incompatible change, it has a high risk of breaking
// later when a module using the interface is updated, e.g., Mainline modules.
package android.hardware.uwb.fira_android;
@Backing(type="long") @VintfStability
enum UwbAndroidCapabilities {
POWER_STATS_QUERY = 1,
ANTENNA_INTERLEAVING = 2,
}

View File

@@ -34,6 +34,7 @@
package android.hardware.uwb.fira_android;
@Backing(type="int") @VintfStability
enum UwbVendorCapabilityTlvTypes {
SUPPORTED_POWER_STATS_QUERY = 192,
CCC_SUPPORTED_VERSIONS = 160,
CCC_SUPPORTED_UWB_CONFIGS = 161,
CCC_SUPPORTED_PULSE_SHAPE_COMBOS = 162,

View File

@@ -42,6 +42,5 @@ interface IUwbChip {
void coreInit();
void sessionInit(int sessionId);
int getSupportedAndroidUciVersion();
long getSupportedAndroidCapabilities();
int sendUciMessage(in byte[] data);
}

View File

@@ -66,16 +66,6 @@ interface IUwbChip {
*/
int getSupportedAndroidUciVersion();
/**
* Mechanism to allow HAL implementation to optionally expose features that are defined
* in the "android.hardware.uwb.fira_android" types-only package.
*
* @return Returns the bitmask of capabilities
* (android.hardware.uwb.fira_android.UwbAndroidCapabilities) that is supported by the
* HAL implementation.
*/
long getSupportedAndroidCapabilities();
/**
* Write the UCI message to the UWB Subsystem.
* The UCI message format is as per UCI protocol and it is

View File

@@ -1,31 +0,0 @@
/*
* Copyright (C) 2021 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* You may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package android.hardware.uwb.fira_android;
/**
* Android specific capabilities should be defined here.
*
* For any features enabled via the FIRA vendor commands for Android, use this bitmask
* to allow devices to expose the features supported by the HAL implementation.
*
*/
@VintfStability
@Backing(type="long")
enum UwbAndroidCapabilities {
POWER_STATS_QUERY = 0x1,
ANTENNA_INTERLEAVING = 0x2,
}

View File

@@ -29,6 +29,18 @@ package android.hardware.uwb.fira_android;
@VintfStability
@Backing(type="int")
enum UwbVendorCapabilityTlvTypes {
/*********************************************
* Protocol agnostic
********************************************/
/**
* 1 byte value to indicate support for power stats query
* Values:
* 1 - Feature supported.
* 0 - Feature not supported.
*/
SUPPORTED_POWER_STATS_QUERY = 0xC0,
/*********************************************
* CCC specific
********************************************/
@@ -96,7 +108,7 @@ enum UwbVendorCapabilityTlvTypes {
* FIRA specific
********************************************/
/**
* 1 byte value to indicate support for antennare interleaving
* 1 byte value to indicate support for antenna interleaving
* feature.
* Values:
* 1 - Feature supported.

View File

@@ -24,8 +24,8 @@ package android.hardware.uwb.fira_android;
@Backing(type="byte")
enum UwbVendorGidAndroidOids {
// Used by the command and response to get UWB power related stats.
// Supported only if the value returned by getSupportedAndroidCapabilities()
// has the bit of UwbAndroidCapabilities.POWER_STATS_QUERY set to 1.
// Supported only if the UwbVendorCapabilityTlvTypes.SUPPORTED_POWER_STATS_QUERY
// set to 1.
ANDROID_GET_POWER_STATS = 0x0,
// Used to set the current regulatory country code (determined usinag
// SIM or hardcoded by OEM).

View File

@@ -57,8 +57,8 @@ enum UwbVendorSessionAppConfigTlvTypes {
/**
* Added in vendor version 0.
* Interleaving ratio if AOA_RESULT_REQ is set to 0xF0.
* Supported only if the value returned by getSupportedAndroidCapabilities()
* has the bit of UwbAndroidCapabilities.ANTENNA_INTERLEAVING set to 1.
* Supported only if the UwbVendorCapabilityTlvTypes
* .SUPPORTED_AOA_RESULT_REQ_ANTENNA_INTERLEAVING set to 1.
*/
/** 2 byte data */
NB_OF_RANGE_MEASUREMENTS = 0xE3,

View File

@@ -30,8 +30,8 @@ package android.hardware.uwb.fira_android;
enum UwbVendorSessionAppConfigTlvValues {
/**
* Added in vendor version 0.
* Supported only if the value returned by getSupportedAndroidCapabilities()
* has the bit of UwbAndroidCapabilities.ANTENNA_INTERLEAVING set to 1.
* Supported only if the UwbVendorCapabilityTlvTypes
* .SUPPORTED_AOA_RESULT_REQ_ANTENNA_INTERLEAVING set to 1.
* Set AOA_RESULT_REQ (Config ID - 0x0D) to this value to turn on antenna
* interleaving feature.
*/

View File

@@ -18,7 +18,6 @@
namespace {
constexpr static int32_t kAndroidUciVersion = 1;
constexpr static int64_t kAndroidCapabilities = 0;
}
namespace android {
@@ -60,11 +59,6 @@ UwbChip::~UwbChip() {}
return ndk::ScopedAStatus::ok();
}
::ndk::ScopedAStatus UwbChip::getSupportedAndroidCapabilities(int64_t* capabilities) {
*capabilities = kAndroidCapabilities;
return ndk::ScopedAStatus::ok();
}
::ndk::ScopedAStatus UwbChip::sendUciMessage(const std::vector<uint8_t>& /* data */,
int32_t* /* bytes_written */) {
// TODO(b/195992658): Need emulator support for UCI stack.

View File

@@ -39,7 +39,6 @@ class UwbChip : public BnUwbChip {
::ndk::ScopedAStatus coreInit() override;
::ndk::ScopedAStatus sessionInit(int sesionId) override;
::ndk::ScopedAStatus getSupportedAndroidUciVersion(int32_t* version) override;
::ndk::ScopedAStatus getSupportedAndroidCapabilities(int64_t* capabilities) override;
::ndk::ScopedAStatus sendUciMessage(const std::vector<uint8_t>& data,
int32_t* bytes_written) override;

View File

@@ -180,14 +180,6 @@ TEST_P(UwbAidl, ChipGetSupportedAndroidUciVersion) {
EXPECT_GT(version, 0);
}
TEST_P(UwbAidl, ChipGetSupportedAndroidCapabilities) {
const auto iuwb_chip = getAnyChipAndOpen();
EXPECT_TRUE(iuwb_chip->coreInit().isOk());
int64_t capabilities;
EXPECT_TRUE(iuwb_chip->getSupportedAndroidCapabilities(&capabilities).isOk());
}
TEST_P(UwbAidl, ChipGetName) {
std::string chip_name = getAnyChipName();
std::shared_ptr<IUwbChip> iuwb_chip;