Evolution-x/hardware_interfaces
1
0
Fork 0
mirror of https://github.com/Evolution-X/hardware_interfaces synced 2026-02-01 11:36:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Loosen speed check for first GPS location

Browse Source 
As it is often found in a short integration
window with very high Doppler uncertainty.

Bug: 67877519
Merged-In: Ia05359f572f4ea7be81f9d5fe30bd619322bebd3
Test: Verified Pixel still passes VTS
Change-Id: Ia05359f572f4ea7be81f9d5fe30bd619322bebd3
(cherry picked from commit 763b4eab01)
This commit is contained in:
Wyatt Riley
2017-10-26 16:37:30 -07:00
committed by Keun Soo Yim
parent c312e21b5e
commit bf4f6db431
1 changed files with 17 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
gnss/1.0/vts/functional/VtsHalGnssV1_0TargetTest.cpp
View File

@@ -208,10 +208,13 @@ TEST_F(GnssHalTest, SetCallbackCapabilitiesCleanup) {}
* CheckLocation:
* Helper function to vet Location fields
*/
void CheckLocation(GnssLocation& location, bool checkAccuracies) {
void CheckLocation(GnssLocation& location, bool checkAccuracies,
bool checkSpeed) {
EXPECT_TRUE(location.gnssLocationFlags & GnssLocationFlags::HAS_LAT_LONG);
EXPECT_TRUE(location.gnssLocationFlags & GnssLocationFlags::HAS_ALTITUDE);
EXPECT_TRUE(location.gnssLocationFlags & GnssLocationFlags::HAS_SPEED);
if (checkSpeed) {
EXPECT_TRUE(location.gnssLocationFlags & GnssLocationFlags::HAS_SPEED);
}
EXPECT_TRUE(location.gnssLocationFlags &
GnssLocationFlags::HAS_HORIZONTAL_ACCURACY);
// New uncertainties available in O must be provided,
@@ -232,12 +235,15 @@ void CheckLocation(GnssLocation& location, bool checkAccuracies) {
EXPECT_LE(location.longitudeDegrees, 180.0);
EXPECT_GE(location.altitudeMeters, -1000.0);
EXPECT_LE(location.altitudeMeters, 30000.0);
EXPECT_GE(location.speedMetersPerSec, 0.0);
EXPECT_LE(location.speedMetersPerSec, 5.0); // VTS tests are stationary.
if (checkSpeed) {
// VTS tests are stationary. 5.0m/s max allows for measurement noise.
EXPECT_GE(location.speedMetersPerSec, 0.0);
EXPECT_LE(location.speedMetersPerSec, 5.0);
// Non-zero speeds must be reported with an associated bearing
if (location.speedMetersPerSec > 0.0) {
EXPECT_TRUE(location.gnssLocationFlags & GnssLocationFlags::HAS_BEARING);
// Non-zero speeds must be reported with an associated bearing
if (location.speedMetersPerSec > 0.0) {
EXPECT_TRUE(location.gnssLocationFlags & GnssLocationFlags::HAS_BEARING);
}
}
/*
@@ -299,7 +305,8 @@ bool StartAndGetSingleLocation(GnssHalTest* test, bool checkAccuracies) {
EXPECT_EQ(test->location_called_count_, 1);
}
if (test->location_called_count_ > 0) {
CheckLocation(test->last_location_, checkAccuracies);
// don't require speed on first fix
CheckLocation(test->last_location_, checkAccuracies, false /* checkSpeed */ );
return true;
}
return false;
@@ -340,7 +347,7 @@ TEST_F(GnssHalTest, GetLocation) {
EXPECT_EQ(std::cv_status::no_timeout,
wait(LOCATION_TIMEOUT_SUBSEQUENT_SEC));
EXPECT_EQ(location_called_count_, i + 1);
CheckLocation(last_location_, checkMoreAccuracies);
CheckLocation(last_location_, checkMoreAccuracies, true /* checkSpeed */);
}
}
@@ -450,4 +457,4 @@ int main(int argc, char** argv) {
int status = RUN_ALL_TESTS();
ALOGI("Test result = %d", status);
return status;
}
}