Evolution-x/hardware_interfaces
1
0
Fork 0
mirror of https://github.com/Evolution-X/hardware_interfaces synced 2026-02-01 22:04:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

add checks to avoid potential buffer overflows and prevent exceptions

Browse Source 
number_platform_modes variable is from another module (e.g.,
eModule->get_number_of_platform_modes(mModule)) and thus can be
a big number. If a big number is used as the size of new operation,
it can cause an exception as is.

Test: mma
Change-Id: I6cf6027804be980ad39c80a1571b284efabce7e8
This commit is contained in:
Keun Soo Yim
2017-01-07 17:53:44 -08:00
parent 15336c44b7
commit c591f88fae
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
power/1.0/default/Power.cpp
View File

@@ -78,7 +78,9 @@ Return<void> Power::getPlatformLowPowerStats(getPlatformLowPowerStats_cb _hidl_c
number_platform_modes = mModule->get_number_of_platform_modes(mModule);
if (number_platform_modes > 0)
{
voters = new size_t [number_platform_modes];
if (SIZE_MAX / sizeof(size_t) <= number_platform_modes) // overflow
goto done;
voters = new (std::nothrow) size_t [number_platform_modes];
if (voters == nullptr)
goto done;
@@ -86,7 +88,11 @@ Return<void> Power::getPlatformLowPowerStats(getPlatformLowPowerStats_cb _hidl_c
if (ret != 0)
goto done;
legacy_states = new power_state_platform_sleep_state_t [number_platform_modes];
if (SIZE_MAX / sizeof(power_state_platform_sleep_state_t)
<= number_platform_modes) // overflow
goto done;
legacy_states = new (std::nothrow)
power_state_platform_sleep_state_t [number_platform_modes];
if (legacy_states == nullptr)
goto done;