Evolution-x/hardware_interfaces
1
0
Fork 0
mirror of https://github.com/Evolution-X/hardware_interfaces synced 2026-02-01 11:36:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix stack-pointer constructed sp<>.

Browse Source 
Seems like the hidl derived objects must be heap allocated.

Bug: 145662746

Test: Does not boot loop.
Change-Id: I55ff94c12d4eb5fcfd680370736db979ddd0b67c
This commit is contained in:
Joshua Duong
2019-12-04 08:06:54 -08:00
parent bff764d944
commit e951f2a640
2 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
broadcastradio/1.1/default/service.cpp
View File

@@ -20,6 +20,7 @@
#include "BroadcastRadioFactory.h"
using android::sp;
using android::hardware::configureRpcThreadpool;
using android::hardware::joinRpcThreadpool;
using android::hardware::broadcastradio::V1_1::implementation::BroadcastRadioFactory;
@@ -27,8 +28,8 @@ using android::hardware::broadcastradio::V1_1::implementation::BroadcastRadioFac
int main(int /* argc */, char** /* argv */) {
configureRpcThreadpool(4, true);
BroadcastRadioFactory broadcastRadioFactory;
auto status = broadcastRadioFactory.registerAsService();
sp<BroadcastRadioFactory> broadcastRadioFactory(new BroadcastRadioFactory());
auto status = broadcastRadioFactory->registerAsService();
CHECK_EQ(status, android::OK) << "Failed to register Broadcast Radio HAL implementation";
joinRpcThreadpool();

9
broadcastradio/2.0/default/service.cpp
View File

@@ -19,6 +19,7 @@
#include "BroadcastRadio.h"
#include "VirtualRadio.h"
using android::sp;
using android::hardware::configureRpcThreadpool;
using android::hardware::joinRpcThreadpool;
using android::hardware::broadcastradio::V2_0::implementation::BroadcastRadio;
@@ -30,13 +31,13 @@ int main() {
android::base::SetMinimumLogSeverity(android::base::VERBOSE);
configureRpcThreadpool(4, true);
BroadcastRadio broadcastRadio(gAmFmRadio);
auto amFmStatus = broadcastRadio.registerAsService("amfm");
sp<BroadcastRadio> broadcastRadio(new BroadcastRadio(gAmFmRadio));
auto amFmStatus = broadcastRadio->registerAsService("amfm");
CHECK_EQ(amFmStatus, android::OK)
<< "Failed to register Broadcast Radio AM/FM HAL implementation";
BroadcastRadio dabRadio(gDabRadio);
auto dabStatus = dabRadio.registerAsService("dab");
sp<BroadcastRadio> dabRadio(new BroadcastRadio(gDabRadio));
auto dabStatus = dabRadio->registerAsService("dab");
CHECK_EQ(dabStatus, android::OK) << "Failed to register Broadcast Radio DAB HAL implementation";
joinRpcThreadpool();