Commit Graph

3660 Commits

Author SHA1 Message Date
Myles Watson
5c54ce150c Enable the clang-format pre-submit hook
Bug: 36699008
Test: Try to upload a patch with formatting errors.
Change-Id: I4af7d142ccbbaf39eb236547487c59c5ff8f2cd6
2017-03-30 13:30:21 -07:00
Shawn Willden
63e15f0790 Revert "Revert "Add keymaster VTS tests.""
This reverts commit 8e10baee45.

Test: Tests pass, except known failures with in-progress vendor fixes
Change-Id: Ia95c1444100e123fa65d095b001878cf9040d0c4
2017-03-30 13:21:54 +00:00
Michael Butler
da8c2c1e2a RenderScript VTS cleanup and fixes
This CL fixes the remaining VTS test cases for the RenderScript
vts-hidl-hal test and cleans up and improves the working test cases.
The goal is to have at least one passing test case per HIDL HAL entry.

Bug: 35915961

Test: mm and run on angler
Change-Id: I4b6e25831ce7d2abb3148c39eb48bde10ed04646
(cherry picked from commit 54fa8d4285)
2017-03-29 17:42:43 -07:00
Michael Butler
1791d9bfab Fix RS HIDL server, pass data by bytes instead of by elements.
Our current stack:
  API->API_TO_HAL_translator->HAL
          ->HAL_TO_Implementation_translator->Implementation

  For most APIs:
  - API passes objectCount.
  - HAL expects objectCount.
  - Implementation expects objectCount.

  For APIs like ScriptGroupCreate:
  - API passes byteCount. And unfortunately, these APIs are part of
    NDK, we could not make them also passing objectCount like others.
  - HAL expects objectCount.
  - Implementation expects byteCount.

  So that both API_TO_HAL_translator and
  HAL_TO_Implementation_translator should correctly convert input
  objectCount/byteCount to byteCount/objectCount.

  This CL only fixes the HAL_TO_Implementation_translator part,
  whereas aosp/356395 fixes the API_TO_HAL_translator part. Both
  parts were mistakenly using byteCount as objectCount, causing
  potential out-of-bound access.

Bug: 36404879
Test: mm on angler
Change-Id: I28541a8926aeafece40e2a3f664bda67e26a34a2
(cherry picked from commit fd14e27b89)
2017-03-29 17:42:33 -07:00
Keun Soo Yim
bf0f670580 Merge "Revert "Add keymaster VTS tests."" into oc-dev 2017-03-29 20:19:28 +00:00
Keun Soo Yim
8e10baee45 Revert "Add keymaster VTS tests."
This reverts commit dda22ea884.

Change-Id: Ie6a60e17ed5258840eba3d3f6b8092636160b2c2
2017-03-29 20:18:52 +00:00
Andreas Huber
8074912d8c Merge "Convert all comments into "doxygen-ready" comments." into oc-dev 2017-03-29 18:48:37 +00:00
Andreas Huber
40d3a9bd8c Convert all comments into "doxygen-ready" comments.
Bug: 36453077
Test: mma
Change-Id: I0b1f77dfae5d2258969e33d85ecf45401ffbdfaa
2017-03-29 08:53:58 -07:00
Shawn Willden
dda22ea884 Add keymaster VTS tests.
Note: Recent Google devices have keymaster implementations that don't
pass this test suite.  See https://goo.gl/6hsGwa for a summary.

Bug: 32022681
Test: This is the test suite.
Change-Id: Ib200b68e0c7844df02eb9f086385d6c36e306d45
2017-03-29 13:28:16 +00:00
Andreas Huber
675ae49ab1 Convert all comments into "doxygen-ready" comments.
Bug: 36453077
Test: make
Change-Id: Ic77394d4d2e1ccedba3a28230d870c5d6108bd40
2017-03-28 16:14:43 -07:00
TreeHugger Robot
2f44ec6c86 Merge "Use gralloc usage conversion library" into oc-dev 2017-03-28 20:55:51 +00:00
Jesse Hall
66ee1771a6 Use gralloc usage conversion library
Converting from ..graphics.allocator@2.0 usage to gralloc0 usage isn't
quite as simple as ORing and truncating, which is what the default
implementation was doing. Switch to using library functions that do it
correctly.

Test: boot bullhead
Change-Id: I40ae00e9aad92b374f281569207972b7461a3e55
2017-03-28 08:23:21 -07:00
Steven Moreland
561b602a99 Update makefiles for hwtypes.h
Test: pass
Change-Id: I8e17eb8fec5d2f04c526476a866c8dd54ccb556c
2017-03-28 15:18:20 +00:00
Ben Fennema
1445e3633a Merge "Add missing LOW_LATENCY_OFFBODY_DETECT handling" 2017-03-28 04:29:32 +00:00
TreeHugger Robot
d809c4ba00 Merge "Fingerprint vts tests." 2017-03-28 04:17:46 +00:00
TreeHugger Robot
779d9f3519 Merge "Revert "Add auth token parsing to IKeymasterDevice.hal"" 2017-03-28 02:37:45 +00:00
Shawn Willden
031b6050b1 Revert "Add auth token parsing to IKeymasterDevice.hal"
This reverts commit 62f63c7ddb.

Reason for revert: b/36637075

Bug: 36637075
Change-Id: Ie0e8d0b480047a7c68f266e7e5d8a31722f85128
2017-03-28 00:44:17 +00:00
TreeHugger Robot
827fac697a Merge "Sync the constants in HAL and framework" 2017-03-28 00:02:23 +00:00
Roshan Pius
85dfec5dc3 wifi(implementation): Stop loading vendor library statically am: 34e4bc4dd2 am: c17e4e07ac
am: 0e5e51175c

Change-Id: Ib1e6cc90a4388e49fda3608fb193e15fb66aef80
2017-03-27 22:36:14 +00:00
Roshan Pius
0e5e51175c wifi(implementation): Stop loading vendor library statically am: 34e4bc4dd2
am: c17e4e07ac

Change-Id: I843085db6544dd9c14feb611b709f48e6284c901
2017-03-27 22:33:13 +00:00
Roshan Pius
c17e4e07ac wifi(implementation): Stop loading vendor library statically
am: 34e4bc4dd2

Change-Id: I614a2074fbc2d82618eeb72002724830cf888dab
2017-03-27 22:30:43 +00:00
Roshan Pius
34e4bc4dd2 wifi(implementation): Stop loading vendor library statically
libwifi-hal statically imports the vendor implementation of the legacy
HAL. Since the HIDL daemon is dynamically linking against libwif-hal,
there is no need for it to statically import the vendor implementation
library (one pointed to by: $LIBWIFI-HAL variable).

Bug: 36169790
Test: Compiles & device is able to connect to wifi networks with the
change.

Change-Id: Ie44b58328f9bdde011ba6d4a4d26f786c2d097e7
2017-03-27 22:14:04 +00:00
Kevin Chyn
dfe3d8186f Fingerprint vts tests.
Fix callback mechanism. Add tests for uncovered interfaces.

Test: make vts && adb push
out/host/linux-x86/vts/android-vts/testcases/DATA/nativetest64/VtsHalBiometricsFingerprintV2_1TargetTest/VtsHalBiometricsFingerprintV2_1TargetTest
/data/local/tmp/ && adb shell
./data/local/tmp/VtsHalBiometricsFingerprintV2_1TargetTest
Bug: 32022721
Change-Id: Ibeb955bfb937d9f23f98a2e073235aa745183e94
2017-03-27 13:33:43 -07:00
Shubang
0efb7e07a2 Sync the constants in HAL and framework
Test: build and flash device.

Bug: 36233336
Change-Id: I8134b8bded5e31561a97938bdf86a43f7c2b6dc5
2017-03-27 13:09:04 -07:00
TreeHugger Robot
8b624737d7 Merge "audiohal: Add crash tests for some methods of IEffect" 2017-03-27 17:57:55 +00:00
Steven Moreland
53b21566bc Update makefiles. am: e90c31f125 am: f11981de68
am: 103bada0e1

Change-Id: Ibe6eeeacab5660a8cf70d59dd9a4864d6f70ab80
2017-03-27 17:51:28 +00:00
Steven Moreland
103bada0e1 Update makefiles. am: e90c31f125
am: f11981de68

Change-Id: Icf25d969d83dff9653435d5fff0edb6b274a9d9f
2017-03-27 17:48:27 +00:00
Steven Moreland
f11981de68 Update makefiles.
am: e90c31f125

Change-Id: I370a9a20b005d7510463594b24e5c4fc8791116a
2017-03-27 17:45:26 +00:00
Steven Moreland
e90c31f125 Update makefiles.
Test: pass
Change-Id: I925baccbe51a32b7b7f3f66cf2918d017ee6b039
2017-03-24 21:50:45 -07:00
Shawn Willden
62f63c7ddb Add auth token parsing to IKeymasterDevice.hal
Auth tokens have an unfortunate dual character. To most of the system
they are opaque blobs that are intended only to be obtained from one
HAL (e.g. gatekeeper or fingerprint) and passed to another
HAL (keymaster), but keystore actually needs to extract some bits of
information from them in order to determine which of the available blobs
should be provided for a given keymaster key operation.

This CL adds a method that resolves this dual nature by moving the
responsibility of parsing blobs to the HAL so that no component of the
framework has to make any assumptions about their content and all can
treat them as fully opaque. This still means that the various HAL
implementers have to agree on content, but they also have to agree on an
HMAC key which much be securely distributed to all at every boot, so
asking them to agree on an auth token format is perfectly
acceptable. But now the Android system doesn't have to care about the
format.

Bug: 32962548
Test: CTS tests pass, plus manual testing.
Change-Id: I78aa6e4ea9c5d8f34906b0969909387e2c5894e6
2017-03-24 22:22:34 -06:00
Shawn Willden
b01e1a8d56 Note that auth token is opaque.
Change-Id: I788ab8c5be630dd818a9a442c487c3451029bf81
Test: N/A, comment-only change
Bug: 34985116
2017-03-24 22:22:34 -06:00
Ben Fennema
b2969d4eaa Add missing LOW_LATENCY_OFFBODY_DETECT handling
Bug: 36580454
Test: unlock watch with LLOB sensor and verify no SensorService crash
Change-Id: Ib1d086efd80e829bb844521fa39325f095b1c2c9
Signed-off-by: Ben Fennema <fennema@google.com>
2017-03-24 19:23:51 -07:00
Shawn Willden
d4417fb982 Add digest support and implementation name to getHardwareFeatures
This is needed to support the keystore statistics gathering initiative.
It will allow us to get information about what kinds of keymaster
implementations exist in the ecosystem, and which ones fail in which
ways.

Bug: 36549319
Test: Will add to VTS tests
Change-Id: I49ee4623656060d69a6de7723b11cd715150451a
2017-03-25 02:09:14 +00:00
TreeHugger Robot
fcddf877d9 Merge "Remove viral readproc group dependency." 2017-03-25 00:58:58 +00:00
Mikhail Naganov
05fa0d0312 audiohal: Add crash tests for some methods of IEffect
For methods that can't be meaningfully tested, add tests
verifying that they at least don't crash.

Bug: 32022706
Change-Id: I234c2ae4b6bc173450cf50e8749ea966cbc2d2a2
Test: this is a test
2017-03-24 17:06:25 -07:00
Shuo Qian
af59bc0e76 Merge "Remove GENERIC_FAILURE and INVALID_ARGUMENT for Api documentation" am: 2d0b636b29 am: 0efe019342
am: 56fc4104b9

Change-Id: Ia37f47663ce7932c9d294512b7af011849e27c97
2017-03-24 17:30:27 +00:00
Shuo Qian
56fc4104b9 Merge "Remove GENERIC_FAILURE and INVALID_ARGUMENT for Api documentation" am: 2d0b636b29
am: 0efe019342

Change-Id: I6a2cc30754413eccb59ba775c14863852a89fefc
2017-03-24 17:27:54 +00:00
Shuo Qian
0efe019342 Merge "Remove GENERIC_FAILURE and INVALID_ARGUMENT for Api documentation"
am: 2d0b636b29

Change-Id: I342068f8bbcf6a97c322bcf0049fed83b519bcda
2017-03-24 17:26:26 +00:00
Shuo Qian
2d0b636b29 Merge "Remove GENERIC_FAILURE and INVALID_ARGUMENT for Api documentation" 2017-03-24 17:21:18 +00:00
Etan Cohen
b0c0035d25 Merge "[WIFI] Restore initialization code" am: 8f4416aabb am: 3ae14f0ead
am: 058ed46d36

Change-Id: I8c2a70819cf1acf8b6edd8743f7c536a580ce66a
2017-03-24 16:17:14 +00:00
Etan Cohen
058ed46d36 Merge "[WIFI] Restore initialization code" am: 8f4416aabb
am: 3ae14f0ead

Change-Id: I96f5c77e7f9ee3b84f4a6cf7973638d3d4bba68d
2017-03-24 16:15:13 +00:00
Tomasz Wasilczyk
094c1d9de8 Merge "Add background scan routines and callbacks to broadcast radio HAL." 2017-03-24 16:14:21 +00:00
Wyatt Riley
fdfe21bf9a Merge "Improved GNSS HAL VTS test coverage" 2017-03-24 16:13:25 +00:00
Etan Cohen
3ae14f0ead Merge "[WIFI] Restore initialization code"
am: 8f4416aabb

Change-Id: I9f0f828d542e337f185c4a423748f57ef53a00ce
2017-03-24 16:12:43 +00:00
Etan Cohen
8f4416aabb Merge "[WIFI] Restore initialization code" 2017-03-24 16:08:56 +00:00
TreeHugger Robot
5306597978 Merge "Handle hidl transaction errors in ConfigStore" 2017-03-24 05:50:23 +00:00
Jaesoo Lee
ad11f288e5 Merge "removed unused function (HIDL_FETCH_ISurfaceFlingerConfigs)" am: d5934d06f1 am: 1d5ccbd5ea
am: a0032e3990  -s ours

Change-Id: I9281cd8f52e698505d921d4f1094c823ab102b1d
2017-03-24 03:32:06 +00:00
Jaesoo Lee
a0032e3990 Merge "removed unused function (HIDL_FETCH_ISurfaceFlingerConfigs)" am: d5934d06f1
am: 1d5ccbd5ea

Change-Id: Idccb5e03b143ec2462479e32d0bd20555d32cd63
2017-03-24 03:29:34 +00:00
Jaesoo Lee
1d5ccbd5ea Merge "removed unused function (HIDL_FETCH_ISurfaceFlingerConfigs)"
am: d5934d06f1

Change-Id: I958c1285dbb5e3c6db8145ac743cedfb61cd544c
2017-03-24 03:27:35 +00:00
Jaesoo Lee
d5934d06f1 Merge "removed unused function (HIDL_FETCH_ISurfaceFlingerConfigs)" 2017-03-24 03:23:27 +00:00